From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] sylpheed: Fix includedir
Date: Mon, 08 Oct 2012 09:32:26 +0200 [thread overview]
Message-ID: <5072818A.8030800@mind.be> (raw)
In-Reply-To: <1349649599-12615-1-git-send-email-gvaxon@gmail.com>
On 08/10/12 00:39, Valentine Barshak wrote:
> The sylpheed headers are installed to $(DESTDIR)$(includedir),
> while DESTDIR is $(TARGET_DIR) and includedir is set to
> $(STAGING_DIR)/usr/include in the SYLPHEED_CONF_OPT.
> Thus, the full staging directory path is created in the
> target root filesystem, which is wrong.
>
> The includedir was set to staging include because sylpheed
> incorrectly adds includedir to its include path, and does
> not cross-compile with the default includedir set to
> /usr/include.
>
> This removes includedir setting and also removes it from
> include paths in Makefiles to prevent using host headers
> from /usr/include. The same approach is used in the OE.
>
> Signed-off-by: Valentine Barshak<gvaxon@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
(untested)
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-10-08 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 22:39 [Buildroot] [PATCH v3] sylpheed: Fix includedir Valentine Barshak
2012-10-08 7:32 ` Arnout Vandecappelle [this message]
2012-10-08 9:01 ` Thomas Petazzoni
2012-10-08 18:37 ` Valentine Barshak
2012-10-10 12:58 ` Valentine Barshak
2012-10-10 14:42 ` Peter Korsgaard
2012-10-08 19:40 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5072818A.8030800@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.