From: Tony Lindgren <tony@atomide.com>
To: Stan Hu <stanhu@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Grant Likely <grant.likely@secretlab.ca>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ARM: Add option to configure output line for McSPI driver
Date: Mon, 8 Oct 2012 13:50:53 -0700 [thread overview]
Message-ID: <20121008205052.GB13011@atomide.com> (raw)
In-Reply-To: <1348684467-5707-1-git-send-email-stanhu@gmail.com>
* Stan Hu <stanhu@gmail.com> [120926 11:36]:
> McSPI driver previously assumed that D0 was input (MISO) and D1 was output (MOSI).
> This forces the hardware designer to wire all SPI peripherals in this way when
> it should be a software configuration option.
>
> Signed-off-by: Stan Hu <stanhu@gmail.com>
> ---
> arch/arm/plat-omap/include/plat/mcspi.h | 2 ++
> drivers/spi/spi-omap2-mcspi.c | 11 +++++++++--
> 2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/mcspi.h b/arch/arm/plat-omap/include/plat/mcspi.h
> index a357eb2..0a6b790 100644
> --- a/arch/arm/plat-omap/include/plat/mcspi.h
> +++ b/arch/arm/plat-omap/include/plat/mcspi.h
> @@ -18,6 +18,8 @@ struct omap2_mcspi_dev_attr {
>
> struct omap2_mcspi_device_config {
> unsigned turbo_mode:1;
> + /* 1 -> [D0 = MOSI, D1 = MISO], otherwise vice versa */
> + unsigned d0_is_output:1;
> };
>
> #endif
FYI, if this did not yet get applied, this header has now been
moved to linux/platform_data/spi-omap2-mcspi.h. So you may want
to updated it and repost.
Also, you should probably Cc spi-devel-general@lists.sourceforge.net.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: Add option to configure output line for McSPI driver
Date: Mon, 8 Oct 2012 13:50:53 -0700 [thread overview]
Message-ID: <20121008205052.GB13011@atomide.com> (raw)
In-Reply-To: <1348684467-5707-1-git-send-email-stanhu@gmail.com>
* Stan Hu <stanhu@gmail.com> [120926 11:36]:
> McSPI driver previously assumed that D0 was input (MISO) and D1 was output (MOSI).
> This forces the hardware designer to wire all SPI peripherals in this way when
> it should be a software configuration option.
>
> Signed-off-by: Stan Hu <stanhu@gmail.com>
> ---
> arch/arm/plat-omap/include/plat/mcspi.h | 2 ++
> drivers/spi/spi-omap2-mcspi.c | 11 +++++++++--
> 2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/mcspi.h b/arch/arm/plat-omap/include/plat/mcspi.h
> index a357eb2..0a6b790 100644
> --- a/arch/arm/plat-omap/include/plat/mcspi.h
> +++ b/arch/arm/plat-omap/include/plat/mcspi.h
> @@ -18,6 +18,8 @@ struct omap2_mcspi_dev_attr {
>
> struct omap2_mcspi_device_config {
> unsigned turbo_mode:1;
> + /* 1 -> [D0 = MOSI, D1 = MISO], otherwise vice versa */
> + unsigned d0_is_output:1;
> };
>
> #endif
FYI, if this did not yet get applied, this header has now been
moved to linux/platform_data/spi-omap2-mcspi.h. So you may want
to updated it and repost.
Also, you should probably Cc spi-devel-general at lists.sourceforge.net.
Regards,
Tony
next prev parent reply other threads:[~2012-10-08 20:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 18:34 [PATCH 1/1] ARM: Add option to configure output line for McSPI driver Stan Hu
2012-09-26 18:34 ` Stan Hu
2012-10-08 20:50 ` Tony Lindgren [this message]
2012-10-08 20:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121008205052.GB13011@atomide.com \
--to=tony@atomide.com \
--cc=grant.likely@secretlab.ca \
--cc=jarkko.nikula@bitmer.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=stanhu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.