* [PATCH V2] ARM: OMAP2+: Round of the carve out memory requested to section_size
@ 2012-09-12 7:14 ` R Sricharan
0 siblings, 0 replies; 6+ messages in thread
From: R Sricharan @ 2012-09-12 7:14 UTC (permalink / raw)
To: linux-arm-kernel, linux-omap; +Cc: r.sricharan, santosh.shilimkar
memblock_steal tries to reserve physical memory during boot.
When the requested size is not aligned on the section size
then, the remaining memory available for lowmem becomes
unaligned on the section boundary. There is a issue with this,
which is discussed in the thread below.
https://lkml.org/lkml/2012/6/28/112
The final conclusion from the thread seems to
be align the memblock_steal calls on the SECTION boundary.
The issue comes out when LPAE is enabled, where the
section size is 2MB.
Boot tested this on OMAP5 evm with and without LPAE.
Signed-off-by: R Sricharan <r.sricharan@ti.com>
---
[V2] Corrected the subject and added one more description line.
arch/arm/mach-omap2/omap-secure.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap-secure.c b/arch/arm/mach-omap2/omap-secure.c
index d9ae4a5..26edfec 100644
--- a/arch/arm/mach-omap2/omap-secure.c
+++ b/arch/arm/mach-omap2/omap-secure.c
@@ -61,8 +61,8 @@ int __init omap_secure_ram_reserve_memblock(void)
{
u32 size = OMAP_SECURE_RAM_STORAGE;
- size = ALIGN(size, SZ_1M);
- omap_secure_memblock_base = arm_memblock_steal(size, SZ_1M);
+ size = ALIGN(size, SECTION_SIZE);
+ omap_secure_memblock_base = arm_memblock_steal(size, SECTION_SIZE);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V2] ARM: OMAP2+: Round of the carve out memory requested to section_size
@ 2012-09-12 7:14 ` R Sricharan
0 siblings, 0 replies; 6+ messages in thread
From: R Sricharan @ 2012-09-12 7:14 UTC (permalink / raw)
To: linux-arm-kernel
memblock_steal tries to reserve physical memory during boot.
When the requested size is not aligned on the section size
then, the remaining memory available for lowmem becomes
unaligned on the section boundary. There is a issue with this,
which is discussed in the thread below.
https://lkml.org/lkml/2012/6/28/112
The final conclusion from the thread seems to
be align the memblock_steal calls on the SECTION boundary.
The issue comes out when LPAE is enabled, where the
section size is 2MB.
Boot tested this on OMAP5 evm with and without LPAE.
Signed-off-by: R Sricharan <r.sricharan@ti.com>
---
[V2] Corrected the subject and added one more description line.
arch/arm/mach-omap2/omap-secure.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap-secure.c b/arch/arm/mach-omap2/omap-secure.c
index d9ae4a5..26edfec 100644
--- a/arch/arm/mach-omap2/omap-secure.c
+++ b/arch/arm/mach-omap2/omap-secure.c
@@ -61,8 +61,8 @@ int __init omap_secure_ram_reserve_memblock(void)
{
u32 size = OMAP_SECURE_RAM_STORAGE;
- size = ALIGN(size, SZ_1M);
- omap_secure_memblock_base = arm_memblock_steal(size, SZ_1M);
+ size = ALIGN(size, SECTION_SIZE);
+ omap_secure_memblock_base = arm_memblock_steal(size, SECTION_SIZE);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2] ARM: OMAP2+: Round of the carve out memory requested to section_size
2012-09-12 7:14 ` R Sricharan
@ 2012-09-28 6:33 ` Shilimkar, Santosh
-1 siblings, 0 replies; 6+ messages in thread
From: Shilimkar, Santosh @ 2012-09-28 6:33 UTC (permalink / raw)
To: R Sricharan, Tony; +Cc: linux-arm-kernel, linux-omap
On Wed, Sep 12, 2012 at 12:44 PM, R Sricharan <r.sricharan@ti.com> wrote:
> memblock_steal tries to reserve physical memory during boot.
> When the requested size is not aligned on the section size
> then, the remaining memory available for lowmem becomes
> unaligned on the section boundary. There is a issue with this,
> which is discussed in the thread below.
>
> https://lkml.org/lkml/2012/6/28/112
>
> The final conclusion from the thread seems to
> be align the memblock_steal calls on the SECTION boundary.
> The issue comes out when LPAE is enabled, where the
> section size is 2MB.
>
> Boot tested this on OMAP5 evm with and without LPAE.
>
> Signed-off-by: R Sricharan <r.sricharan@ti.com>
> ---
> [V2] Corrected the subject and added one more description line.
>
Looks good.
Acked-by : Santosh Shilimkar <santosh.shilimkar@ti.com>
Tony,
Can you take this into your next "fixes-noncritical" queue please ?
Regards,
Santosh
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2] ARM: OMAP2+: Round of the carve out memory requested to section_size
@ 2012-09-28 6:33 ` Shilimkar, Santosh
0 siblings, 0 replies; 6+ messages in thread
From: Shilimkar, Santosh @ 2012-09-28 6:33 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 12, 2012 at 12:44 PM, R Sricharan <r.sricharan@ti.com> wrote:
> memblock_steal tries to reserve physical memory during boot.
> When the requested size is not aligned on the section size
> then, the remaining memory available for lowmem becomes
> unaligned on the section boundary. There is a issue with this,
> which is discussed in the thread below.
>
> https://lkml.org/lkml/2012/6/28/112
>
> The final conclusion from the thread seems to
> be align the memblock_steal calls on the SECTION boundary.
> The issue comes out when LPAE is enabled, where the
> section size is 2MB.
>
> Boot tested this on OMAP5 evm with and without LPAE.
>
> Signed-off-by: R Sricharan <r.sricharan@ti.com>
> ---
> [V2] Corrected the subject and added one more description line.
>
Looks good.
Acked-by : Santosh Shilimkar <santosh.shilimkar@ti.com>
Tony,
Can you take this into your next "fixes-noncritical" queue please ?
Regards,
Santosh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2] ARM: OMAP2+: Round of the carve out memory requested to section_size
2012-09-28 6:33 ` Shilimkar, Santosh
@ 2012-10-08 21:05 ` Tony Lindgren
-1 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2012-10-08 21:05 UTC (permalink / raw)
To: Shilimkar, Santosh; +Cc: R Sricharan, linux-arm-kernel, linux-omap
* Shilimkar, Santosh <santosh.shilimkar@ti.com> [120927 23:35]:
> On Wed, Sep 12, 2012 at 12:44 PM, R Sricharan <r.sricharan@ti.com> wrote:
> > memblock_steal tries to reserve physical memory during boot.
> > When the requested size is not aligned on the section size
> > then, the remaining memory available for lowmem becomes
> > unaligned on the section boundary. There is a issue with this,
> > which is discussed in the thread below.
> >
> > https://lkml.org/lkml/2012/6/28/112
> >
> > The final conclusion from the thread seems to
> > be align the memblock_steal calls on the SECTION boundary.
> > The issue comes out when LPAE is enabled, where the
> > section size is 2MB.
> >
> > Boot tested this on OMAP5 evm with and without LPAE.
> >
> > Signed-off-by: R Sricharan <r.sricharan@ti.com>
> > ---
> > [V2] Corrected the subject and added one more description line.
> >
> Looks good.
> Acked-by : Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> Tony,
> Can you take this into your next "fixes-noncritical" queue please ?
Applying it now into fixes for the -rc cycle.
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2] ARM: OMAP2+: Round of the carve out memory requested to section_size
@ 2012-10-08 21:05 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2012-10-08 21:05 UTC (permalink / raw)
To: linux-arm-kernel
* Shilimkar, Santosh <santosh.shilimkar@ti.com> [120927 23:35]:
> On Wed, Sep 12, 2012 at 12:44 PM, R Sricharan <r.sricharan@ti.com> wrote:
> > memblock_steal tries to reserve physical memory during boot.
> > When the requested size is not aligned on the section size
> > then, the remaining memory available for lowmem becomes
> > unaligned on the section boundary. There is a issue with this,
> > which is discussed in the thread below.
> >
> > https://lkml.org/lkml/2012/6/28/112
> >
> > The final conclusion from the thread seems to
> > be align the memblock_steal calls on the SECTION boundary.
> > The issue comes out when LPAE is enabled, where the
> > section size is 2MB.
> >
> > Boot tested this on OMAP5 evm with and without LPAE.
> >
> > Signed-off-by: R Sricharan <r.sricharan@ti.com>
> > ---
> > [V2] Corrected the subject and added one more description line.
> >
> Looks good.
> Acked-by : Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> Tony,
> Can you take this into your next "fixes-noncritical" queue please ?
Applying it now into fixes for the -rc cycle.
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-08 21:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-12 7:14 [PATCH V2] ARM: OMAP2+: Round of the carve out memory requested to section_size R Sricharan
2012-09-12 7:14 ` R Sricharan
2012-09-28 6:33 ` Shilimkar, Santosh
2012-09-28 6:33 ` Shilimkar, Santosh
2012-10-08 21:05 ` Tony Lindgren
2012-10-08 21:05 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.