From: Tony Lindgren <tony@atomide.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Bryan Wu <bryan.wu@canonical.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS
Date: Mon, 8 Oct 2012 14:59:51 -0700 [thread overview]
Message-ID: <20121008215950.GV13011@atomide.com> (raw)
In-Reply-To: <1349604805.6017.1.camel@phoenix>
* Axel Lin <axel.lin@ingics.com> [121007 03:14]:
> This fixes below build error when CONFIG_LEDS_CLASS is not set.
>
> LD init/built-in.o
> arch/arm/plat-omap/built-in.o: In function `fpga_probe':
> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
> arch/arm/plat-omap/built-in.o:arch/arm/plat-omap/debug-leds.c:113: more undefined references to `led_classdev_register' follow
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Thanks looks like I have already an earlier version of the same
patch from you already queued.
Regards,
Tony
> ---
> arch/arm/plat-omap/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index ca83a76..c262781 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -43,6 +43,7 @@ config OMAP_DEBUG_DEVICES
>
> config OMAP_DEBUG_LEDS
> def_bool y if NEW_LEDS
> + select LEDS_CLASS
> depends on OMAP_DEBUG_DEVICES
>
> config POWER_AVS_OMAP
> --
> 1.7.9.5
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS
Date: Mon, 8 Oct 2012 14:59:51 -0700 [thread overview]
Message-ID: <20121008215950.GV13011@atomide.com> (raw)
In-Reply-To: <1349604805.6017.1.camel@phoenix>
* Axel Lin <axel.lin@ingics.com> [121007 03:14]:
> This fixes below build error when CONFIG_LEDS_CLASS is not set.
>
> LD init/built-in.o
> arch/arm/plat-omap/built-in.o: In function `fpga_probe':
> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
> arch/arm/plat-omap/built-in.o:arch/arm/plat-omap/debug-leds.c:113: more undefined references to `led_classdev_register' follow
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Thanks looks like I have already an earlier version of the same
patch from you already queued.
Regards,
Tony
> ---
> arch/arm/plat-omap/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index ca83a76..c262781 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -43,6 +43,7 @@ config OMAP_DEBUG_DEVICES
>
> config OMAP_DEBUG_LEDS
> def_bool y if NEW_LEDS
> + select LEDS_CLASS
> depends on OMAP_DEBUG_DEVICES
>
> config POWER_AVS_OMAP
> --
> 1.7.9.5
>
>
>
next prev parent reply other threads:[~2012-10-08 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 10:13 [PATCH v2] ARM: OMAP: Fix dependency for OMAP_DEBUG_LEDS Axel Lin
2012-10-07 10:13 ` Axel Lin
2012-10-08 21:59 ` Tony Lindgren [this message]
2012-10-08 21:59 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121008215950.GV13011@atomide.com \
--to=tony@atomide.com \
--cc=axel.lin@ingics.com \
--cc=bryan.wu@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.