From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: "lrg@ti.com" <lrg@ti.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
Venu Byravarasu <vbyravarasu@nvidia.com>,
"axel.lin@gmail.com" <axel.lin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] regulator: tps65090: add external control support for DCDC
Date: Tue, 9 Oct 2012 16:04:09 +0900 [thread overview]
Message-ID: <20121009070407.GU8237@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <5073C25F.4030900@nvidia.com>
On Tue, Oct 09, 2012 at 11:51:19AM +0530, Laxman Dewangan wrote:
> On Tuesday 09 October 2012 11:58 AM, Mark Brown wrote:
> >There's support for GPIO driven enable lines in the framework already,
> >this driver should be able to use this happily, this sort of hardware is
> >exactly the use case it was written for.
> yes, I am using the gpio driven enable lines in the framework.
> This patch does the some configuration in register to enable external
> control and configure the regulator_config (fill gpio related stuff
> in config) before registering
> the regulator. There is no call of gpio libs from the driver.
The code seemed way more complex than that... did you notice the fact
that if a GPIO is specified then the register enable/disable control
will be ignored if provided?
prev parent reply other threads:[~2012-10-09 7:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-06 15:17 [PATCH 0/5] regulator: tps65090: fix regulator registration and add external control support Laxman Dewangan
2012-10-06 15:17 ` [PATCH] regulator: TPS51632: Add tps51632 regulator driver Laxman Dewangan
2012-10-09 6:14 ` Mark Brown
2012-10-09 6:07 ` Laxman Dewangan
2012-10-06 15:17 ` [PATCH 1/5] regulator: tps65090: rename driver name and regulator name Laxman Dewangan
2012-10-08 5:53 ` Venu Byravarasu
2012-10-08 6:00 ` Laxman Dewangan
2012-10-06 15:17 ` [PATCH 2/5] regulator; tps65090: Register all regulators in single probe call Laxman Dewangan
2012-10-09 6:22 ` Mark Brown
2012-10-09 6:16 ` Laxman Dewangan
2012-10-06 15:17 ` [PATCH 3/5] regulator: tps65090: Add support for LDO regulators Laxman Dewangan
2012-10-06 15:17 ` [PATCH 4/5] regulator: tps65090: Add voltage out level in platform data Laxman Dewangan
2012-10-09 6:26 ` Mark Brown
2012-10-06 15:17 ` [PATCH 5/5] regulator: tps65090: add external control support for DCDC Laxman Dewangan
2012-10-08 5:45 ` Venu Byravarasu
2012-10-08 5:58 ` Laxman Dewangan
2012-10-09 6:28 ` Mark Brown
2012-10-09 6:21 ` Laxman Dewangan
2012-10-09 7:04 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009070407.GU8237@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.