From: Ivan Djelic <ivan.djelic@parrot.com>
To: "Mohammed, Afzal" <afzal@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
Tony Lindgren <tony@atomide.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Hunter, Jon" <jon-hunter@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage
Date: Wed, 10 Oct 2012 18:38:41 +0200 [thread overview]
Message-ID: <20121010163840.GA13585@parrot.com> (raw)
In-Reply-To: <C8443D0743D26F4388EA172BF4E2A7A93E9F7B0A@DBDE01.ent.ti.com>
On Mon, Oct 08, 2012 at 07:08:08AM +0100, Mohammed, Afzal wrote:
> Hi Ivan,
>
> On Mon, Oct 08, 2012 at 11:05:56, Mohammed, Afzal wrote:
>
> > This series cleans up omap-gpmc related code so that omap can
> > be a part of common zImage.
>
> > This series moves gpmc.h from plat-omap/include/plat to mach-omap2
> > so that header file is local.
>
> > Patches 7 & 8 cleans up the already moved platform data header files
> > to contain only platform data. Also gpmc-nand information is moved
> > to nand platform data header.
> >
> > Patches 9-13 makes nand driver independent of gpmc header file
> >
> > And the final patch localizes gpmc header.
>
> BCH[48] support that you have added on OMAP using gpmc exported
> symbols has been changed such that nand driver now takes care
> of BCH support without relying on gpmc exported symbols.
>
> This is more or less a cut & paste of your implementation, which was
> necessitated now due to common ARM zImage cleanup w.r.t header files.
>
> Please verify that BCH[48] works as earlier with this series.
Hi Afzal,
I ran several mtd regression tests on a Beagle Board on your gpmc-czimage-v2 tag.
All BCH error correcting tests passed successfully.
I occasionally had weird read errors though, especially when reading blank pages:
the omap driver returned 512-byte sectors containing something like:
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
instead of:
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
I was able to reproduce the problem also on l2-mtd tip, albeit less often.
The problem seems to occur quite randomly, it may be a hardware issue on
my board...
Anyway, the ECC handling part looks OK to me.
Best regards,
--
Ivan
WARNING: multiple messages have this Message-ID (diff)
From: Ivan Djelic <ivan.djelic@parrot.com>
To: "Mohammed, Afzal" <afzal@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
"Hunter, Jon" <jon-hunter@ti.com>, Paul Walmsley <paul@pwsan.com>,
David Woodhouse <dwmw2@infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage
Date: Wed, 10 Oct 2012 18:38:41 +0200 [thread overview]
Message-ID: <20121010163840.GA13585@parrot.com> (raw)
In-Reply-To: <C8443D0743D26F4388EA172BF4E2A7A93E9F7B0A@DBDE01.ent.ti.com>
On Mon, Oct 08, 2012 at 07:08:08AM +0100, Mohammed, Afzal wrote:
> Hi Ivan,
>
> On Mon, Oct 08, 2012 at 11:05:56, Mohammed, Afzal wrote:
>
> > This series cleans up omap-gpmc related code so that omap can
> > be a part of common zImage.
>
> > This series moves gpmc.h from plat-omap/include/plat to mach-omap2
> > so that header file is local.
>
> > Patches 7 & 8 cleans up the already moved platform data header files
> > to contain only platform data. Also gpmc-nand information is moved
> > to nand platform data header.
> >
> > Patches 9-13 makes nand driver independent of gpmc header file
> >
> > And the final patch localizes gpmc header.
>
> BCH[48] support that you have added on OMAP using gpmc exported
> symbols has been changed such that nand driver now takes care
> of BCH support without relying on gpmc exported symbols.
>
> This is more or less a cut & paste of your implementation, which was
> necessitated now due to common ARM zImage cleanup w.r.t header files.
>
> Please verify that BCH[48] works as earlier with this series.
Hi Afzal,
I ran several mtd regression tests on a Beagle Board on your gpmc-czimage-v2 tag.
All BCH error correcting tests passed successfully.
I occasionally had weird read errors though, especially when reading blank pages:
the omap driver returned 512-byte sectors containing something like:
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
instead of:
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
I was able to reproduce the problem also on l2-mtd tip, albeit less often.
The problem seems to occur quite randomly, it may be a hardware issue on
my board...
Anyway, the ECC handling part looks OK to me.
Best regards,
--
Ivan
WARNING: multiple messages have this Message-ID (diff)
From: ivan.djelic@parrot.com (Ivan Djelic)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage
Date: Wed, 10 Oct 2012 18:38:41 +0200 [thread overview]
Message-ID: <20121010163840.GA13585@parrot.com> (raw)
In-Reply-To: <C8443D0743D26F4388EA172BF4E2A7A93E9F7B0A@DBDE01.ent.ti.com>
On Mon, Oct 08, 2012 at 07:08:08AM +0100, Mohammed, Afzal wrote:
> Hi Ivan,
>
> On Mon, Oct 08, 2012 at 11:05:56, Mohammed, Afzal wrote:
>
> > This series cleans up omap-gpmc related code so that omap can
> > be a part of common zImage.
>
> > This series moves gpmc.h from plat-omap/include/plat to mach-omap2
> > so that header file is local.
>
> > Patches 7 & 8 cleans up the already moved platform data header files
> > to contain only platform data. Also gpmc-nand information is moved
> > to nand platform data header.
> >
> > Patches 9-13 makes nand driver independent of gpmc header file
> >
> > And the final patch localizes gpmc header.
>
> BCH[48] support that you have added on OMAP using gpmc exported
> symbols has been changed such that nand driver now takes care
> of BCH support without relying on gpmc exported symbols.
>
> This is more or less a cut & paste of your implementation, which was
> necessitated now due to common ARM zImage cleanup w.r.t header files.
>
> Please verify that BCH[48] works as earlier with this series.
Hi Afzal,
I ran several mtd regression tests on a Beagle Board on your gpmc-czimage-v2 tag.
All BCH error correcting tests passed successfully.
I occasionally had weird read errors though, especially when reading blank pages:
the omap driver returned 512-byte sectors containing something like:
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff
30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ff30ffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
instead of:
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
I was able to reproduce the problem also on l2-mtd tip, albeit less often.
The problem seems to occur quite randomly, it may be a hardware issue on
my board...
Anyway, the ECC handling part looks OK to me.
Best regards,
--
Ivan
next prev parent reply other threads:[~2012-10-10 16:38 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 5:35 [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage Afzal Mohammed
2012-10-08 5:35 ` Afzal Mohammed
2012-10-08 5:35 ` Afzal Mohammed
2012-10-08 5:36 ` [PATCH v2 01/14] ARM: OMAP2+: gpmc: annotate exit sections properly Afzal Mohammed
2012-10-08 5:36 ` Afzal Mohammed
2012-10-08 5:36 ` Afzal Mohammed
2012-10-08 5:36 ` [PATCH v2 02/14] mtd: onenand: omap: cleanup gpmc dependency Afzal Mohammed
2012-10-08 5:36 ` Afzal Mohammed
2012-10-08 5:36 ` Afzal Mohammed
2012-10-08 5:36 ` [PATCH v2 03/14] mtd: nand: omap: free region as per resource size Afzal Mohammed
2012-10-08 5:36 ` Afzal Mohammed
2012-10-08 5:36 ` Afzal Mohammed
2012-10-08 5:37 ` [PATCH v2 04/14] mtd: nand: omap: read nand using register address Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` [PATCH v2 05/14] ARM: OMAP2+: onenand: connected soc info in pdata Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` [PATCH v2 06/14] mtd: onenand: omap: use pdata info instead of cpu_is Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-26 1:48 ` Paul Walmsley
2012-10-26 1:48 ` Paul Walmsley
2012-10-26 1:48 ` Paul Walmsley
2012-10-26 5:04 ` Paul Walmsley
2012-10-26 5:04 ` Paul Walmsley
2012-10-26 5:04 ` Paul Walmsley
2012-10-26 16:41 ` Tony Lindgren
2012-10-26 16:41 ` Tony Lindgren
2012-10-26 16:41 ` Tony Lindgren
2012-10-29 8:06 ` Afzal Mohammed
2012-10-29 8:06 ` Afzal Mohammed
2012-10-29 8:06 ` Afzal Mohammed
2012-10-26 16:40 ` Tony Lindgren
2012-10-26 16:40 ` Tony Lindgren
2012-10-26 16:40 ` Tony Lindgren
2012-10-08 5:37 ` [PATCH v2 07/14] ARM: OMAP2+: onenand: header cleanup Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` [PATCH v2 08/14] ARM: OMAP2+: nand: " Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` [PATCH v2 09/14] mtd: nand: omap: bring in gpmc nand macros Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` [PATCH v2 10/14] ARM: OMAP2+: nand: bch capability check Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` [PATCH v2 11/14] ARM: OMAP2+: gpmc: nand register helper bch update Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` [PATCH v2 12/14] mtd: nand: omap: handle gpmc bch[48] Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:37 ` Afzal Mohammed
2012-10-08 5:38 ` [PATCH v2 13/14] ARM: OMAP2+: gpmc: remove exported nand functions Afzal Mohammed
2012-10-08 5:38 ` Afzal Mohammed
2012-10-08 5:38 ` Afzal Mohammed
2012-10-08 5:38 ` [PATCH v2 14/14] ARM: OMAP2+: gpmc: localize gpmc header Afzal Mohammed
2012-10-08 5:38 ` Afzal Mohammed
2012-10-08 5:38 ` Afzal Mohammed
2012-10-08 6:08 ` [PATCH v2 00/14] OMAP-GPMC related cleanup for common zImage Mohammed, Afzal
2012-10-08 6:08 ` Mohammed, Afzal
2012-10-08 6:08 ` Mohammed, Afzal
2012-10-10 16:38 ` Ivan Djelic [this message]
2012-10-10 16:38 ` Ivan Djelic
2012-10-10 16:38 ` Ivan Djelic
2012-10-11 5:24 ` Mohammed, Afzal
2012-10-11 5:24 ` Mohammed, Afzal
2012-10-11 5:24 ` Mohammed, Afzal
2012-10-16 18:06 ` Tony Lindgren
2012-10-16 18:06 ` Tony Lindgren
2012-10-16 18:06 ` Tony Lindgren
2012-10-17 5:29 ` Afzal Mohammed
2012-10-17 5:29 ` Afzal Mohammed
2012-10-17 5:29 ` Afzal Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121010163840.GA13585@parrot.com \
--to=ivan.djelic@parrot.com \
--cc=afzal@ti.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.