From: Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>
To: Andrew Oakley <andrew-WCNZvuCk18ErewFq2K+F1F6hYfS7NtTn@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [git pull] IOMMU Updates for v3.7-rc1
Date: Thu, 11 Oct 2012 11:32:39 +0200 [thread overview]
Message-ID: <20121011093239.GA2619@amd.com> (raw)
In-Reply-To: <20121010230231.2fb3c3b9-IjT0q3EH84DI7ueSY2wKCeWwSe/Luo9VmGrBRn/+eNheoWH0uzbU5w@public.gmane.org>
On Wed, Oct 10, 2012 at 11:02:31PM +0100, Andrew Oakley wrote:
> On Wed, 10 Oct 2012 20:11:31 +0100
> Andrew Oakley <andrew-WCNZvuCk18ErewFq2K+F1F6hYfS7NtTn@public.gmane.org> wrote:
> I'm not sure if the fix I've got is safe or if it's really a good idea
> to enable interrupt remapping with a broken BIOS.
Sadly it is not. Your patch works for your particular case but is not
generally applicable. There are indeed systems with 2 or more IOAPICs
and they all use different device-ids.
So, typically, there is one IOAPIC per SB, like in your case. But on
RD890 the chipset NB also includes an IOAPIC (which uses
device-id 00:00.1). This IOAPIC exists on your system too but is
disabled by the BIOS because the board does not use it.
So, in the end, device-id 00:00.1 might also be correct and the IVRS
entry could refer to the NB IOAPIC. We don't have any reliable
indication which IOAPIC is described in the IVRS table.
Cheer,
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joerg.roedel@amd.com>
To: Andrew Oakley <andrew@ado.is-a-geek.net>
Cc: <iommu@lists.linux-foundation.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] IOMMU Updates for v3.7-rc1
Date: Thu, 11 Oct 2012 11:32:39 +0200 [thread overview]
Message-ID: <20121011093239.GA2619@amd.com> (raw)
In-Reply-To: <20121010230231.2fb3c3b9@ado-amd-gentoo.moore.slainvet.net>
On Wed, Oct 10, 2012 at 11:02:31PM +0100, Andrew Oakley wrote:
> On Wed, 10 Oct 2012 20:11:31 +0100
> Andrew Oakley <andrew@ado.is-a-geek.net> wrote:
> I'm not sure if the fix I've got is safe or if it's really a good idea
> to enable interrupt remapping with a broken BIOS.
Sadly it is not. Your patch works for your particular case but is not
generally applicable. There are indeed systems with 2 or more IOAPICs
and they all use different device-ids.
So, typically, there is one IOAPIC per SB, like in your case. But on
RD890 the chipset NB also includes an IOAPIC (which uses
device-id 00:00.1). This IOAPIC exists on your system too but is
disabled by the BIOS because the board does not use it.
So, in the end, device-id 00:00.1 might also be correct and the IVRS
entry could refer to the NB IOAPIC. We don't have any reliable
indication which IOAPIC is described in the IVRS table.
Cheer,
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2012-10-11 9:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 15:23 [git pull] IOMMU Updates for v3.7-rc1 Joerg Roedel
2012-10-05 15:23 ` Joerg Roedel
2012-10-09 21:45 ` Andrew Oakley
[not found] ` <20121009224532.1e515664-IjT0q3EH84DI7ueSY2wKCeWwSe/Luo9VmGrBRn/+eNheoWH0uzbU5w@public.gmane.org>
2012-10-10 7:30 ` Joerg Roedel
2012-10-10 7:30 ` Joerg Roedel
2012-10-10 8:58 ` Andrew Oakley
[not found] ` <20121010095823.140fdd98-IjT0q3EH84DI7ueSY2wKCeWwSe/Luo9VmGrBRn/+eNheoWH0uzbU5w@public.gmane.org>
2012-10-10 13:32 ` Joerg Roedel
2012-10-10 13:32 ` Joerg Roedel
[not found] ` <20121010133249.GC16151-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2012-10-10 19:11 ` Andrew Oakley
2012-10-10 19:11 ` Andrew Oakley
[not found] ` <20121010201131.091d5a1f-IjT0q3EH84DI7ueSY2wKCeWwSe/Luo9VmGrBRn/+eNheoWH0uzbU5w@public.gmane.org>
2012-10-10 22:02 ` Andrew Oakley
2012-10-10 22:02 ` Andrew Oakley
[not found] ` <20121010230231.2fb3c3b9-IjT0q3EH84DI7ueSY2wKCeWwSe/Luo9VmGrBRn/+eNheoWH0uzbU5w@public.gmane.org>
2012-10-10 22:05 ` [PATCH] iommu/amd: Workaround wrong IOAPIC devid in IVRS andrew-WCNZvuCk18ErewFq2K+F1F6hYfS7NtTn
2012-10-10 22:05 ` andrew
2012-10-11 9:32 ` Joerg Roedel [this message]
2012-10-11 9:32 ` [git pull] IOMMU Updates for v3.7-rc1 Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121011093239.GA2619@amd.com \
--to=joerg.roedel-5c7gfcevmho@public.gmane.org \
--cc=andrew-WCNZvuCk18ErewFq2K+F1F6hYfS7NtTn@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.