All of lore.kernel.org
 help / color / mirror / Atom feed
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit
Date: Thu, 11 Oct 2012 20:13:13 +0200	[thread overview]
Message-ID: <20121011181312.GB3850@tarshish> (raw)
In-Reply-To: <1349969282-12676-2-git-send-email-thomas.petazzoni@free-electrons.com>

Hi Thomas,

On Thu, Oct 11, 2012 at 05:27:59PM +0200, Thomas Petazzoni wrote:
> +module_param(mvneta_rxq_number, int, S_IRUGO);
> +module_param(mvneta_txq_number, int, S_IRUGO);
> +
> +module_param(mvneta_rxq_def, int, S_IRUGO);
> +module_param(mvneta_txq_def, int, S_IRUGO);

Since these are module params they need the driver name prefix when referenced 
in the kernel command line, so there should be no need for another "mvneta" 
prefix.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
	Jason Cooper <jason@lakedaemon.net>,
	Rami Rosen <rosenr@marvell.com>,
	netdev@vger.kernel.org, Lennert Buytenhek <kernel@wantstofly.org>,
	Maen Suleiman <maen@marvell.com>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit
Date: Thu, 11 Oct 2012 20:13:13 +0200	[thread overview]
Message-ID: <20121011181312.GB3850@tarshish> (raw)
In-Reply-To: <1349969282-12676-2-git-send-email-thomas.petazzoni@free-electrons.com>

Hi Thomas,

On Thu, Oct 11, 2012 at 05:27:59PM +0200, Thomas Petazzoni wrote:
> +module_param(mvneta_rxq_number, int, S_IRUGO);
> +module_param(mvneta_txq_number, int, S_IRUGO);
> +
> +module_param(mvneta_rxq_def, int, S_IRUGO);
> +module_param(mvneta_txq_def, int, S_IRUGO);

Since these are module params they need the driver name prefix when referenced 
in the kernel command line, so there should be no need for another "mvneta" 
prefix.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  parent reply	other threads:[~2012-10-11 18:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-11 15:27 [PATCH v2] Network driver for the Armada 370 and Armada XP ARM Marvell SoCs Thomas Petazzoni
2012-10-11 15:27 ` Thomas Petazzoni
2012-10-11 15:27 ` [PATCH v2 1/4] net: mvneta: driver for Marvell Armada 370/XP network unit Thomas Petazzoni
2012-10-11 15:27   ` Thomas Petazzoni
2012-10-11 15:46   ` Rob Herring
2012-10-11 15:46     ` Rob Herring
2012-10-11 16:38     ` Thomas Petazzoni
2012-10-11 16:38       ` Thomas Petazzoni
2012-10-12 14:16     ` Thomas Petazzoni
2012-10-12 14:16       ` Thomas Petazzoni
2012-10-11 18:13   ` Baruch Siach [this message]
2012-10-11 18:13     ` Baruch Siach
2012-10-11 21:26   ` Francois Romieu
2012-10-11 21:26     ` Francois Romieu
2012-10-12 14:31     ` Jason Cooper
2012-10-12 14:31       ` Jason Cooper
2012-10-12 14:59       ` Thomas Petazzoni
2012-10-12 14:59         ` Thomas Petazzoni
2012-10-12 16:03         ` Jason Cooper
2012-10-12 16:03           ` Jason Cooper
2012-10-11 15:28 ` [PATCH v2 2/4] net: mvneta: update MAINTAINERS file for the mvneta maintainers Thomas Petazzoni
2012-10-11 15:28   ` Thomas Petazzoni
2012-10-11 15:28 ` [PATCH v2 3/4] arm: mvebu: add Ethernet controllers using mvneta driver for Armada 370/XP Thomas Petazzoni
2012-10-11 15:28   ` Thomas Petazzoni
2012-10-11 15:28 ` [PATCH v2 4/4] arm: mvebu: enable Ethernet controllers on Armada 370/XP eval boards Thomas Petazzoni
2012-10-11 15:28   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121011181312.GB3850@tarshish \
    --to=baruch@tkos.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.