Re: [PATCH] serial: clps711x: reworked driver version

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Oct 11, 2012 at 10:57:03PM +0400, Alexander Shiyan wrote:
> On Fri, 12 Oct 2012 03:34:06 +0900
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> > On Thu, Oct 11, 2012 at 07:51:29PM +0400, Alexander Shiyan wrote:
> > > This patch presents reworked version of CLPS711X serial driver.
> > > The changes from the old version:
> > > - Driver converted to platform_device.
> > > - Using CPU clock subsystem for getting base UART speed, since CPU can run
> > >   on different speeds.
> > > - Remove console_initcall and make console dynamically. Earler messages in
> > >   this case can be retrieved by using "earlyprintk" kernel option.
> > > - Using resource-managed functions (devm_xx).
> > > - Make all variables dynamically (reduce BSS).
> > > - Cleanup code & comments.
> > 
> > That's a lot of different things, all at once, making it very hard to
> > review.
> > Can you please break this up into the individual patches of what you are
> > doing above, one patch per thing, as is needed for Linux kernel patches?
> > That way it is much easier to accept and review.
> 
> It's too hard to do, since each modification depends on the other...

That's why you do one patch after the other, a series of patches, all
depending on the previous ones.

> Maybe make a patch through renaming, for example clps711x_uart? Or you
> still insist to split it into separate patches?

Linux kernel development is all about individual patches, each one only
doing one thing.  We've been doing this for 20+ years now, it's not
anything "new" :)

thanks,

greg k-h