From: "John W. Linville" <linville@tuxdriver.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Pontus Fuchs <pontus.fuchs@gmail.com>,
linux-wireless@vger.kernel.org, hch@lst.de, s.L-H@gmx.de,
mcgrof@qca.qualcomm.com
Subject: Re: [PATCH 0/4] Driver for the ar5523 chipset
Date: Fri, 12 Oct 2012 10:33:56 -0400 [thread overview]
Message-ID: <20121012143355.GA25235@tuxdriver.com> (raw)
In-Reply-To: <87haq017wi.fsf@purkki.adurom.net>
On Fri, Oct 12, 2012 at 10:11:57AM +0300, Kalle Valo wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
>
> > Very nice.
>
> Indeed.
>
> > But what is keeping this driver from going to the "proper" place in the
> > kernel tree (i.e. drivers/net/...)? I don't have a problem adding it to
> > the staging tree, but it would need a TODO file to list what is needed
> > to get it out of the staging tree.
>
> I did a really quick 5 min review of this driver and IMHO this should go
> directly to drivers/net/wireless/ (or maybe to drivers/net/wireless/ath,
> Luis?), I don't see any reason why this should go to staging. The code
> looks clean and is only 2 kLOC. But I'll review this better during the
> weekend and also run some build tests.
I have no particular objection to that. FWIW, Pontus contacted me
and said something like "I've got this driver that sucks and needs
a lot of work, should it go to staging?" Perhaps he was being too
hard on himself? :-)
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2012-10-12 14:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 20:01 [PATCH 0/4] Driver for the ar5523 chipset Pontus Fuchs
2012-10-11 20:01 ` [PATCH 1/4] ar5523: Add main driver file Pontus Fuchs
2012-10-15 20:54 ` Luis R. Rodriguez
2012-10-11 20:01 ` [PATCH 2/4] ar5523: Add driver header file Pontus Fuchs
2012-10-13 5:41 ` Kalle Valo
2012-10-13 10:14 ` Pontus Fuchs
2012-10-13 15:45 ` Christoph Hellwig
2012-10-21 19:58 ` Kalle Valo
2012-10-11 20:01 ` [PATCH 3/4] ar5523: Add Firmware API " Pontus Fuchs
2012-10-11 20:01 ` [PATCH 4/4] ar5523: Add Kconfig and Makefile Pontus Fuchs
2012-10-11 20:31 ` [PATCH 0/4] Driver for the ar5523 chipset Greg KH
2012-10-12 6:52 ` Pontus Fuchs
2012-10-12 7:28 ` Mohammed Shafi
2012-10-12 8:36 ` Pontus Fuchs
2012-10-12 8:23 ` Julian Calaby
2012-10-12 8:33 ` Pontus Fuchs
2012-10-12 11:45 ` Chadd, Adrian
2012-10-30 17:08 ` Adrian Chadd
2012-11-01 17:41 ` Pontus Fuchs
2012-10-12 7:11 ` Kalle Valo
2012-10-12 14:33 ` John W. Linville [this message]
2012-10-13 5:38 ` Kalle Valo
2012-10-13 10:25 ` Pontus Fuchs
2012-10-21 16:35 ` Kalle Valo
2012-10-13 15:41 ` Christoph Hellwig
2012-10-13 15:39 ` Christoph Hellwig
2012-10-22 22:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012143355.GA25235@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@qca.qualcomm.com \
--cc=pontus.fuchs@gmail.com \
--cc=s.L-H@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.