From: Christoph Hellwig <hch@lst.de>
To: Kalle Valo <kvalo@adurom.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Greg KH <gregkh@linuxfoundation.org>,
Pontus Fuchs <pontus.fuchs@gmail.com>,
linux-wireless@vger.kernel.org, hch@lst.de, s.L-H@gmx.de,
mcgrof@qca.qualcomm.com
Subject: Re: [PATCH 0/4] Driver for the ar5523 chipset
Date: Sat, 13 Oct 2012 17:41:35 +0200 [thread overview]
Message-ID: <20121013154135.GB25810@lst.de> (raw)
In-Reply-To: <87a9vr0w4d.fsf@purkki.adurom.net>
On Sat, Oct 13, 2012 at 08:38:42AM +0300, Kalle Valo wrote:
> * defines inside structures is not common, kernel style is to have the
> defines on top of the structure definition
I don't think that's true. At least for code I touch a lot having the
constants close to the field they are for is very common. That might be
because it actually makes a lot sense and eases writing. So a big NAK
from me for changing that part.
next prev parent reply other threads:[~2012-10-13 15:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 20:01 [PATCH 0/4] Driver for the ar5523 chipset Pontus Fuchs
2012-10-11 20:01 ` [PATCH 1/4] ar5523: Add main driver file Pontus Fuchs
2012-10-15 20:54 ` Luis R. Rodriguez
2012-10-11 20:01 ` [PATCH 2/4] ar5523: Add driver header file Pontus Fuchs
2012-10-13 5:41 ` Kalle Valo
2012-10-13 10:14 ` Pontus Fuchs
2012-10-13 15:45 ` Christoph Hellwig
2012-10-21 19:58 ` Kalle Valo
2012-10-11 20:01 ` [PATCH 3/4] ar5523: Add Firmware API " Pontus Fuchs
2012-10-11 20:01 ` [PATCH 4/4] ar5523: Add Kconfig and Makefile Pontus Fuchs
2012-10-11 20:31 ` [PATCH 0/4] Driver for the ar5523 chipset Greg KH
2012-10-12 6:52 ` Pontus Fuchs
2012-10-12 7:28 ` Mohammed Shafi
2012-10-12 8:36 ` Pontus Fuchs
2012-10-12 8:23 ` Julian Calaby
2012-10-12 8:33 ` Pontus Fuchs
2012-10-12 11:45 ` Chadd, Adrian
2012-10-30 17:08 ` Adrian Chadd
2012-11-01 17:41 ` Pontus Fuchs
2012-10-12 7:11 ` Kalle Valo
2012-10-12 14:33 ` John W. Linville
2012-10-13 5:38 ` Kalle Valo
2012-10-13 10:25 ` Pontus Fuchs
2012-10-21 16:35 ` Kalle Valo
2012-10-13 15:41 ` Christoph Hellwig [this message]
2012-10-13 15:39 ` Christoph Hellwig
2012-10-22 22:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121013154135.GB25810@lst.de \
--to=hch@lst.de \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@qca.qualcomm.com \
--cc=pontus.fuchs@gmail.com \
--cc=s.L-H@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.