From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: nscott@redhat.com, Dave Chinner <dchinner@redhat.com>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_quota: XFS_XFLAG_PROJINHERIT is only for dirs
Date: Sat, 13 Oct 2012 11:52:05 -0400 [thread overview]
Message-ID: <20121013155205.GA11037@infradead.org> (raw)
In-Reply-To: <5078432B.6050501@redhat.com>
On Fri, Oct 12, 2012 at 11:19:55AM -0500, Eric Sandeen wrote:
> xfs_quota has long set XFS_XFLAG_PROJINHERIT on all files,
> and tested for presence on all files. However, Dave's semi-recent
> xfs_repair update is now flagging this as an error:
I think we should rever that part of the repair patch. While there
really is not point to have XFS_XFLAG_PROJINHERIT set on non-directory
files we have been setting it for year, so repair should cope with that.
I'd also like to have a test checking that repair does not complain
about XFS_XFLAG_PROJINHERIT being set on a non-directory to verify this.
For the future I'm fine with not setting it on non-directories anymore,
so:
Reviewed-by: Christoph Hellwig <hch@lst.de>
for this patch after a slight update to the commit message.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-13 15:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 16:19 [PATCH] xfs_quota: XFS_XFLAG_PROJINHERIT is only for dirs Eric Sandeen
2012-10-13 15:52 ` Christoph Hellwig [this message]
2012-10-13 21:22 ` Eric Sandeen
2012-10-13 23:34 ` Dave Chinner
2012-10-14 0:05 ` Eric Sandeen
2012-10-14 0:14 ` Dave Chinner
2012-10-16 20:17 ` Ben Myers
2012-10-16 20:34 ` Dave Chinner
2012-10-17 15:54 ` Eric Sandeen
2012-10-23 12:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121013155205.GA11037@infradead.org \
--to=hch@infradead.org \
--cc=dchinner@redhat.com \
--cc=nscott@redhat.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.