From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] xen/xenbus: silence GCC warning
Date: Mon, 15 Oct 2012 09:20:52 -0400 [thread overview]
Message-ID: <20121015132052.GD4000@phenom.dumpdata.com> (raw)
In-Reply-To: <1350295389.1516.27.camel@x61.thuisdomein>
On Mon, Oct 15, 2012 at 12:03:09PM +0200, Paul Bolle wrote:
> Compiling xenbus_xs.o triggers this GCC warning:
> drivers/xen/xenbus/xenbus_xs.c:628:13: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
>
> Add the obvious and trivial fix.
I already got the fix for this in my tree. Thanks!
>
> While we're touching this function add some equally obvious and trivial
> whitespace fixes.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Triggered by compiling v3.7-rc1 using (basically) Fedora 17's current
> config. Compile tested only.
>
> 1) Obligatory reference: https://lwn.net/Articles/487493/ .
>
> drivers/xen/xenbus/xenbus_xs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c
> index 48220e1..7a2b0da 100644
> --- a/drivers/xen/xenbus/xenbus_xs.c
> +++ b/drivers/xen/xenbus/xenbus_xs.c
> @@ -619,13 +619,14 @@ static struct xenbus_watch *find_watch(const char *token)
>
> return NULL;
> }
> +
> /*
> * Certain older XenBus toolstack cannot handle reading values that are
> * not populated. Some Xen 3.4 installation are incapable of doing this
> * so if we are running on anything older than 4 do not attempt to read
> * control/platform-feature-xs_reset_watches.
> */
> -static bool xen_strict_xenbus_quirk()
> +static bool xen_strict_xenbus_quirk(void)
> {
> uint32_t eax, ebx, ecx, edx, base;
>
> @@ -635,8 +636,8 @@ static bool xen_strict_xenbus_quirk()
> if ((eax >> 16) < 4)
> return true;
> return false;
> -
> }
> +
> static void xs_reset_watches(void)
> {
> int err, supported = 0;
> --
> 1.7.11.7
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
"H. Peter Anvin" <hpa@zytor.com>,
xen-devel@lists.xensource.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/xenbus: silence GCC warning
Date: Mon, 15 Oct 2012 09:20:52 -0400 [thread overview]
Message-ID: <20121015132052.GD4000@phenom.dumpdata.com> (raw)
In-Reply-To: <1350295389.1516.27.camel@x61.thuisdomein>
On Mon, Oct 15, 2012 at 12:03:09PM +0200, Paul Bolle wrote:
> Compiling xenbus_xs.o triggers this GCC warning:
> drivers/xen/xenbus/xenbus_xs.c:628:13: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
>
> Add the obvious and trivial fix.
I already got the fix for this in my tree. Thanks!
>
> While we're touching this function add some equally obvious and trivial
> whitespace fixes.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Triggered by compiling v3.7-rc1 using (basically) Fedora 17's current
> config. Compile tested only.
>
> 1) Obligatory reference: https://lwn.net/Articles/487493/ .
>
> drivers/xen/xenbus/xenbus_xs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/xenbus/xenbus_xs.c b/drivers/xen/xenbus/xenbus_xs.c
> index 48220e1..7a2b0da 100644
> --- a/drivers/xen/xenbus/xenbus_xs.c
> +++ b/drivers/xen/xenbus/xenbus_xs.c
> @@ -619,13 +619,14 @@ static struct xenbus_watch *find_watch(const char *token)
>
> return NULL;
> }
> +
> /*
> * Certain older XenBus toolstack cannot handle reading values that are
> * not populated. Some Xen 3.4 installation are incapable of doing this
> * so if we are running on anything older than 4 do not attempt to read
> * control/platform-feature-xs_reset_watches.
> */
> -static bool xen_strict_xenbus_quirk()
> +static bool xen_strict_xenbus_quirk(void)
> {
> uint32_t eax, ebx, ecx, edx, base;
>
> @@ -635,8 +636,8 @@ static bool xen_strict_xenbus_quirk()
> if ((eax >> 16) < 4)
> return true;
> return false;
> -
> }
> +
> static void xs_reset_watches(void)
> {
> int err, supported = 0;
> --
> 1.7.11.7
next prev parent reply other threads:[~2012-10-15 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 10:03 [PATCH] xen/xenbus: silence GCC warning Paul Bolle
2012-10-15 13:20 ` Konrad Rzeszutek Wilk [this message]
2012-10-15 13:20 ` Konrad Rzeszutek Wilk
-- strict thread matches above, loose matches on Subject: below --
2012-10-15 10:03 Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121015132052.GD4000@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.