Re: [PATCH 3/4] drm/i915: ILK also needs that last fix

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, Oct 15, 2012 at 08:21:41PM -0700, Ben Widawsky wrote:
> On Mon, 15 Oct 2012 20:59:22 +0200
> Daniel Vetter <daniel@ffwll.ch> wrote:
> 
> > On Wed, Oct 03, 2012 at 07:34:23PM -0700, Ben Widawsky wrote:
> > > That fix was the disable render deptch cache pipeline flush
> > > 
> > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> > 
> > I've stumbled over the same one, but my docs here suggest i965g/gm45
> > need it, too:
> > 
> > http://cgit.freedesktop.org/~danvet/drm/commit/?h=ilk-wa-pile&id=37c4c82b8cdbcf5adccad97f0b45747ba37ed659
> > 
> > Have you checked whether we don't need this on ivb/vlv/hsw, too?
> 
> I did check whether the windows driver does it for those platforms, and
> the answer is no. So the answer to your question is maybe because who
> knows what exists in some other doc somewhere in the metaverse. I think
> this is a good enough start though since it seems SNB was definitely a
> bit buggier than IVB.

Yeah, I've noticed while checking w/as that they're not consistently named
on older platforms. E.g. the above definitely exists on eaglelake, too,
but named slightly different. So the w/a db doesn't pick up all uses.
Hoooray!

> > Also, for w/a patches based on the vpg w/a database, please include
> > the vpg w/a name tag both in the commit message and in a code comment
> > somewhere.
> 
> Good idea. If you're okay with longer commit message subjects, I'd even
> suggest putting it there to make it even a bit easier to search for.

Yeah, I'm fine with putting it into the commit head, I've put it there
myself. If the w/a only affects one platform we could try to squeeze the
platform name into the headline, too. But having to read the commit
message for that doesn't really hurt, either.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch