From: Daniel Vetter <daniel@ffwll.ch>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Ben Widawsky <ben@bwidawsk.net>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [drm-intel:drm-intel-next-queued 42/44] drivers/gpu/drm/i915/intel_pm.c:2506:2: error: 'ret' und
Date: Tue, 16 Oct 2012 07:24:32 +0000 [thread overview]
Message-ID: <20121016072432.GE5753@phenom.ffwll.local> (raw)
In-Reply-To: <20121016005951.GA6855@localhost>
On Tue, Oct 16, 2012 at 08:59:51AM +0800, Fengguang Wu wrote:
> Hi Ben,
>
> FYI, kernel build failed on
>
> tree: git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-next-queued
> head: 861b675336a1f686f480d92990251e99a3ec0956
> commit: 686279dbcbc69f71ce86efdccaa8cad762cba2ea [42/44] drm/i915: Extract PCU communication
> config: x86_64-allyesconfig # make ARCH=x86_64 allyesconfig
>
> All error/warnings:
>
> drivers/gpu/drm/i915/intel_pm.c: In function 'gen6_enable_rps':
> drivers/gpu/drm/i915/intel_pm.c:2506:2: error: 'ret' undeclared (first use in this function)
> drivers/gpu/drm/i915/intel_pm.c:2506:2: note: each undeclared identifier is reported only once for each function it appears in
>
> vim +2506 drivers/gpu/drm/i915/intel_pm.c
>
> 89ba829e Jesse Barnes 2012-05-22 2500 GEN6_RP_MEDIA_HW_NORMAL_MODE |
> 2b4e57bd Eugeni Dodonov 2012-04-18 2501 GEN6_RP_MEDIA_IS_GFX |
> 2b4e57bd Eugeni Dodonov 2012-04-18 2502 GEN6_RP_ENABLE |
> 2b4e57bd Eugeni Dodonov 2012-04-18 2503 GEN6_RP_UP_BUSY_AVG |
> 5a7dc92a Eugeni Dodonov 2012-07-02 2504 (IS_HASWELL(dev) ? GEN7_RP_DOWN_IDLE_AVG : GEN6_RP_DOWN_IDLE_CONT));
> 2b4e57bd Eugeni Dodonov 2012-04-18 2505
> 686279db Ben Widawsky 2012-09-26 @2506 ret = sandybridge_pcode_write(dev_priv, GEN6_PCODE_WRITE_MIN_FREQ_TABLE, 0);
> 686279db Ben Widawsky 2012-09-26 2507 if (!ret) {
> 686279db Ben Widawsky 2012-09-26 2508 pcu_mbox = 0;
> 686279db Ben Widawsky 2012-09-26 2509 ret = sandybridge_pcode_read(dev_priv, GEN6_READ_OC_PARAMS, &pcu_mbox);
Fixed up, thanks a lot for the report.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Ben Widawsky <ben@bwidawsk.net>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [drm-intel:drm-intel-next-queued 42/44] drivers/gpu/drm/i915/intel_pm.c:2506:2: error: 'ret' undeclared
Date: Tue, 16 Oct 2012 09:24:32 +0200 [thread overview]
Message-ID: <20121016072432.GE5753@phenom.ffwll.local> (raw)
In-Reply-To: <20121016005951.GA6855@localhost>
On Tue, Oct 16, 2012 at 08:59:51AM +0800, Fengguang Wu wrote:
> Hi Ben,
>
> FYI, kernel build failed on
>
> tree: git://people.freedesktop.org/~danvet/drm-intel.git drm-intel-next-queued
> head: 861b675336a1f686f480d92990251e99a3ec0956
> commit: 686279dbcbc69f71ce86efdccaa8cad762cba2ea [42/44] drm/i915: Extract PCU communication
> config: x86_64-allyesconfig # make ARCH=x86_64 allyesconfig
>
> All error/warnings:
>
> drivers/gpu/drm/i915/intel_pm.c: In function 'gen6_enable_rps':
> drivers/gpu/drm/i915/intel_pm.c:2506:2: error: 'ret' undeclared (first use in this function)
> drivers/gpu/drm/i915/intel_pm.c:2506:2: note: each undeclared identifier is reported only once for each function it appears in
>
> vim +2506 drivers/gpu/drm/i915/intel_pm.c
>
> 89ba829e Jesse Barnes 2012-05-22 2500 GEN6_RP_MEDIA_HW_NORMAL_MODE |
> 2b4e57bd Eugeni Dodonov 2012-04-18 2501 GEN6_RP_MEDIA_IS_GFX |
> 2b4e57bd Eugeni Dodonov 2012-04-18 2502 GEN6_RP_ENABLE |
> 2b4e57bd Eugeni Dodonov 2012-04-18 2503 GEN6_RP_UP_BUSY_AVG |
> 5a7dc92a Eugeni Dodonov 2012-07-02 2504 (IS_HASWELL(dev) ? GEN7_RP_DOWN_IDLE_AVG : GEN6_RP_DOWN_IDLE_CONT));
> 2b4e57bd Eugeni Dodonov 2012-04-18 2505
> 686279db Ben Widawsky 2012-09-26 @2506 ret = sandybridge_pcode_write(dev_priv, GEN6_PCODE_WRITE_MIN_FREQ_TABLE, 0);
> 686279db Ben Widawsky 2012-09-26 2507 if (!ret) {
> 686279db Ben Widawsky 2012-09-26 2508 pcu_mbox = 0;
> 686279db Ben Widawsky 2012-09-26 2509 ret = sandybridge_pcode_read(dev_priv, GEN6_READ_OC_PARAMS, &pcu_mbox);
Fixed up, thanks a lot for the report.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-10-16 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 0:59 [drm-intel:drm-intel-next-queued 42/44] drivers/gpu/drm/i915/intel_pm.c:2506:2: error: 'ret' undecla Fengguang Wu
2012-10-16 0:59 ` [drm-intel:drm-intel-next-queued 42/44] drivers/gpu/drm/i915/intel_pm.c:2506:2: error: 'ret' undeclared Fengguang Wu
2012-10-16 7:24 ` Daniel Vetter [this message]
2012-10-16 7:24 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016072432.GE5753@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.