All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Cc: Fabien Proriol <Fabien.Proriol@jdsu.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [oe] [PATCH] SDK: allow SDK path of various level
Date: Tue, 16 Oct 2012 10:21:34 -0400	[thread overview]
Message-ID: <20121016142134.GC5662@denix.org> (raw)
In-Reply-To: <1350394502-7745-1-git-send-email-fabien.proriol@jdsu.com>

On Tue, Oct 16, 2012 at 01:37:17PM +0000, Fabien Proriol wrote:
> In the previous version, tar extraction use the --strip-component
> option with "4" hard coded value.
> If we set another SDKPATH, with a different depth, the sdk installation
> fails.
> 
> This patch computes the level from the SDKPATH value.

Thanks! That's part of the problem I was having lately. Although, I think this 
patch should go to OE-Core list instead...

Do you also see the problem building gcc-cross-initial/intermediate 
complaining about missing headers from sysroot (it loses -nativesdk suffix 
for some reason, when looking for the system headers), when building with the 
new SDKPATH/SDK_NAME? I believe there's some path hardcoded somewhere in the 
gcc/cross recipes, but I wasn't able to debug it yet...

-- 
Denys


> Signed-off-by: Fabien Proriol <fabien.proriol@jdsu.com>
> ---
>  meta/classes/populate_sdk_base.bbclass |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
> index 6eb6726..971adfc 100644
> --- a/meta/classes/populate_sdk_base.bbclass
> +++ b/meta/classes/populate_sdk_base.bbclass
> @@ -117,6 +117,7 @@ fakeroot create_shar() {
>  #!/bin/bash
>  
>  DEFAULT_INSTALL_DIR="${SDKPATH}"
> +COMPONENTS_LEN=$(echo ".${SDKPATH}" | sed "s/\// /g" | wc -w)
>  
>  printf "Enter target directory for SDK (default: $DEFAULT_INSTALL_DIR): "
>  read target_sdk_dir
> @@ -153,7 +154,7 @@ fi
>  payload_offset=$(($(grep -na -m1 "^MARKER:$" $0|cut -d':' -f1) + 1))
>  
>  printf "Extracting SDK..."
> -tail -n +$payload_offset $0| tar xj --strip-components=4 -C $target_sdk_dir
> +tail -n +$payload_offset $0| tar xj --strip-components=$COMPONENTS_LEN -C $target_sdk_dir
>  echo "done"
>  
>  printf "Setting it up..."
> -- 
> 1.7.8.6
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel



WARNING: multiple messages have this Message-ID (diff)
From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Cc: Fabien Proriol <Fabien.Proriol@jdsu.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] SDK: allow SDK path of various level
Date: Tue, 16 Oct 2012 10:21:34 -0400	[thread overview]
Message-ID: <20121016142134.GC5662@denix.org> (raw)
In-Reply-To: <1350394502-7745-1-git-send-email-fabien.proriol@jdsu.com>

On Tue, Oct 16, 2012 at 01:37:17PM +0000, Fabien Proriol wrote:
> In the previous version, tar extraction use the --strip-component
> option with "4" hard coded value.
> If we set another SDKPATH, with a different depth, the sdk installation
> fails.
> 
> This patch computes the level from the SDKPATH value.

Thanks! That's part of the problem I was having lately. Although, I think this 
patch should go to OE-Core list instead...

Do you also see the problem building gcc-cross-initial/intermediate 
complaining about missing headers from sysroot (it loses -nativesdk suffix 
for some reason, when looking for the system headers), when building with the 
new SDKPATH/SDK_NAME? I believe there's some path hardcoded somewhere in the 
gcc/cross recipes, but I wasn't able to debug it yet...

-- 
Denys


> Signed-off-by: Fabien Proriol <fabien.proriol@jdsu.com>
> ---
>  meta/classes/populate_sdk_base.bbclass |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
> index 6eb6726..971adfc 100644
> --- a/meta/classes/populate_sdk_base.bbclass
> +++ b/meta/classes/populate_sdk_base.bbclass
> @@ -117,6 +117,7 @@ fakeroot create_shar() {
>  #!/bin/bash
>  
>  DEFAULT_INSTALL_DIR="${SDKPATH}"
> +COMPONENTS_LEN=$(echo ".${SDKPATH}" | sed "s/\// /g" | wc -w)
>  
>  printf "Enter target directory for SDK (default: $DEFAULT_INSTALL_DIR): "
>  read target_sdk_dir
> @@ -153,7 +154,7 @@ fi
>  payload_offset=$(($(grep -na -m1 "^MARKER:$" $0|cut -d':' -f1) + 1))
>  
>  printf "Extracting SDK..."
> -tail -n +$payload_offset $0| tar xj --strip-components=4 -C $target_sdk_dir
> +tail -n +$payload_offset $0| tar xj --strip-components=$COMPONENTS_LEN -C $target_sdk_dir
>  echo "done"
>  
>  printf "Setting it up..."
> -- 
> 1.7.8.6
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel



  reply	other threads:[~2012-10-16 15:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16 13:37 [PATCH] SDK: allow SDK path of various level Fabien Proriol
2012-10-16 14:21 ` Denys Dmytriyenko [this message]
2012-10-16 14:21   ` Denys Dmytriyenko
2012-10-16 14:42   ` [oe] " Fabien Proriol
2012-10-16 14:42     ` Fabien Proriol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121016142134.GC5662@denix.org \
    --to=denis@denix.org \
    --cc=Fabien.Proriol@jdsu.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.