From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Irina Tirdea <irina.tirdea@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Pekka Enberg <penberg@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Irina Tirdea <irina.tirdea@intel.com>
Subject: Re: [PATCH v4 3/6] perf tools: add --addr2line command line option
Date: Tue, 16 Oct 2012 08:21:53 -0700 [thread overview]
Message-ID: <20121016152153.GD6807@ghostprotocols.net> (raw)
In-Reply-To: <1350344020-8071-4-git-send-email-irina.tirdea@gmail.com>
Em Tue, Oct 16, 2012 at 02:33:37AM +0300, Irina Tirdea escreveu:
> From: Irina Tirdea <irina.tirdea@intel.com>
>
> When analyzing data recorded on a target with a different architecture
> than the host, we must use addr2line from the toolchain for that
> architecture.
>
> Add a command line option to allow setting addr2line at runtime.
You're doing two things here:
1. Adding --addr2line
2. fixing a bug for unresolved symbols
Please try not to do that, instead provide two patches, one addressing
each issue.
Furthermore, Namhyung fixed #2 already:
commit a2c1311c4cbd47a087e95be18fee79ead3d0744b
Author: Namhyung Kim <namhyung.kim@lge.com>
Date: Mon Oct 15 12:39:42 2012 +0900
perf tools: Fix segfault when using srcline sort key
- Arnaldo
next prev parent reply other threads:[~2012-10-16 15:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 23:33 [PATCH v4 0/6] perf tools: fixes for Android Irina Tirdea
2012-10-15 23:33 ` [PATCH v4 1/6] perf tools: configure tmp path at build time Irina Tirdea
2012-10-16 15:18 ` Arnaldo Carvalho de Melo
2012-10-16 16:48 ` Christoph Hellwig
2012-10-21 16:24 ` Ingo Molnar
2012-10-22 7:38 ` Irina Tirdea
2012-10-15 23:33 ` [PATCH v4 2/6] perf tools: configure shell path at compile time Irina Tirdea
2012-10-16 15:19 ` Arnaldo Carvalho de Melo
2012-10-15 23:33 ` [PATCH v4 3/6] perf tools: add --addr2line command line option Irina Tirdea
2012-10-16 15:21 ` Arnaldo Carvalho de Melo [this message]
2012-10-22 9:06 ` Irina Tirdea
2012-10-15 23:33 ` [PATCH v4 4/6] perf tools: Try to find cross-built objdump path Irina Tirdea
2012-10-16 15:26 ` Arnaldo Carvalho de Melo
2012-10-17 4:22 ` Namhyung Kim
2012-10-25 7:59 ` [tip:perf/core] " tip-bot for Irina Tirdea
2012-10-15 23:33 ` [PATCH v4 5/6] perf tools: Try to find cross-built addr2line path Irina Tirdea
2012-10-16 15:26 ` Arnaldo Carvalho de Melo
2012-10-15 23:33 ` [PATCH v4 6/6] perf stat: implement --big-num grouping Irina Tirdea
2012-10-16 16:49 ` Christoph Hellwig
2012-10-21 16:28 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016152153.GD6807@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=irina.tirdea@gmail.com \
--cc=irina.tirdea@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.