Re: [PATCH v4 6/6] perf stat: implement --big-num grouping

[Ingo Molnar <mingo@kernel.org>]

* Christoph Hellwig <hch@infradead.org> wrote:

> On Tue, Oct 16, 2012 at 02:33:40AM +0300, Irina Tirdea wrote:
> > From: Irina Tirdea <irina.tirdea@intel.com>
> > 
> > In glibc, printf supports ' to group numbers with thousands' 
> > grouping characters. Bionic does not support ' for printf.
> > 
> > Implement thousands's grouping for numbers according to 
> > locale. The implementation uses the algorithm from glibc 
> > (http://www.gnu.org/software/libc/).
> > 
> > Bionic does not implement locales, so we need to add a 
> > configuration option LOCALE_SUPPORT. If it is not defined, 
> > default values for thousands separator and grouping are 
> > used.
> 
> Duplicating this in perf sounds like a hack. [...]

There's countless utility and compatibility 'hacks' in the Linux 
kernel too, which makes it a practical solution.

> [...] Does gnulib provide this feature?  It's the canonical 
> source for getting standards or helper functions on systems 
> that don't support them.

Unless Android comes with "gnulib" installed by default that's 
obviously not a solution.

What's your point?

Thanks,

	Ingo