* [PATCH] ARM: OMAP: resolve sparse warning concerning debug_card_init()
@ 2012-10-09 20:29 ` Paul Walmsley
0 siblings, 0 replies; 6+ messages in thread
From: Paul Walmsley @ 2012-10-09 20:29 UTC (permalink / raw)
To: linux-omap, linux-arm-kernel; +Cc: tony, grinberg
Commit 801475ccb2b2c1928b22aec4b9e5285d9e347602 ("ARM: OMAP: move
debug_card_init() function") results in the following new sparse
warning:
arch/arm/plat-omap/debug-devices.c:71:12: warning: symbol 'debug_card_init' was not declared. Should it be static?
Fix by implementing Tony's suggestion to add a "sideways include" to the
new location of the debug-devices.h file in arch/arm/mach-omap2/.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Igor Grinberg <grinberg@compulab.co.il>
Cc: Tony Lindgren <tony@atomide.com>
---
arch/arm/plat-omap/debug-devices.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/plat-omap/debug-devices.c b/arch/arm/plat-omap/debug-devices.c
index c7a4c09..5a4678e 100644
--- a/arch/arm/plat-omap/debug-devices.c
+++ b/arch/arm/plat-omap/debug-devices.c
@@ -16,6 +16,7 @@
#include <linux/smc91x.h>
#include <mach/hardware.h>
+#include "../mach-omap2/debug-devices.h"
/* Many OMAP development platforms reuse the same "debug board"; these
* platforms include H2, H3, H4, and Perseus2.
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: OMAP: resolve sparse warning concerning debug_card_init()
@ 2012-10-09 20:29 ` Paul Walmsley
0 siblings, 0 replies; 6+ messages in thread
From: Paul Walmsley @ 2012-10-09 20:29 UTC (permalink / raw)
To: linux-arm-kernel
Commit 801475ccb2b2c1928b22aec4b9e5285d9e347602 ("ARM: OMAP: move
debug_card_init() function") results in the following new sparse
warning:
arch/arm/plat-omap/debug-devices.c:71:12: warning: symbol 'debug_card_init' was not declared. Should it be static?
Fix by implementing Tony's suggestion to add a "sideways include" to the
new location of the debug-devices.h file in arch/arm/mach-omap2/.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Igor Grinberg <grinberg@compulab.co.il>
Cc: Tony Lindgren <tony@atomide.com>
---
arch/arm/plat-omap/debug-devices.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/plat-omap/debug-devices.c b/arch/arm/plat-omap/debug-devices.c
index c7a4c09..5a4678e 100644
--- a/arch/arm/plat-omap/debug-devices.c
+++ b/arch/arm/plat-omap/debug-devices.c
@@ -16,6 +16,7 @@
#include <linux/smc91x.h>
#include <mach/hardware.h>
+#include "../mach-omap2/debug-devices.h"
/* Many OMAP development platforms reuse the same "debug board"; these
* platforms include H2, H3, H4, and Perseus2.
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: OMAP: resolve sparse warning concerning debug_card_init()
2012-10-09 20:29 ` Paul Walmsley
@ 2012-10-10 7:01 ` Igor Grinberg
-1 siblings, 0 replies; 6+ messages in thread
From: Igor Grinberg @ 2012-10-10 7:01 UTC (permalink / raw)
To: Paul Walmsley; +Cc: linux-omap, linux-arm-kernel, tony
On 10/09/12 22:29, Paul Walmsley wrote:
>
> Commit 801475ccb2b2c1928b22aec4b9e5285d9e347602 ("ARM: OMAP: move
> debug_card_init() function") results in the following new sparse
> warning:
>
> arch/arm/plat-omap/debug-devices.c:71:12: warning: symbol 'debug_card_init' was not declared. Should it be static?
>
> Fix by implementing Tony's suggestion to add a "sideways include" to the
> new location of the debug-devices.h file in arch/arm/mach-omap2/.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Igor Grinberg <grinberg@compulab.co.il>
> Cc: Tony Lindgren <tony@atomide.com>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> arch/arm/plat-omap/debug-devices.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/plat-omap/debug-devices.c b/arch/arm/plat-omap/debug-devices.c
> index c7a4c09..5a4678e 100644
> --- a/arch/arm/plat-omap/debug-devices.c
> +++ b/arch/arm/plat-omap/debug-devices.c
> @@ -16,6 +16,7 @@
> #include <linux/smc91x.h>
>
> #include <mach/hardware.h>
> +#include "../mach-omap2/debug-devices.h"
>
> /* Many OMAP development platforms reuse the same "debug board"; these
> * platforms include H2, H3, H4, and Perseus2.
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: OMAP: resolve sparse warning concerning debug_card_init()
@ 2012-10-10 7:01 ` Igor Grinberg
0 siblings, 0 replies; 6+ messages in thread
From: Igor Grinberg @ 2012-10-10 7:01 UTC (permalink / raw)
To: linux-arm-kernel
On 10/09/12 22:29, Paul Walmsley wrote:
>
> Commit 801475ccb2b2c1928b22aec4b9e5285d9e347602 ("ARM: OMAP: move
> debug_card_init() function") results in the following new sparse
> warning:
>
> arch/arm/plat-omap/debug-devices.c:71:12: warning: symbol 'debug_card_init' was not declared. Should it be static?
>
> Fix by implementing Tony's suggestion to add a "sideways include" to the
> new location of the debug-devices.h file in arch/arm/mach-omap2/.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Igor Grinberg <grinberg@compulab.co.il>
> Cc: Tony Lindgren <tony@atomide.com>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> arch/arm/plat-omap/debug-devices.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/plat-omap/debug-devices.c b/arch/arm/plat-omap/debug-devices.c
> index c7a4c09..5a4678e 100644
> --- a/arch/arm/plat-omap/debug-devices.c
> +++ b/arch/arm/plat-omap/debug-devices.c
> @@ -16,6 +16,7 @@
> #include <linux/smc91x.h>
>
> #include <mach/hardware.h>
> +#include "../mach-omap2/debug-devices.h"
>
> /* Many OMAP development platforms reuse the same "debug board"; these
> * platforms include H2, H3, H4, and Perseus2.
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: OMAP: resolve sparse warning concerning debug_card_init()
2012-10-10 7:01 ` Igor Grinberg
@ 2012-10-16 18:07 ` Tony Lindgren
-1 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2012-10-16 18:07 UTC (permalink / raw)
To: Igor Grinberg; +Cc: Paul Walmsley, linux-omap, linux-arm-kernel
* Igor Grinberg <grinberg@compulab.co.il> [121010 00:02]:
> On 10/09/12 22:29, Paul Walmsley wrote:
> >
> > Commit 801475ccb2b2c1928b22aec4b9e5285d9e347602 ("ARM: OMAP: move
> > debug_card_init() function") results in the following new sparse
> > warning:
> >
> > arch/arm/plat-omap/debug-devices.c:71:12: warning: symbol 'debug_card_init' was not declared. Should it be static?
> >
> > Fix by implementing Tony's suggestion to add a "sideways include" to the
> > new location of the debug-devices.h file in arch/arm/mach-omap2/.
> >
> > Signed-off-by: Paul Walmsley <paul@pwsan.com>
> > Cc: Igor Grinberg <grinberg@compulab.co.il>
> > Cc: Tony Lindgren <tony@atomide.com>
>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
Thanks, applying into omap-for-v3.7-rc1/fixes-part2.
Regards,
Tony
> > ---
> > arch/arm/plat-omap/debug-devices.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/plat-omap/debug-devices.c b/arch/arm/plat-omap/debug-devices.c
> > index c7a4c09..5a4678e 100644
> > --- a/arch/arm/plat-omap/debug-devices.c
> > +++ b/arch/arm/plat-omap/debug-devices.c
> > @@ -16,6 +16,7 @@
> > #include <linux/smc91x.h>
> >
> > #include <mach/hardware.h>
> > +#include "../mach-omap2/debug-devices.h"
> >
> > /* Many OMAP development platforms reuse the same "debug board"; these
> > * platforms include H2, H3, H4, and Perseus2.
>
> --
> Regards,
> Igor.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: OMAP: resolve sparse warning concerning debug_card_init()
@ 2012-10-16 18:07 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2012-10-16 18:07 UTC (permalink / raw)
To: linux-arm-kernel
* Igor Grinberg <grinberg@compulab.co.il> [121010 00:02]:
> On 10/09/12 22:29, Paul Walmsley wrote:
> >
> > Commit 801475ccb2b2c1928b22aec4b9e5285d9e347602 ("ARM: OMAP: move
> > debug_card_init() function") results in the following new sparse
> > warning:
> >
> > arch/arm/plat-omap/debug-devices.c:71:12: warning: symbol 'debug_card_init' was not declared. Should it be static?
> >
> > Fix by implementing Tony's suggestion to add a "sideways include" to the
> > new location of the debug-devices.h file in arch/arm/mach-omap2/.
> >
> > Signed-off-by: Paul Walmsley <paul@pwsan.com>
> > Cc: Igor Grinberg <grinberg@compulab.co.il>
> > Cc: Tony Lindgren <tony@atomide.com>
>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
Thanks, applying into omap-for-v3.7-rc1/fixes-part2.
Regards,
Tony
> > ---
> > arch/arm/plat-omap/debug-devices.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/plat-omap/debug-devices.c b/arch/arm/plat-omap/debug-devices.c
> > index c7a4c09..5a4678e 100644
> > --- a/arch/arm/plat-omap/debug-devices.c
> > +++ b/arch/arm/plat-omap/debug-devices.c
> > @@ -16,6 +16,7 @@
> > #include <linux/smc91x.h>
> >
> > #include <mach/hardware.h>
> > +#include "../mach-omap2/debug-devices.h"
> >
> > /* Many OMAP development platforms reuse the same "debug board"; these
> > * platforms include H2, H3, H4, and Perseus2.
>
> --
> Regards,
> Igor.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-16 18:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-09 20:29 [PATCH] ARM: OMAP: resolve sparse warning concerning debug_card_init() Paul Walmsley
2012-10-09 20:29 ` Paul Walmsley
2012-10-10 7:01 ` Igor Grinberg
2012-10-10 7:01 ` Igor Grinberg
2012-10-16 18:07 ` Tony Lindgren
2012-10-16 18:07 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.