From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org, khilman@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv6 01/11] ARM: OMAP: clockdomain: Fix locking on _clkdm_clk_hwmod_enable / disable
Date: Tue, 16 Oct 2012 19:41:10 -0700 [thread overview]
Message-ID: <20121017024109.GR15569@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210170224570.9767@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [121016 19:26]:
> On Tue, 25 Sep 2012, Tero Kristo wrote:
>
> > Previously the code only acquired spinlock after increasing / decreasing
> > the usecount value, which is wrong. This leaves a small window where
> > a task switch may occur between the check of the usecount and the actual
> > wakeup / sleep of the domain. Fixed by moving the spinlock locking before
> > the usecount access. Left the usecount as atomic_t if someone wants an
> > easy access to the parameter through atomic_read.
> >
> > Signed-off-by: Tero Kristo <t-kristo@ti.com>
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
OK I'll apply this into omap-for-v3.7-rc1/fixes-take4.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv6 01/11] ARM: OMAP: clockdomain: Fix locking on _clkdm_clk_hwmod_enable / disable
Date: Tue, 16 Oct 2012 19:41:10 -0700 [thread overview]
Message-ID: <20121017024109.GR15569@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210170224570.9767@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [121016 19:26]:
> On Tue, 25 Sep 2012, Tero Kristo wrote:
>
> > Previously the code only acquired spinlock after increasing / decreasing
> > the usecount value, which is wrong. This leaves a small window where
> > a task switch may occur between the check of the usecount and the actual
> > wakeup / sleep of the domain. Fixed by moving the spinlock locking before
> > the usecount access. Left the usecount as atomic_t if someone wants an
> > easy access to the parameter through atomic_read.
> >
> > Signed-off-by: Tero Kristo <t-kristo@ti.com>
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
OK I'll apply this into omap-for-v3.7-rc1/fixes-take4.
Regards,
Tony
next prev parent reply other threads:[~2012-10-17 2:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 16:05 [PATCHv6 00/11]: ARM: OMAP: PM usecounting changes Tero Kristo
2012-09-25 16:05 ` Tero Kristo
2012-09-25 16:05 ` [PATCHv6 01/11] ARM: OMAP: clockdomain: Fix locking on _clkdm_clk_hwmod_enable / disable Tero Kristo
2012-09-25 16:05 ` Tero Kristo
2012-10-16 5:45 ` Paul Walmsley
2012-10-16 5:45 ` Paul Walmsley
2012-10-17 2:25 ` Paul Walmsley
2012-10-17 2:25 ` Paul Walmsley
2012-10-17 2:41 ` Tony Lindgren [this message]
2012-10-17 2:41 ` Tony Lindgren
2012-09-25 16:05 ` [PATCHv6 02/11] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking Tero Kristo
2012-09-25 16:05 ` Tero Kristo
2012-09-25 16:05 ` [PATCHv6 03/11] ARM: OMAP3+: voltage: add support for voltagedomain usecounts Tero Kristo
2012-09-25 16:05 ` Tero Kristo
2012-09-25 16:05 ` [PATCHv6 04/11] ARM: OMAP3: add manual control for mpu / core pwrdm usecounting Tero Kristo
2012-09-25 16:05 ` Tero Kristo
2012-09-25 16:05 ` [PATCHv6 05/11] ARM: OMAP3: set autoidle flag for sdrc_ick Tero Kristo
2012-09-25 16:05 ` Tero Kristo
2012-09-25 16:05 ` [PATCHv6 06/11] ARM: OMAP: clockdomain: add support for preventing autodep delete Tero Kristo
2012-09-25 16:05 ` Tero Kristo
2012-09-25 16:05 ` [PATCHv6 07/11] ARM: OMAP3: do not delete per_clkdm autodeps during idle Tero Kristo
2012-09-25 16:05 ` Tero Kristo
2012-09-25 16:05 ` [PATCHv6 08/11] ARM: OMAP4: clock data: set autoidle flag for dss_fck Tero Kristo
2012-09-25 16:05 ` Tero Kristo
2012-09-25 16:05 ` [PATCHv6 09/11] ARM: OMAP4: hwmod: add support for hwmod autoidle flag Tero Kristo
2012-09-25 16:05 ` Tero Kristo
2012-09-25 16:05 ` [PATCHv6 10/11] ARM: OMAP4: hwmod data: set mpu hwmod modulemode to hwauto Tero Kristo
2012-09-25 16:05 ` Tero Kristo
2012-09-25 16:05 ` [PATCHv6 11/11] ARM: OMAP4: clock data: flag hw controlled clocks as autoidle Tero Kristo
2012-09-25 16:05 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121017024109.GR15569@atomide.com \
--to=tony@atomide.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.