From: Sergey Senozhatsky <sergey.senozhatsky at gmail.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] Enable asserts and make correct comment
Date: Wed, 17 Oct 2012 08:17:45 -0700 [thread overview]
Message-ID: <20121017151745.GA3012@swordfish.minsk.epam.com> (raw)
In-Reply-To: 507ECA69.4000408@samsung.com
[-- Attachment #1: Type: text/plain, Size: 2952 bytes --]
On (10/17/12 19:10), Igor Zhbanov wrote:
> Hi all.
>
> Any comments? ;-)
> This patch fixes the comments and enables the asserts.
>
Hello,
sorry, I thought it was merged. I don't have any objections for testing period.
can we make global flag somewhere and inverse the flag logic: `define DEBUG' instead of `define NO_DEBUG'?
-ss
> Igor Zhbanov wrote:
> >Enable asserts for test period and correct the comments.
> >It is better to know why a crash happen when it could happen
> >than just silently die.
> >---
> > src/report/report-formatter-base.cpp | 3 ++-
> > src/report/report-formatter-csv.cpp | 3 ++-
> > src/report/report-formatter-html.cpp | 3 ++-
> > src/report/report-maker.cpp | 3 ++-
> > 4 files changed, 8 insertions(+), 4 deletions(-)
> >
> >diff --git a/src/report/report-formatter-base.cpp b/src/report/report-formatter-base.cpp
> >index 4b448be..e0dc49c 100644
> >--- a/src/report/report-formatter-base.cpp
> >+++ b/src/report/report-formatter-base.cpp
> >@@ -25,7 +25,8 @@
> > #define _BSD_SOURCE
> >-#define NDEBUG /* Enable asserts */
> >+/* Uncomment to disable asserts */
> >+/*#define NDEBUG*/
> > #include <stdio.h>
> > #include <assert.h>
> >diff --git a/src/report/report-formatter-csv.cpp b/src/report/report-formatter-csv.cpp
> >index 9b154b5..cd70d91 100644
> >--- a/src/report/report-formatter-csv.cpp
> >+++ b/src/report/report-formatter-csv.cpp
> >@@ -25,7 +25,8 @@
> > #define _BSD_SOURCE
> >-#define NDEBUG /* Enable asserts */
> >+/* Uncomment to disable asserts */
> >+/*#define NDEBUG*/
> > #include <stdio.h>
> > #include <assert.h>
> >diff --git a/src/report/report-formatter-html.cpp b/src/report/report-formatter-html.cpp
> >index 56f9648..5851575 100644
> >--- a/src/report/report-formatter-html.cpp
> >+++ b/src/report/report-formatter-html.cpp
> >@@ -25,7 +25,8 @@
> > #define _BSD_SOURCE
> >-#define NDEBUG /* Enable asserts */
> >+/* Uncomment to disable asserts */
> >+/*#define NDEBUG*/
> > #include <stdio.h>
> > #include <assert.h>
> >diff --git a/src/report/report-maker.cpp b/src/report/report-maker.cpp
> >index 4a68a8c..c00c955 100644
> >--- a/src/report/report-maker.cpp
> >+++ b/src/report/report-maker.cpp
> >@@ -23,7 +23,8 @@
> > * Written by Igor Zhbanov <i.zhbanov(a)samsung.com>
> > * 2012.10 */
> >-#define NDEBUG /* Enable asserts */
> >+/* Uncomment to disable asserts */
> >+/*#define NDEBUG*/
> > #include <assert.h>
> > #include <stdarg.h>
>
> --
> Best regards,
> Igor Zhbanov,
> Technical Leader,
> phone: +7 (495) 797 25 00 ext 3806
> e-mail: i.zhbanov(a)samsung.com
>
> ASWG, Moscow R&D center, Samsung Electronics
> 12 Dvintsev street, building 1
> 127018, Moscow, Russian Federation
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>
next reply other threads:[~2012-10-17 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 15:17 Sergey Senozhatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-24 17:37 [Powertop] [PATCH] Enable asserts and make correct comment Chris Ferron
2012-10-18 8:06 Igor Zhbanov
2012-10-17 15:21 Arjan van de Ven
2012-10-17 15:10 Igor Zhbanov
2012-10-11 10:58 Igor Zhbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121017151745.GA3012@swordfish.minsk.epam.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.