All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan at linux.intel.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH] Enable asserts and make correct comment
Date: Wed, 17 Oct 2012 08:21:21 -0700	[thread overview]
Message-ID: <507ECCF1.3050202@linux.intel.com> (raw)
In-Reply-To: 20121017151745.GA3012@swordfish.minsk.epam.com

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

On 10/17/2012 8:17 AM, Sergey Senozhatsky wrote:
> On (10/17/12 19:10), Igor Zhbanov wrote:
>> Hi all.
>>
>> Any comments? ;-)
>> This patch fixes the comments and enables the asserts.
>>
> 
> Hello,
> sorry, I thought it was merged. I don't have any objections for testing period.
> 
> can we make global flag somewhere and inverse the flag logic: `define DEBUG' instead of `define NO_DEBUG'?

nah

asserts should just always be on
no excuse not to.



             reply	other threads:[~2012-10-17 15:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-17 15:21 Arjan van de Ven [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-10-24 17:37 [Powertop] [PATCH] Enable asserts and make correct comment Chris Ferron
2012-10-18  8:06 Igor Zhbanov
2012-10-17 15:17 Sergey Senozhatsky
2012-10-17 15:10 Igor Zhbanov
2012-10-11 10:58 Igor Zhbanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507ECCF1.3050202@linux.intel.com \
    --to=powertop@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.