From: "Heiko Stübner" <heiko@sntech.de>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Chander Kashyap <chander.kashyap@linaro.org>,
linux-mmc@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
cjb@laptop.org, ben@simtec.co.uk,
broonie@opensource.wolfsonmicro.com, kgene.kim@samsung.com,
girish.shivananjappa@linaro.org, patches@linaro.org
Subject: Re: [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume
Date: Thu, 18 Oct 2012 09:41:05 +0200 [thread overview]
Message-ID: <201210180941.06091.heiko@sntech.de> (raw)
In-Reply-To: <507F63BA.7040809@samsung.com>
Hi,
Am Donnerstag, 18. Oktober 2012, 04:04:42 schrieb Jaehoon Chung:
> Sorry, i didn't check this patch with s3c2416.
> (i didn't have the s3c2416 board.)
> If you have a problem, i think good that revert this patch for fixing your
> problem. Also, i will check and share the result.
After looking a bit more through the code, I don't think the problem is 2416-
specific but seems to be caused by the gpio card-detect code.
sdhci_s3c_gpio_card_detect_thread calls sdhci_s3c_notify_change which in turn
runs host->card_tasklet that seems to want to read stuff from the card. But
this path seems to be missing a runtime-pm wakeup.
I'm not yet sure what to add, especially, as tasklet_finish (called on some
occasions from tasklet_card) already has a runtime_pm_put call, which would be
unpaired in this code path.
As there also could be other Samsung platforms affected that use the ext-gpio
code, it's probably right to revert it for now. Or you see a easy fix :-) .
Heiko
> Best Regards,
> Jaehoon Chung
>
> On 10/17/2012 06:15 PM, Heiko Stübner wrote:
> > Hi,
> >
> > Am Freitag, 14. September 2012, 11:08:51 schrieb Chander Kashyap:
> >> Perform clock disable/enable in runtime suspend/resume.
> >>
> >> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> >
> > It seems this patch breaks my S3C2416 based machine with 3.7-rc1. I'm not
> >
> > yet sure why, but the only response I get is loop of:
> > mmc0: Timeout waiting for hardware interrupt.
> > mmc0: Internal clock never stabilised.
> > mmc0: Timeout waiting for hardware interrupt.
> > mmc0: Internal clock never stabilised.
> >
> > This only happens on the hsmmc channel using the gpio-based card detect
> > and even prevents the card from beeing fully detected. The other hsmmc
> > channel using a permanent emmc seems to be working fine.
> >
> > And of course, when I revert this patch everything works fine again.
> >
> > I'll investigate further, but it'd be also ok if someone has a fix for
> > this before me :-) .
> >
> >
> > Heiko
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-10-18 7:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 9:08 [PATCH 0/3] mmc: sdhci-s3c: fixes and enhancements Chander Kashyap
2012-09-14 9:08 ` [PATCH 1/3] mmc: sdhci-s3c: Enable only required bus clock Chander Kashyap
2012-09-14 9:55 ` Jaehoon Chung
2012-09-14 10:46 ` Chander Kashyap
2012-09-14 10:49 ` Jaehoon Chung
2012-09-14 9:55 ` Girish K S
2012-09-19 6:12 ` Chris Ball
2012-09-14 9:08 ` [PATCH 2/3] mmc: sdhci-s3c: Fix crash on module insertion for second time Chander Kashyap
2012-09-14 10:25 ` Jaehoon Chung
2012-09-14 10:46 ` Girish K S
2012-09-19 6:13 ` Chris Ball
2012-09-14 9:08 ` [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume Chander Kashyap
2012-09-19 6:14 ` Chris Ball
2012-09-19 7:43 ` Jaehoon Chung
2012-09-19 8:05 ` Chris Ball
2012-09-19 14:12 ` Chander Kashyap
2012-09-19 14:21 ` Chris Ball
2012-09-19 14:22 ` Chander Kashyap
2012-09-21 5:42 ` [PATCH v2 " Chander Kashyap
2012-09-21 6:49 ` Chris Ball
2012-10-17 9:15 ` [PATCH " Heiko Stübner
2012-10-18 2:04 ` Jaehoon Chung
2012-10-18 7:41 ` Heiko Stübner [this message]
2012-10-18 9:36 ` Seungwon Jeon
2012-10-18 9:52 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210180941.06091.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=ben@simtec.co.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=chander.kashyap@linaro.org \
--cc=cjb@laptop.org \
--cc=girish.shivananjappa@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.