From: Jaehoon Chung <jh80.chung@samsung.com>
To: Chris Ball <cjb@laptop.org>
Cc: Chander Kashyap <chander.kashyap@linaro.org>,
linux-mmc@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
ben@simtec.co.uk, broonie@opensource.wolfsonmicro.com,
kgene.kim@samsung.com, girish.shivananjappa@linaro.org,
patches@linaro.org, Jaehoon Chung <jh80.chung@samsung.com>
Subject: Re: [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume
Date: Wed, 19 Sep 2012 16:43:59 +0900 [thread overview]
Message-ID: <505977BF.1010305@samsung.com> (raw)
In-Reply-To: <m3fw6eilnk.fsf@pullcord.laptop.org>
Looks good to me.
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 09/19/2012 03:14 PM, Chris Ball wrote:
> Hi Jaehoon, Girish,
>
> On Fri, Sep 14 2012, Chander Kashyap wrote:
>> Perform clock disable/enable in runtime suspend/resume.
>>
>> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
>> ---
>> drivers/mmc/host/sdhci-s3c.c | 25 +++++++++++++++++++++++--
>> 1 file changed, 23 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
>> index 3f4518d..ffffd51 100644
>> --- a/drivers/mmc/host/sdhci-s3c.c
>> +++ b/drivers/mmc/host/sdhci-s3c.c
>> @@ -513,7 +513,9 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
>> goto err_no_busclks;
>> }
>>
>> +#ifndef CONFIG_PM_RUNTIME
>> clk_enable(sc->clk_bus[sc->cur_clk]);
>> +#endif
>>
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> host->ioaddr = devm_request_and_ioremap(&pdev->dev, res);
>> @@ -620,10 +622,13 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
>> gpio_is_valid(pdata->ext_cd_gpio))
>> sdhci_s3c_setup_card_detect_gpio(sc);
>>
>> + clk_disable(sc->clk_io);
>> return 0;
>>
>> err_req_regs:
>> +#ifndef CONFIG_PM_RUNTIME
>> clk_disable(sc->clk_bus[sc->cur_clk]);
>> +#endif
>> for (ptr = 0; ptr < MAX_BUS_CLK; ptr++) {
>> if (sc->clk_bus[ptr]) {
>> clk_put(sc->clk_bus[ptr]);
>> @@ -656,12 +661,15 @@ static int __devexit sdhci_s3c_remove(struct platform_device *pdev)
>> if (gpio_is_valid(sc->ext_cd_gpio))
>> gpio_free(sc->ext_cd_gpio);
>>
>> + clk_enable(sc->clk_io);
>> sdhci_remove_host(host, 1);
>>
>> pm_runtime_dont_use_autosuspend(&pdev->dev);
>> pm_runtime_disable(&pdev->dev);
>>
>> +#ifndef CONFIG_PM_RUNTIME
>> clk_disable(sc->clk_bus[sc->cur_clk]);
>> +#endif
>> for (ptr = 0; ptr < 3; ptr++) {
>> if (sc->clk_bus[ptr]) {
>> clk_put(sc->clk_bus[ptr]);
>> @@ -696,15 +704,28 @@ static int sdhci_s3c_resume(struct device *dev)
>> static int sdhci_s3c_runtime_suspend(struct device *dev)
>> {
>> struct sdhci_host *host = dev_get_drvdata(dev);
>> + struct sdhci_s3c *ourhost = to_s3c(host);
>> + struct clk *busclk = ourhost->clk_io;
>> + int ret;
>> +
>> + ret = sdhci_runtime_suspend_host(host);
>>
>> - return sdhci_runtime_suspend_host(host);
>> + clk_disable(ourhost->clk_bus[ourhost->cur_clk]);
>> + clk_disable(busclk);
>> + return ret;
>> }
>>
>> static int sdhci_s3c_runtime_resume(struct device *dev)
>> {
>> struct sdhci_host *host = dev_get_drvdata(dev);
>> + struct sdhci_s3c *ourhost = to_s3c(host);
>> + struct clk *busclk = ourhost->clk_io;
>> + int ret;
>>
>> - return sdhci_runtime_resume_host(host);
>> + clk_enable(busclk);
>> + clk_enable(ourhost->clk_bus[ourhost->cur_clk]);
>> + ret = sdhci_runtime_resume_host(host);
>> + return ret;
>> }
>> #endif
>
> Could I get an ACK on this patch from one of you, please?
>
> - Chris.
>
next prev parent reply other threads:[~2012-09-19 7:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 9:08 [PATCH 0/3] mmc: sdhci-s3c: fixes and enhancements Chander Kashyap
2012-09-14 9:08 ` [PATCH 1/3] mmc: sdhci-s3c: Enable only required bus clock Chander Kashyap
2012-09-14 9:55 ` Jaehoon Chung
2012-09-14 10:46 ` Chander Kashyap
2012-09-14 10:49 ` Jaehoon Chung
2012-09-14 9:55 ` Girish K S
2012-09-19 6:12 ` Chris Ball
2012-09-14 9:08 ` [PATCH 2/3] mmc: sdhci-s3c: Fix crash on module insertion for second time Chander Kashyap
2012-09-14 10:25 ` Jaehoon Chung
2012-09-14 10:46 ` Girish K S
2012-09-19 6:13 ` Chris Ball
2012-09-14 9:08 ` [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume Chander Kashyap
2012-09-19 6:14 ` Chris Ball
2012-09-19 7:43 ` Jaehoon Chung [this message]
2012-09-19 8:05 ` Chris Ball
2012-09-19 14:12 ` Chander Kashyap
2012-09-19 14:21 ` Chris Ball
2012-09-19 14:22 ` Chander Kashyap
2012-09-21 5:42 ` [PATCH v2 " Chander Kashyap
2012-09-21 6:49 ` Chris Ball
2012-10-17 9:15 ` [PATCH " Heiko Stübner
2012-10-18 2:04 ` Jaehoon Chung
2012-10-18 7:41 ` Heiko Stübner
2012-10-18 9:36 ` Seungwon Jeon
2012-10-18 9:52 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505977BF.1010305@samsung.com \
--to=jh80.chung@samsung.com \
--cc=ben@simtec.co.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=chander.kashyap@linaro.org \
--cc=cjb@laptop.org \
--cc=girish.shivananjappa@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.