All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MIPS: Remove redundant TLB invalidate from pmdp_splitting_flush().
@ 2012-10-18  0:20 David Daney
  2012-10-18 11:31 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: David Daney @ 2012-10-18  0:20 UTC (permalink / raw)
  To: linux-mips, ralf; +Cc: David Daney

From: David Daney <david.daney@cavium.com>

Signed-off-by: David Daney <david.daney@cavium.com>
---
 arch/mips/mm/pgtable-64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/mm/pgtable-64.c b/arch/mips/mm/pgtable-64.c
index 6c9a477..5408bb5 100644
--- a/arch/mips/mm/pgtable-64.c
+++ b/arch/mips/mm/pgtable-64.c
@@ -71,7 +71,7 @@ void pmdp_splitting_flush(struct vm_area_struct *vma,
 	if (!pmd_trans_splitting(*pmdp)) {
 		pmd_t pmd = pmd_mksplitting(*pmdp);
 		set_pmd_at(vma->vm_mm, address, pmdp, pmd);
-		flush_tlb_range(vma, address, address + HPAGE_SIZE);
+		/* TLB already flushed by set_pmd_at() */
 	}
 }
 
-- 
1.7.11.7

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] MIPS: Remove redundant TLB invalidate from pmdp_splitting_flush().
  2012-10-18  0:20 [PATCH] MIPS: Remove redundant TLB invalidate from pmdp_splitting_flush() David Daney
@ 2012-10-18 11:31 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2012-10-18 11:31 UTC (permalink / raw)
  To: David Daney; +Cc: linux-mips, David Daney

On Wed, Oct 17, 2012 at 05:20:20PM -0700, David Daney wrote:

> diff --git a/arch/mips/mm/pgtable-64.c b/arch/mips/mm/pgtable-64.c
> index 6c9a477..5408bb5 100644
> --- a/arch/mips/mm/pgtable-64.c
> +++ b/arch/mips/mm/pgtable-64.c
> @@ -71,7 +71,7 @@ void pmdp_splitting_flush(struct vm_area_struct *vma,
>  	if (!pmd_trans_splitting(*pmdp)) {
>  		pmd_t pmd = pmd_mksplitting(*pmdp);
>  		set_pmd_at(vma->vm_mm, address, pmdp, pmd);
> -		flush_tlb_range(vma, address, address + HPAGE_SIZE);
> +		/* TLB already flushed by set_pmd_at() */

Thanks, folded into the THP patch.

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-18 11:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-18  0:20 [PATCH] MIPS: Remove redundant TLB invalidate from pmdp_splitting_flush() David Daney
2012-10-18 11:31 ` Ralf Baechle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.