[PATCH] efi: Build EFI stub with EFI-appropriate options

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] efi: Build EFI stub with EFI-appropriate options
@ 2012-07-26 22:00 Matthew Garrett
  2012-07-27 10:42 ` Matt Fleming
       [not found] ` <1343340000-7587-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  0 siblings, 2 replies; 11+ messages in thread
From: Matthew Garrett @ 2012-07-26 22:00 UTC (permalink / raw)
  To: matt.fleming; +Cc: linux-efi, linux-kernel, x86, Matthew Garrett

We can't assume the presence of the red zone while we're still in a boot
services environment, so we should build with -fno-red-zone to avoid
problems. Change the size of wchar at the same time to make string handling
simpler.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
 arch/x86/boot/compressed/Makefile |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
index e398bb5..8a84501 100644
--- a/arch/x86/boot/compressed/Makefile
+++ b/arch/x86/boot/compressed/Makefile
@@ -28,6 +28,9 @@ VMLINUX_OBJS = $(obj)/vmlinux.lds $(obj)/head_$(BITS).o $(obj)/misc.o \
 	$(obj)/string.o $(obj)/cmdline.o $(obj)/early_serial_console.o \
 	$(obj)/piggy.o
 
+$(obj)/eboot.o: KBUILD_CFLAGS += -fshort-wchar -mno-red-zone
+$(obj)/efi_stub_$(BITS).o: KBUILD_CLFAGS += -fshort-wchar -mno-red-zone
+
 ifeq ($(CONFIG_EFI_STUB), y)
 	VMLINUX_OBJS += $(obj)/eboot.o $(obj)/efi_stub_$(BITS).o
 endif
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH] efi: Build EFI stub with EFI-appropriate options
  2012-07-26 22:00 [PATCH] efi: Build EFI stub with EFI-appropriate options Matthew Garrett
@ 2012-07-27 10:42 ` Matt Fleming
       [not found] ` <1343340000-7587-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  1 sibling, 0 replies; 11+ messages in thread
From: Matt Fleming @ 2012-07-27 10:42 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: linux-efi, linux-kernel, x86

On Thu, 2012-07-26 at 18:00 -0400, Matthew Garrett wrote:
> We can't assume the presence of the red zone while we're still in a boot
> services environment, so we should build with -fno-red-zone to avoid
> problems. Change the size of wchar at the same time to make string handling
> simpler.
> 
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
> ---
>  arch/x86/boot/compressed/Makefile |    3 +++
>  1 file changed, 3 insertions(+)

Acked-by: Matt Fleming <matt.fleming@intel.com>


^ permalink raw reply	[flat|nested] 11+ messages in thread

[parent not found: <1343340000-7587-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

* Re: [PATCH] efi: Build EFI stub with EFI-appropriate options
  2012-07-26 22:00 [PATCH] efi: Build EFI stub with EFI-appropriate options Matthew Garrett
@ 2012-10-18 18:18     ` Daniel Vacek
       [not found] ` <1343340000-7587-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  1 sibling, 0 replies; 11+ messages in thread
From: Daniel Vacek @ 2012-10-18 18:18 UTC (permalink / raw)
  To: Matthew Garrett
  Cc: matt.fleming-ral2JQCrhuEAvxtiuMwx3w,
	linux-efi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, x86-DgEjT+Ai2ygdnm+yROfE0A

On Fri, Jul 27, 2012 at 12:00 AM, Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> We can't assume the presence of the red zone while we're still in a boot
> services environment, so we should build with -fno-red-zone to avoid
> problems. Change the size of wchar at the same time to make string handling
> simpler.
>
> Signed-off-by: Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  arch/x86/boot/compressed/Makefile |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
> index e398bb5..8a84501 100644
> --- a/arch/x86/boot/compressed/Makefile
> +++ b/arch/x86/boot/compressed/Makefile
> @@ -28,6 +28,9 @@ VMLINUX_OBJS = $(obj)/vmlinux.lds $(obj)/head_$(BITS).o $(obj)/misc.o \
>         $(obj)/string.o $(obj)/cmdline.o $(obj)/early_serial_console.o \
>         $(obj)/piggy.o
>
> +$(obj)/eboot.o: KBUILD_CFLAGS += -fshort-wchar -mno-red-zone
> +$(obj)/efi_stub_$(BITS).o: KBUILD_CLFAGS += -fshort-wchar -mno-red-zone
> +
>  ifeq ($(CONFIG_EFI_STUB), y)
>         VMLINUX_OBJS += $(obj)/eboot.o $(obj)/efi_stub_$(BITS).o
>  endif

s/CLFAGS/CFLAGS/

should go to stable too?

--nX
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] efi: Build EFI stub with EFI-appropriate options
@ 2012-10-18 18:18     ` Daniel Vacek
  0 siblings, 0 replies; 11+ messages in thread
From: Daniel Vacek @ 2012-10-18 18:18 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: matt.fleming, linux-efi, linux-kernel, x86

On Fri, Jul 27, 2012 at 12:00 AM, Matthew Garrett <mjg@redhat.com> wrote:
> We can't assume the presence of the red zone while we're still in a boot
> services environment, so we should build with -fno-red-zone to avoid
> problems. Change the size of wchar at the same time to make string handling
> simpler.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
> ---
>  arch/x86/boot/compressed/Makefile |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
> index e398bb5..8a84501 100644
> --- a/arch/x86/boot/compressed/Makefile
> +++ b/arch/x86/boot/compressed/Makefile
> @@ -28,6 +28,9 @@ VMLINUX_OBJS = $(obj)/vmlinux.lds $(obj)/head_$(BITS).o $(obj)/misc.o \
>         $(obj)/string.o $(obj)/cmdline.o $(obj)/early_serial_console.o \
>         $(obj)/piggy.o
>
> +$(obj)/eboot.o: KBUILD_CFLAGS += -fshort-wchar -mno-red-zone
> +$(obj)/efi_stub_$(BITS).o: KBUILD_CLFAGS += -fshort-wchar -mno-red-zone
> +
>  ifeq ($(CONFIG_EFI_STUB), y)
>         VMLINUX_OBJS += $(obj)/eboot.o $(obj)/efi_stub_$(BITS).o
>  endif

s/CLFAGS/CFLAGS/

should go to stable too?

--nX

^ permalink raw reply	[flat|nested] 11+ messages in thread

[parent not found: <CAA7rmPGL827cgT6hM8h_xhokEbTbTnrptoRekVByM7AcMdRUdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]

* Re: [PATCH] efi: Build EFI stub with EFI-appropriate options
  2012-10-18 18:18     ` Daniel Vacek
@ 2012-10-18 18:28         ` Matthew Garrett
  -1 siblings, 0 replies; 11+ messages in thread
From: Matthew Garrett @ 2012-10-18 18:28 UTC (permalink / raw)
  To: Daniel Vacek
  Cc: matt.fleming-ral2JQCrhuEAvxtiuMwx3w,
	linux-efi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, x86-DgEjT+Ai2ygdnm+yROfE0A

On Thu, Oct 18, 2012 at 08:18:51PM +0200, Daniel Vacek wrote:

> s/CLFAGS/CFLAGS/
> 
> should go to stable too?

Crap. Yes. Feel free to send that.

-- 
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] efi: Build EFI stub with EFI-appropriate options
@ 2012-10-18 18:28         ` Matthew Garrett
  0 siblings, 0 replies; 11+ messages in thread
From: Matthew Garrett @ 2012-10-18 18:28 UTC (permalink / raw)
  To: Daniel Vacek; +Cc: matt.fleming, linux-efi, linux-kernel, x86

On Thu, Oct 18, 2012 at 08:18:51PM +0200, Daniel Vacek wrote:

> s/CLFAGS/CFLAGS/
> 
> should go to stable too?

Crap. Yes. Feel free to send that.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] efi: Build EFI stub with EFI-appropriate options
  2012-10-18 18:28         ` Matthew Garrett
  (?)
@ 2012-10-18 20:32         ` Daniel Vacek
       [not found]           ` <CAA7rmPHSX+nOfQc-rs729g7ibkH5VwvsGkiOLLxX794CAgmYSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  -1 siblings, 1 reply; 11+ messages in thread
From: Daniel Vacek @ 2012-10-18 20:32 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: matt.fleming, linux-efi, linux-kernel, x86, stable

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

On Thu, Oct 18, 2012 at 8:28 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> On Thu, Oct 18, 2012 at 08:18:51PM +0200, Daniel Vacek wrote:
>
>> s/CLFAGS/CFLAGS/
>>
>> should go to stable too?
>
> Crap. Yes. Feel free to send that.

--nX

[-- Attachment #2: 0001-efi-fix-typo-in-Makefile.patch --]
[-- Type: application/octet-stream, Size: 904 bytes --]

From 53864fe932aa87be62f1c70944c386cff9bb9130 Mon Sep 17 00:00:00 2001
From: Daniel Vacek <neelx.g@gmail.com>
Date: Thu, 18 Oct 2012 22:06:26 +0200
Subject: [PATCH] efi: fix typo in Makefile

---
 arch/x86/boot/compressed/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
index 8a84501..059a17f 100644
--- a/arch/x86/boot/compressed/Makefile
+++ b/arch/x86/boot/compressed/Makefile
@@ -29,7 +29,7 @@ VMLINUX_OBJS = $(obj)/vmlinux.lds $(obj)/head_$(BITS).o $(obj)/misc.o \
 	$(obj)/piggy.o
 
 $(obj)/eboot.o: KBUILD_CFLAGS += -fshort-wchar -mno-red-zone
-$(obj)/efi_stub_$(BITS).o: KBUILD_CLFAGS += -fshort-wchar -mno-red-zone
+$(obj)/efi_stub_$(BITS).o: KBUILD_CFLAGS += -fshort-wchar -mno-red-zone
 
 ifeq ($(CONFIG_EFI_STUB), y)
 	VMLINUX_OBJS += $(obj)/eboot.o $(obj)/efi_stub_$(BITS).o
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 11+ messages in thread

[parent not found: <CAA7rmPHSX+nOfQc-rs729g7ibkH5VwvsGkiOLLxX794CAgmYSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]

* Re: [PATCH] efi: Build EFI stub with EFI-appropriate options
  2012-10-18 20:32         ` Daniel Vacek
@ 2012-10-24 17:52               ` Greg KH
  0 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2012-10-24 17:52 UTC (permalink / raw)
  To: Daniel Vacek
  Cc: Matthew Garrett, matt.fleming-ral2JQCrhuEAvxtiuMwx3w,
	linux-efi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, x86-DgEjT+Ai2ygdnm+yROfE0A,
	stable-u79uwXL29TY76Z2rM5mHXA

On Thu, Oct 18, 2012 at 10:32:50PM +0200, Daniel Vacek wrote:
> On Thu, Oct 18, 2012 at 8:28 PM, Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org> wrote:
> > On Thu, Oct 18, 2012 at 08:18:51PM +0200, Daniel Vacek wrote:
> >
> >> s/CLFAGS/CFLAGS/
> >>
> >> should go to stable too?
> >
> > Crap. Yes. Feel free to send that.

Applied, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] efi: Build EFI stub with EFI-appropriate options
@ 2012-10-24 17:52               ` Greg KH
  0 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2012-10-24 17:52 UTC (permalink / raw)
  To: Daniel Vacek
  Cc: Matthew Garrett, matt.fleming, linux-efi, linux-kernel, x86,
	stable

On Thu, Oct 18, 2012 at 10:32:50PM +0200, Daniel Vacek wrote:
> On Thu, Oct 18, 2012 at 8:28 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> > On Thu, Oct 18, 2012 at 08:18:51PM +0200, Daniel Vacek wrote:
> >
> >> s/CLFAGS/CFLAGS/
> >>
> >> should go to stable too?
> >
> > Crap. Yes. Feel free to send that.

Applied, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 11+ messages in thread

[parent not found: <20121024175225.GA27553-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>]

* Re: [PATCH] efi: Build EFI stub with EFI-appropriate options
  2012-10-24 17:52               ` Greg KH
@ 2012-10-24 20:20                   ` Daniel Vacek
  -1 siblings, 0 replies; 11+ messages in thread
From: Daniel Vacek @ 2012-10-24 20:20 UTC (permalink / raw)
  To: Greg KH
  Cc: Matthew Garrett, matt.fleming-ral2JQCrhuEAvxtiuMwx3w,
	linux-efi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, x86-DgEjT+Ai2ygdnm+yROfE0A,
	stable-u79uwXL29TY76Z2rM5mHXA

On Wed, Oct 24, 2012 at 7:52 PM, Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> wrote:
> On Thu, Oct 18, 2012 at 10:32:50PM +0200, Daniel Vacek wrote:
>> On Thu, Oct 18, 2012 at 8:28 PM, Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org> wrote:
>> > On Thu, Oct 18, 2012 at 08:18:51PM +0200, Daniel Vacek wrote:
>> >
>> >> s/CLFAGS/CFLAGS/
>> >>
>> >> should go to stable too?
>> >
>> > Crap. Yes. Feel free to send that.
>
> Applied, thanks.

Something went wrong. I responded to the other two emails.

--nX

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] efi: Build EFI stub with EFI-appropriate options
@ 2012-10-24 20:20                   ` Daniel Vacek
  0 siblings, 0 replies; 11+ messages in thread
From: Daniel Vacek @ 2012-10-24 20:20 UTC (permalink / raw)
  To: Greg KH; +Cc: Matthew Garrett, matt.fleming, linux-efi, linux-kernel, x86,
	stable

On Wed, Oct 24, 2012 at 7:52 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Oct 18, 2012 at 10:32:50PM +0200, Daniel Vacek wrote:
>> On Thu, Oct 18, 2012 at 8:28 PM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
>> > On Thu, Oct 18, 2012 at 08:18:51PM +0200, Daniel Vacek wrote:
>> >
>> >> s/CLFAGS/CFLAGS/
>> >>
>> >> should go to stable too?
>> >
>> > Crap. Yes. Feel free to send that.
>
> Applied, thanks.

Something went wrong. I responded to the other two emails.

--nX

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2012-10-24 20:20 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-26 22:00 [PATCH] efi: Build EFI stub with EFI-appropriate options Matthew Garrett
2012-07-27 10:42 ` Matt Fleming
     [not found] ` <1343340000-7587-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-10-18 18:18   ` Daniel Vacek
2012-10-18 18:18     ` Daniel Vacek
     [not found]     ` <CAA7rmPGL827cgT6hM8h_xhokEbTbTnrptoRekVByM7AcMdRUdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-18 18:28       ` Matthew Garrett
2012-10-18 18:28         ` Matthew Garrett
2012-10-18 20:32         ` Daniel Vacek
     [not found]           ` <CAA7rmPHSX+nOfQc-rs729g7ibkH5VwvsGkiOLLxX794CAgmYSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-24 17:52             ` Greg KH
2012-10-24 17:52               ` Greg KH
     [not found]               ` <20121024175225.GA27553-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-10-24 20:20                 ` Daniel Vacek
2012-10-24 20:20                   ` Daniel Vacek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.