From: Tejun Heo <tj@kernel.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Robin Dong <robin.k.dong@gmail.com>,
linux-kernel@vger.kernel.org, Robin Dong <sanbai@taobao.com>,
Jens Axboe <axboe@kernel.dk>, Tao Ma <boyu.mt@taobao.com>
Subject: Re: [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle
Date: Thu, 18 Oct 2012 16:24:04 -0700 [thread overview]
Message-ID: <20121018232404.GW13370@google.com> (raw)
In-Reply-To: <20121017134945.GC31663@redhat.com>
Hello, Vivek.
On Wed, Oct 17, 2012 at 09:49:45AM -0400, Vivek Goyal wrote:
> Can you explain a bit more. Whe do you mean by "total number queued". I
> think throttle.io_queued will total number of bios queued in the cgroup
> at the time of query.
Instead of exposing the number that blk-throttle currently has
deferred, we can expose the number of bios that have been sent to
blk-throttle and the number of bios which left blk-throttle, both
monotically increasing and the difference indicating the number being
deferred. That way we can stick to the usual stats facility.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-10-18 23:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 6:53 [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle Robin Dong
2012-10-10 14:22 ` Vivek Goyal
2012-10-16 23:27 ` Tejun Heo
2012-10-17 13:49 ` Vivek Goyal
2012-10-18 23:24 ` Tejun Heo [this message]
2012-10-19 15:00 ` Vivek Goyal
2012-10-19 19:36 ` Tejun Heo
2012-10-19 19:39 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018232404.GW13370@google.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=boyu.mt@taobao.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.k.dong@gmail.com \
--cc=sanbai@taobao.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.