From: Tejun Heo <tj@kernel.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Robin Dong <robin.k.dong@gmail.com>,
linux-kernel@vger.kernel.org, Robin Dong <sanbai@taobao.com>,
Jens Axboe <axboe@kernel.dk>, Tao Ma <boyu.mt@taobao.com>
Subject: Re: [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle
Date: Fri, 19 Oct 2012 12:36:00 -0700 [thread overview]
Message-ID: <20121019193600.GK13370@google.com> (raw)
In-Reply-To: <20121019150011.GE27052@redhat.com>
Hello, Vivek.
On Fri, Oct 19, 2012 at 11:00:11AM -0400, Vivek Goyal wrote:
> > That way we can stick to the usual stats facility.
>
> So how does this help? Because it is a monotonically increasing value
> we can use per cpu stats without extra locking? Or somthing else?
It's generally much simpler to expose dumb increasing counters. You
don't have to worry about mismatching decrements (for whatever reason,
percpu or segmented counters), so unless there's a pretty good reason
to deviate, why deviate?
Thanks.
--
tejun
next prev parent reply other threads:[~2012-10-19 19:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 6:53 [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle Robin Dong
2012-10-10 14:22 ` Vivek Goyal
2012-10-16 23:27 ` Tejun Heo
2012-10-17 13:49 ` Vivek Goyal
2012-10-18 23:24 ` Tejun Heo
2012-10-19 15:00 ` Vivek Goyal
2012-10-19 19:36 ` Tejun Heo [this message]
2012-10-19 19:39 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121019193600.GK13370@google.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=boyu.mt@taobao.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.k.dong@gmail.com \
--cc=sanbai@taobao.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.