From: Pavel Machek <pavel@ucw.cz>
To: Felipe Balbi <balbi@ti.com>
Cc: Praveen Paneri <p.paneri@samsung.com>,
l.majewski@samsung.com, linux-samsung-soc@vger.kernel.org,
heiko@sntech.de, gregkh@linuxfoundation.org,
devicetree-discuss@lists.ozlabs.org, linux-usb@vger.kernel.org,
grant.likely@secretlab.ca, kyungmin.park@samsung.com,
kgene.kim@samsung.com, thomas.abraham@linaro.org,
ben-linux@fluff.org, broonie@opensource.wolfsonmicro.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg
Date: Sat, 20 Oct 2012 21:19:19 +0200 [thread overview]
Message-ID: <20121020191919.GA555@elf.ucw.cz> (raw)
In-Reply-To: <20121015132836.GT24333@arwen.pp.htv.fi>
Hi!
> > +#define S3C_PHYPWR (0x00)
...
> > +#define S3C_PHYCLK (0x04)
> > +
> > +#define S3C_PHYCLK_MODE_SERIAL (1 << 6)
> > +#define S3C_PHYCLK_EXT_OSC (1 << 5)
> > +#define S3C_PHYCLK_COMMON_ON_N (1 << 4)
> > +#define S3C_PHYCLK_ID_PULL (1 << 2)
> > +#define S3C_PHYCLK_CLKSEL_MASK (0x3 << 0)
> > +#define S3C_PHYCLK_CLKSEL_SHIFT (0)
> > +#define S3C_PHYCLK_CLKSEL_48M (0x0 << 0)
> > +#define S3C_PHYCLK_CLKSEL_12M (0x2 << 0)
> > +#define S3C_PHYCLK_CLKSEL_24M (0x3 << 0)
I believe these 0x 's should be removed. Ouch and << 0 is interesting,
too, just remove it.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg
Date: Sat, 20 Oct 2012 21:19:19 +0200 [thread overview]
Message-ID: <20121020191919.GA555@elf.ucw.cz> (raw)
In-Reply-To: <20121015132836.GT24333@arwen.pp.htv.fi>
Hi!
> > +#define S3C_PHYPWR (0x00)
...
> > +#define S3C_PHYCLK (0x04)
> > +
> > +#define S3C_PHYCLK_MODE_SERIAL (1 << 6)
> > +#define S3C_PHYCLK_EXT_OSC (1 << 5)
> > +#define S3C_PHYCLK_COMMON_ON_N (1 << 4)
> > +#define S3C_PHYCLK_ID_PULL (1 << 2)
> > +#define S3C_PHYCLK_CLKSEL_MASK (0x3 << 0)
> > +#define S3C_PHYCLK_CLKSEL_SHIFT (0)
> > +#define S3C_PHYCLK_CLKSEL_48M (0x0 << 0)
> > +#define S3C_PHYCLK_CLKSEL_12M (0x2 << 0)
> > +#define S3C_PHYCLK_CLKSEL_24M (0x3 << 0)
I believe these 0x 's should be removed. Ouch and << 0 is interesting,
too, just remove it.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2012-10-20 19:19 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 12:54 [PATCH v6 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs Praveen Paneri
2012-09-17 12:54 ` Praveen Paneri
2012-09-17 12:54 ` [PATCH v6 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg Praveen Paneri
2012-09-17 12:54 ` Praveen Paneri
[not found] ` <1347886484-16064-2-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-09-24 9:38 ` Praveen Paneri
2012-09-24 9:38 ` Praveen Paneri
2012-09-24 10:39 ` ABRAHAM, KISHON VIJAY
2012-09-24 10:39 ` ABRAHAM, KISHON VIJAY
[not found] ` <CAD6zSYP0seNbwYB1VMLBH++gXKs3ZkJg-ztx6_2263OxPn7M6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-25 11:29 ` Marc Kleine-Budde
2012-09-25 11:29 ` Marc Kleine-Budde
[not found] ` <50619595.4010304-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-26 7:22 ` Praveen Paneri
2012-09-26 7:22 ` Praveen Paneri
[not found] ` <CAD6zSYOCJ2wV82-oeX5xo2COMKMQMsPfgeesPhq+Ui_3_PU5ag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-03 9:26 ` [PATCH " Praveen Paneri
2012-10-03 9:26 ` Praveen Paneri
2012-10-12 10:15 ` [PATCH] " Praveen Paneri
2012-10-12 10:15 ` Praveen Paneri
[not found] ` <1350036934-6051-1-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-10-15 13:28 ` Felipe Balbi
2012-10-15 13:28 ` Felipe Balbi
2012-10-15 13:44 ` Kyungmin Park
2012-10-15 13:44 ` Kyungmin Park
[not found] ` <20121015132836.GT24333-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-10-16 5:39 ` Praveen Paneri
2012-10-16 5:39 ` Praveen Paneri
2012-10-20 19:19 ` Pavel Machek [this message]
2012-10-20 19:19 ` Pavel Machek
2012-10-22 5:43 ` Praveen Paneri
2012-10-22 5:43 ` Praveen Paneri
2012-10-17 11:00 ` Kukjin Kim
2012-10-17 11:00 ` Kukjin Kim
2012-10-17 12:30 ` Praveen Paneri
2012-10-17 12:30 ` Praveen Paneri
[not found] ` <005801cdac56$8da0c120$a8e24360$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-10-17 19:13 ` Russell King - ARM Linux
2012-10-17 19:13 ` Russell King - ARM Linux
2012-10-21 7:16 ` Domenico Andreoli
2012-10-21 7:16 ` Domenico Andreoli
2012-09-24 13:04 ` [PATCH v6 1/5] " Rob Herring
2012-09-24 13:04 ` Rob Herring
[not found] ` <50605A69.2070201-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-09-25 11:23 ` Praveen Paneri
2012-09-25 11:23 ` Praveen Paneri
2012-09-25 12:18 ` Rob Herring
2012-09-25 12:18 ` Rob Herring
2012-09-25 13:17 ` ABRAHAM, KISHON VIJAY
2012-09-25 13:17 ` ABRAHAM, KISHON VIJAY
2012-09-26 7:14 ` Praveen Paneri
2012-09-26 7:14 ` Praveen Paneri
2012-09-24 10:41 ` Kyungmin Park
2012-09-24 10:41 ` Kyungmin Park
[not found] ` <1347886484-16064-1-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-09-17 12:54 ` [PATCH v6 2/5] usb: s3c-hsotg: Adding phy driver support Praveen Paneri
2012-09-17 12:54 ` Praveen Paneri
2012-09-17 12:54 ` [PATCH v6 3/5] ARM: S3C64XX: Removing old phy setup code Praveen Paneri
2012-09-17 12:54 ` Praveen Paneri
2012-09-17 12:54 ` [PATCH v6 4/5] ARM: S3C64XX: Enabling samsung-usbphy driver Praveen Paneri
2012-09-17 12:54 ` Praveen Paneri
2012-09-17 12:54 ` [PATCH v6 5/5] ARM: Exynos4210: " Praveen Paneri
2012-09-17 12:54 ` Praveen Paneri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121020191919.GA555@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.paneri@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.