[net-next:master 28/31] drivers/net/ethernet/emulex/benet/be_main.c:3116 be_flash() error: __builtin_memcpy() 'req->params.data_buf' too small (4 vs 32768)

[net-next:master 28/31] drivers/net/ethernet/emulex/benet/be_main.c:3116 be_flash() error: __builtin_memcpy() 'req->params.data_buf' too small (4 vs 32768)

[Yuanhan Liu]

Hi Padmanabh,

FYI, there are new smatch warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   46baac38ef633b08168d27df7b02eb14578fb760
commit: 773a2d7c55a3d63207841c824d21920bd3683460 [28/31] be2net: Fix FW flashing on Skyhawk-R

+ drivers/net/ethernet/emulex/benet/be_main.c:3116 be_flash() error: __builtin_memcpy() 'req->params.data_buf' too small (4 vs 32768)

vim +3116 drivers/net/ethernet/emulex/benet/be_main.c

773a2d7c Padmanabh Ratnakar 2012-10-20  3100  		num_bytes = min_t(u32, 32*1024, total_bytes);
773a2d7c Padmanabh Ratnakar 2012-10-20  3101  
773a2d7c Padmanabh Ratnakar 2012-10-20  3102  		total_bytes -= num_bytes;
773a2d7c Padmanabh Ratnakar 2012-10-20  3103  
773a2d7c Padmanabh Ratnakar 2012-10-20  3104  		if (!total_bytes) {
773a2d7c Padmanabh Ratnakar 2012-10-20  3105  			if (optype == OPTYPE_PHY_FW)
773a2d7c Padmanabh Ratnakar 2012-10-20  3106  				flash_op = FLASHROM_OPER_PHY_FLASH;
773a2d7c Padmanabh Ratnakar 2012-10-20  3107  			else
773a2d7c Padmanabh Ratnakar 2012-10-20  3108  				flash_op = FLASHROM_OPER_FLASH;
773a2d7c Padmanabh Ratnakar 2012-10-20  3109  		} else {
773a2d7c Padmanabh Ratnakar 2012-10-20  3110  			if (optype == OPTYPE_PHY_FW)
773a2d7c Padmanabh Ratnakar 2012-10-20  3111  				flash_op = FLASHROM_OPER_PHY_SAVE;
773a2d7c Padmanabh Ratnakar 2012-10-20  3112  			else
773a2d7c Padmanabh Ratnakar 2012-10-20  3113  				flash_op = FLASHROM_OPER_SAVE;
773a2d7c Padmanabh Ratnakar 2012-10-20  3114  		}
773a2d7c Padmanabh Ratnakar 2012-10-20  3115  
773a2d7c Padmanabh Ratnakar 2012-10-20 @3116  		memcpy(req->params.data_buf, img, num_bytes);
773a2d7c Padmanabh Ratnakar 2012-10-20  3117  		img += num_bytes;
773a2d7c Padmanabh Ratnakar 2012-10-20  3118  		status = be_cmd_write_flashrom(adapter, flash_cmd, optype,
773a2d7c Padmanabh Ratnakar 2012-10-20  3119  						flash_op, num_bytes);
773a2d7c Padmanabh Ratnakar 2012-10-20  3120  		if (status) {
773a2d7c Padmanabh Ratnakar 2012-10-20  3121  			if (status == ILLEGAL_IOCTL_REQ &&
773a2d7c Padmanabh Ratnakar 2012-10-20  3122  			    optype == OPTYPE_PHY_FW)
773a2d7c Padmanabh Ratnakar 2012-10-20  3123  				break;
773a2d7c Padmanabh Ratnakar 2012-10-20  3124  			dev_err(&adapter->pdev->dev,

---
0-DAY kernel build testing backend         Open Source Technology Center
Fengguang Wu, Yuanhan Liu                              Intel Corporation

RE: [net-next:master 28/31] drivers/net/ethernet/emulex/benet/be_main.c:3116 be_flash() error: __builtin_memcpy() 'req->params.data_buf' too small (4 vs 32768)

[Perla, Sathya]

>-----Original Message-----
>From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On
>Behalf Of Yuanhan Liu
>
>Hi Padmanabh,
>
>FYI, there are new smatch warnings show up in
>
>tree:   git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
>head:   46baac38ef633b08168d27df7b02eb14578fb760
>commit: 773a2d7c55a3d63207841c824d21920bd3683460 [28/31] be2net: Fix FW
>flashing on Skyhawk-R
>
>+ drivers/net/ethernet/emulex/benet/be_main.c:3116 be_flash() error:
>__builtin_memcpy() 'req->params.data_buf' too small (4 vs 32768)
>

Padmanabh is not in today. We'll check this and send a fix asap...
Thanks!

-Sathya