All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Mike Turquette <mturquette@linaro.org>,
	Guan Xuetao <gxt@mprc.pku.edu.cn>,
	Ralf Baechle <ralf@linux-mips.org>,
	linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: Make the generic clock API available by default
Date: Mon, 22 Oct 2012 14:27:11 +0100	[thread overview]
Message-ID: <20121022132711.GE4477@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20121022130556.GM21164@n2100.arm.linux.org.uk>

On Mon, Oct 22, 2012 at 02:05:57PM +0100, Russell King - ARM Linux wrote:
> On Mon, Oct 22, 2012 at 02:02:50PM +0100, Mark Brown wrote:
> > @@ -327,6 +328,7 @@ config ARCH_AT91
> >  	select ARCH_REQUIRE_GPIOLIB
> >  	select CLKDEV_LOOKUP
> >  	select HAVE_CLK
> > +	select HAVE_CUSTOM_CLK

> This is silly.  If you select "HAVE_CUSTOM_CLK" then isn't it true that
> "HAVE_CLK" should also be selected?  If so, why not have "HAVE_CUSTOM_CLK"
> do that selection and remove it from all these entries?

If we're worrying about that there's the larger point that the effect of
this patch is to make HAVE_CLK meaningless as there will be no platform
for which it's not true.  I was just leaving HAVE_CLK alone for now
ready to circle around on it if we ever manage to get the enabling bit
sorted.

WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Make the generic clock API available by default
Date: Mon, 22 Oct 2012 14:27:11 +0100	[thread overview]
Message-ID: <20121022132711.GE4477@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20121022130556.GM21164@n2100.arm.linux.org.uk>

On Mon, Oct 22, 2012 at 02:05:57PM +0100, Russell King - ARM Linux wrote:
> On Mon, Oct 22, 2012 at 02:02:50PM +0100, Mark Brown wrote:
> > @@ -327,6 +328,7 @@ config ARCH_AT91
> >  	select ARCH_REQUIRE_GPIOLIB
> >  	select CLKDEV_LOOKUP
> >  	select HAVE_CLK
> > +	select HAVE_CUSTOM_CLK

> This is silly.  If you select "HAVE_CUSTOM_CLK" then isn't it true that
> "HAVE_CLK" should also be selected?  If so, why not have "HAVE_CUSTOM_CLK"
> do that selection and remove it from all these entries?

If we're worrying about that there's the larger point that the effect of
this patch is to make HAVE_CLK meaningless as there will be no platform
for which it's not true.  I was just leaving HAVE_CLK alone for now
ready to circle around on it if we ever manage to get the enabling bit
sorted.

  reply	other threads:[~2012-10-22 13:27 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 13:02 [PATCH] clk: Make the generic clock API available by default Mark Brown
2012-10-22 13:02 ` Mark Brown
2012-10-22 13:05 ` Russell King - ARM Linux
2012-10-22 13:05   ` Russell King - ARM Linux
2012-10-22 13:27   ` Mark Brown [this message]
2012-10-22 13:27     ` Mark Brown
2012-10-22 13:50     ` Russell King - ARM Linux
2012-10-22 13:50       ` Russell King - ARM Linux
2012-10-22 13:54       ` Mark Brown
2012-10-22 13:54         ` Mark Brown
2012-10-22 15:56 ` Stephen Warren
2012-10-22 15:56   ` Stephen Warren
2012-10-23  9:47   ` Mark Brown
2012-10-23  9:47     ` Mark Brown
2012-10-23  2:10 ` Kelvin Cheung
2012-10-23  9:22   ` Mark Brown
2012-10-23  9:22     ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2012-10-23  9:54 Mark Brown
2012-10-23  9:54 ` Mark Brown
2012-11-26 21:39 ` Grant Likely
2012-11-26 21:39   ` Grant Likely
2012-11-26 21:39   ` Grant Likely
2012-08-28 20:35 Mark Brown
2012-08-28 20:35 ` Mark Brown
2012-08-28 20:35 ` Mark Brown
2012-08-29  5:56 ` Hans-Christian Egtvedt
2012-08-29  5:56   ` Hans-Christian Egtvedt
2012-08-29  5:56   ` Hans-Christian Egtvedt
2012-08-29 21:49 ` Stephen Warren
2012-08-29 21:49   ` Stephen Warren
2012-08-29 21:49   ` Stephen Warren
2012-08-30 17:19   ` Mark Brown
2012-08-30 17:19     ` Mark Brown
2012-08-30 17:19     ` Mark Brown
2012-08-30 23:40     ` Stephen Warren
2012-08-30 23:40       ` Stephen Warren
2012-08-30 23:40       ` Stephen Warren
2012-09-05  2:03 ` Benjamin Herrenschmidt
2012-09-05  2:03   ` Benjamin Herrenschmidt
2012-09-05  2:03   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121022132711.GE4477@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mturquette@linaro.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.