Re: [Qemu-devel] [PATCH 1/3] tcg-alpha: Fix type mismatch errors in cpu_signal_handler.

[Aurelien Jarno <aurelien@aurel32.net>]

On Sat, Sep 29, 2012 at 11:10:37AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  user-exec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/user-exec.c b/user-exec.c
> index ef9b172..1635e4a 100644
> --- a/user-exec.c
> +++ b/user-exec.c
> @@ -352,8 +352,8 @@ int cpu_signal_handler(int host_signum, void *pinfo,
>  {
>      siginfo_t *info = pinfo;
>      struct ucontext *uc = puc;
> -    uint32_t *pc = uc->uc_mcontext.sc_pc;
> -    uint32_t insn = *pc;
> +    unsigned long pc = uc->uc_mcontext.sc_pc;
> +    uint32_t insn = *(uint32_t *)pc;
>      int is_write = 0;
>  
>      /* XXX: need kernel patch to get write flag faster */

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net