* [PATCH -next] printk: fix broken 'console' kernel parameter
@ 2012-10-23 13:41 Ming Lei
2012-10-23 13:49 ` Joe Perches
2012-10-23 14:07 ` Fengguang Wu
0 siblings, 2 replies; 3+ messages in thread
From: Ming Lei @ 2012-10-23 13:41 UTC (permalink / raw)
To: linux-kernel; +Cc: Ming Lei, Andrew Morton, Samuel Thibault, Joe Perches
If CONFIG_A11Y_BRAILLE_CONSOLE is not enabled, _braille_console_setup()
should return NULL to parse the parameter further in console_setup().
This patch fixes the broken 'console' kernel parameter, which makes the
Pandaboard not boot with 'console=ttyO2'.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
kernel/printk/braille.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/printk/braille.h b/kernel/printk/braille.h
index d2e6bc3..769d771 100644
--- a/kernel/printk/braille.h
+++ b/kernel/printk/braille.h
@@ -28,7 +28,7 @@ braille_set_options(struct console_cmdline *c, char *brl_options)
static inline char *
_braille_console_setup(char **str, char **brl_options)
{
- return *str;
+ return NULL;
}
static inline int
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] printk: fix broken 'console' kernel parameter
2012-10-23 13:41 [PATCH -next] printk: fix broken 'console' kernel parameter Ming Lei
@ 2012-10-23 13:49 ` Joe Perches
2012-10-23 14:07 ` Fengguang Wu
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2012-10-23 13:49 UTC (permalink / raw)
To: Ming Lei; +Cc: linux-kernel, Andrew Morton, Samuel Thibault
On Tue, 2012-10-23 at 21:41 +0800, Ming Lei wrote:
> If CONFIG_A11Y_BRAILLE_CONSOLE is not enabled, _braille_console_setup()
> should return NULL to parse the parameter further in console_setup().
>
> This patch fixes the broken 'console' kernel parameter, which makes the
> Pandaboard not boot with 'console=ttyO2'.
[]
> diff --git a/kernel/printk/braille.h b/kernel/printk/braille.h
[]
> @@ -28,7 +28,7 @@ braille_set_options(struct console_cmdline *c, char *brl_options)
> static inline char *
> _braille_console_setup(char **str, char **brl_options)
> {
> - return *str;
> + return NULL;
> }
Thanks, I'll wait a day or two for any more reports
then repost the whole series.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] printk: fix broken 'console' kernel parameter
2012-10-23 13:41 [PATCH -next] printk: fix broken 'console' kernel parameter Ming Lei
2012-10-23 13:49 ` Joe Perches
@ 2012-10-23 14:07 ` Fengguang Wu
1 sibling, 0 replies; 3+ messages in thread
From: Fengguang Wu @ 2012-10-23 14:07 UTC (permalink / raw)
To: Ming Lei; +Cc: linux-kernel, Andrew Morton, Samuel Thibault, Joe Perches
On Tue, Oct 23, 2012 at 09:41:18PM +0800, Ming Lei wrote:
> If CONFIG_A11Y_BRAILLE_CONSOLE is not enabled, _braille_console_setup()
> should return NULL to parse the parameter further in console_setup().
>
> This patch fixes the broken 'console' kernel parameter, which makes the
> Pandaboard not boot with 'console=ttyO2'.
Not sure if this is related, but I got an early crash with linux-next and
the first bad commit is
commit 10db96eb4942a011a76de8c98aabc4f132a882d9
Author: Joe Perches <joe@perches.com>
Date: Tue Oct 23 13:50:17 2012 +1100
printk: move braille console support into separate braille.[ch]
files
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-23 14:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-23 13:41 [PATCH -next] printk: fix broken 'console' kernel parameter Ming Lei
2012-10-23 13:49 ` Joe Perches
2012-10-23 14:07 ` Fengguang Wu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.