All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: "Igor Grinberg" <grinberg@compulab.co.il>,
	"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
	linux-omap@vger.kernel.org,
	"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
	"Cousson, Benoit" <b-cousson@ti.com>,
	"Paul Walmsley" <paul@pwsan.com>, "Kevin Hilman" <khilman@ti.com>,
	"Afzal Mohammed" <afzal@ti.com>,
	"Péter Ujfalusi" <peter.ujfalusi@ti.com>
Subject: Re: Errors at boot time from OMAP4430SDP (and a whinge about serial stuff)
Date: Tue, 23 Oct 2012 18:54:19 -0700	[thread overview]
Message-ID: <20121024015418.GC5605@atomide.com> (raw)
In-Reply-To: <CAK=WgbbPmuOgssRRSinsV3rXg7TUa9fpOP-Zg+VatZgqgVYixw@mail.gmail.com>

* Ohad Ben-Cohen <ohad@wizery.com> [121021 07:56]:
> On Fri, Oct 19, 2012 at 7:07 PM, Tony Lindgren <tony@atomide.com> wrote:
> --- a/arch/arm/mach-davinci/board-da850-evm.c
> +++ b/arch/arm/mach-davinci/board-da850-evm.c
> @@ -1401,13 +1401,9 @@ static __init int da850_wl12xx_init(void)
>  		goto free_wlan_en;
>  	}
> 
> -	da850_wl12xx_wlan_data.irq = gpio_to_irq(DA850_WLAN_IRQ);
> -
> -	ret = wl12xx_set_platform_data(&da850_wl12xx_wlan_data);
> -	if (ret) {
> -		pr_err("Could not set wl12xx data: %d\n", ret);
> +	ret = wl12xx_board_init(&da850_wl12xx_wlan_data, DA850_WLAN_IRQ);
> +	if (ret)
>  		goto free_wlan_irq;
> -	}
> 
>  	return 0;

I don't think mach-davinci has wl12xx_board_init() available?
Maybe leave this out or define also also somewhere for mach-davinci?

Regards,

Tony

  parent reply	other threads:[~2012-10-24  1:54 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-12 15:54 Errors at boot time from OMAP4430SDP (and a whinge about serial stuff) Russell King - ARM Linux
2012-10-12 16:24 ` Tony Lindgren
2012-10-12 16:31   ` Russell King - ARM Linux
2012-10-12 16:34   ` Benoit Cousson
2012-10-12 16:56     ` Tony Lindgren
2012-10-12 18:47   ` Kevin Hilman
2012-10-14 18:30   ` Ohad Ben-Cohen
2012-10-16 18:10     ` Tony Lindgren
2012-10-16 18:26       ` Tony Lindgren
2012-10-17  9:10         ` Ohad Ben-Cohen
2012-10-17 12:43           ` Igor Grinberg
2012-10-18 16:58             ` Ohad Ben-Cohen
2012-10-19 17:07               ` Tony Lindgren
2012-10-21 14:54                 ` Ohad Ben-Cohen
2012-10-23  7:37                   ` Igor Grinberg
2012-10-23  7:51                     ` Ohad Ben-Cohen
2012-10-23  9:46                       ` Igor Grinberg
2012-10-24  1:54                   ` Tony Lindgren [this message]
2012-10-24 11:15                     ` Ohad Ben-Cohen
2012-10-25 19:03                       ` Tony Lindgren
2012-10-15  5:54   ` Mohammed, Afzal
2012-10-16 18:12     ` Tony Lindgren
2012-10-16 19:24       ` Benoit Cousson
2012-10-16 19:53         ` Tony Lindgren
2012-10-15  7:37   ` Péter Ujfalusi
2012-10-23 10:10 ` Russell King - ARM Linux
2012-10-25  1:09   ` Tony Lindgren
2012-10-25 16:05     ` Balaji T K
2012-10-25 17:24     ` Kevin Hilman
2012-10-25 17:38       ` Kevin Hilman
2012-10-25 17:46         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121024015418.GC5605@atomide.com \
    --to=tony@atomide.com \
    --cc=afzal@ti.com \
    --cc=b-cousson@ti.com \
    --cc=grinberg@compulab.co.il \
    --cc=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=ohad@wizery.com \
    --cc=paul@pwsan.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.