* [PATCH 1/1] pinctrl: at91: fix typo on PULL_UP
@ 2012-10-23 16:28 Jean-Christophe PLAGNIOL-VILLARD
2012-10-24 7:45 ` Linus Walleij
2012-10-24 12:00 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-23 16:28 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Ludovic Desroches <ludovic.desroches@atmel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
drivers/pinctrl/pinctrl-at91.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index c87c2c5..0757e94 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -58,7 +58,7 @@ static struct at91_gpio_chip *gpio_chips[MAX_GPIO_BANKS];
static int gpio_banks;
-#define PULL_UP (0 << 1)
+#define PULL_UP (1 << 0)
#define MULTI_DRIVE (1 << 1)
/**
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/1] pinctrl: at91: fix typo on PULL_UP
2012-10-23 16:28 [PATCH 1/1] pinctrl: at91: fix typo on PULL_UP Jean-Christophe PLAGNIOL-VILLARD
@ 2012-10-24 7:45 ` Linus Walleij
2012-10-24 9:20 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-24 12:00 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2012-10-24 7:45 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 23, 2012 at 6:28 PM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@jcrosoft.com> wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: Ludovic Desroches <ludovic.desroches@atmel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/pinctrl/pinctrl-at91.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index c87c2c5..0757e94 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -58,7 +58,7 @@ static struct at91_gpio_chip *gpio_chips[MAX_GPIO_BANKS];
>
> static int gpio_banks;
>
> -#define PULL_UP (0 << 1)
> +#define PULL_UP (1 << 0)
Makes perfect sense. Shall I just apply this to the at91 branch too?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] pinctrl: at91: fix typo on PULL_UP
2012-10-24 7:45 ` Linus Walleij
@ 2012-10-24 9:20 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 4+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-24 9:20 UTC (permalink / raw)
To: linux-arm-kernel
On 09:45 Wed 24 Oct , Linus Walleij wrote:
> On Tue, Oct 23, 2012 at 6:28 PM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft.com> wrote:
>
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > Cc: Ludovic Desroches <ludovic.desroches@atmel.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > drivers/pinctrl/pinctrl-at91.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> > index c87c2c5..0757e94 100644
> > --- a/drivers/pinctrl/pinctrl-at91.c
> > +++ b/drivers/pinctrl/pinctrl-at91.c
> > @@ -58,7 +58,7 @@ static struct at91_gpio_chip *gpio_chips[MAX_GPIO_BANKS];
> >
> > static int gpio_banks;
> >
> > -#define PULL_UP (0 << 1)
> > +#define PULL_UP (1 << 0)
>
> Makes perfect sense. Shall I just apply this to the at91 branch too?
yeah but can the at91 is for 3.7? or 3.8?
Best Regards,
J.
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] pinctrl: at91: fix typo on PULL_UP
2012-10-23 16:28 [PATCH 1/1] pinctrl: at91: fix typo on PULL_UP Jean-Christophe PLAGNIOL-VILLARD
2012-10-24 7:45 ` Linus Walleij
@ 2012-10-24 12:00 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2012-10-24 12:00 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 23, 2012 at 6:28 PM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@jcrosoft.com> wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: Ludovic Desroches <ludovic.desroches@atmel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
Applied to the at91 branch, thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-24 12:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-23 16:28 [PATCH 1/1] pinctrl: at91: fix typo on PULL_UP Jean-Christophe PLAGNIOL-VILLARD
2012-10-24 7:45 ` Linus Walleij
2012-10-24 9:20 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-24 12:00 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.