From: Arnd Bergmann <arnd@arndb.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linus.walleij@stericsson.com,
Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/1] mmc: Standardise capability type
Date: Wed, 24 Oct 2012 13:21:26 +0000 [thread overview]
Message-ID: <201210241321.26878.arnd@arndb.de> (raw)
In-Reply-To: <1351084664-30526-1-git-send-email-lee.jones@linaro.org>
On Wednesday 24 October 2012, Lee Jones wrote:
>
> There are discrepancies with regards to how MMC capabilities
> are carried throughout the subsystem. Let's standardise them
> to elevate any confusion.
>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: linux-mmc@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Why make it "unsigned long" then? I think that adds to the
confusion because it's sometimes 32 bits and sometimes 64 bits,
depending on the CPU. Since it's a bitmask, I would suggest
using u32 to make the size explicit.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] mmc: Standardise capability type
Date: Wed, 24 Oct 2012 13:21:26 +0000 [thread overview]
Message-ID: <201210241321.26878.arnd@arndb.de> (raw)
In-Reply-To: <1351084664-30526-1-git-send-email-lee.jones@linaro.org>
On Wednesday 24 October 2012, Lee Jones wrote:
>
> There are discrepancies with regards to how MMC capabilities
> are carried throughout the subsystem. Let's standardise them
> to elevate any confusion.
>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: linux-mmc at vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Why make it "unsigned long" then? I think that adds to the
confusion because it's sometimes 32 bits and sometimes 64 bits,
depending on the CPU. Since it's a bitmask, I would suggest
using u32 to make the size explicit.
Arnd
next prev parent reply other threads:[~2012-10-24 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 13:17 [PATCH 1/1] mmc: Standardise capability type Lee Jones
2012-10-24 13:17 ` Lee Jones
2012-10-24 13:21 ` Arnd Bergmann [this message]
2012-10-24 13:21 ` Arnd Bergmann
2012-10-24 14:53 ` Lee Jones
2012-10-24 14:53 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210241321.26878.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.