[PATCH 1/4] pulseaudio: add GConf dependency

[PATCH 1/4] pulseaudio: add GConf dependency

[Ross Burton]

Add explicit build-dependency on GConf as currently it's an implicit dependency
and so vunerable to races at build time.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc    |    2 +-
 meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 463777d..ab70c7e 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = "file://GPL;md5=4325afd396febcb659c36b49533135d4 \
 DEPENDS = "libatomics-ops liboil avahi libsamplerate0 libsndfile1 libtool \
            ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxtst libice libsm libxcb gtk+', '', d)}"
 # optional
-DEPENDS += "udev alsa-lib glib-2.0 dbus \
+DEPENDS += "udev alsa-lib glib-2.0 dbus gconf \
            ${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '', d)}"
 
 SRC_URI = "http://0pointer.de/lennart/projects/pulseaudio/pulseaudio-${PV}.tar.gz \
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
index a10b953..d25b424 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
@@ -1,6 +1,6 @@
 require pulseaudio.inc
 
-PR = "r7"
+PR = "r8"
 
 DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
 
-- 
1.7.10

[PATCH 2/4] pulseaudio: move helper binaries into the relevant module packages

[Ross Burton]

proximity-helper is only used by the bluetooth-proximity module, and
gconf-helper is only used by the gconf module.  Clarify the packaging and clean
up dependencies by shipping the helper binaries with the modules that spawn
them.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc    |   11 +++++++----
 meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb |    2 +-
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index ab70c7e..70b77da 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -65,7 +65,7 @@ USERADD_PARAM_pulseaudio-server = "--system --home /var/run/pulse \
                               --groups audio,pulse --gid pulse pulse"
 
 PACKAGES =+ "libpulsecore libpulsecommon libpulsedsp libpulse libpulse-simple libpulse-browse libpulse-mainloop-glib \
-             pulseaudio-server pulseaudio-misc pulseaudio-gconf-helper"
+             pulseaudio-server pulseaudio-misc"
 
 #upgrade path:
 RREPLACES_pulseaudio-server = "libpulse-bin libpulse-conf"
@@ -86,7 +86,6 @@ FILES_${PN}-dev += "${libdir}/pulse-${PV}/modules/*.la ${datadir}/vala ${libdir}
 FILES_${PN}-conf = "${sysconfdir}"
 FILES_${PN}-bin += "${sysconfdir}/default/volatiles/volatiles.04_pulse"
 FILES_${PN}-server = "${bindir}/pulseaudio ${bindir}/start-* ${sysconfdir} ${bindir}/pactl ${base_libdir}/udev/rules.d/*.rules"
-FILES_${PN}-gconf-helper = "${libexecdir}/pulse/gconf-helper"
 FILES_${PN}-misc = "${bindir}/*"
 
 # Allow the pulseaudio package to be created empty as a placeholder (-dbg and -dev depend on it)
@@ -113,8 +112,8 @@ python populate_packages_prepend() {
     #d.setVar('PKG_pulseaudio', 'pulseaudio')
 
     plugindir = d.expand('${libdir}/pulse-${PV}/modules/')
-    do_split_packages(d, plugindir, '^module-(.*)\.so$', 'pulseaudio-module-%s', 'PulseAudio module for %s', extra_depends='' )
-    do_split_packages(d, plugindir, '^lib(.*)\.so$', 'pulseaudio-lib-%s', 'PulseAudio library for %s', extra_depends='' )
+    do_split_packages(d, plugindir, '^module-(.*)\.so$', 'pulseaudio-module-%s', 'PulseAudio module for %s', extra_depends='', prepend=True)
+    do_split_packages(d, plugindir, '^lib(.*)\.so$', 'pulseaudio-lib-%s', 'PulseAudio library for %s', extra_depends='', prepend=True)
 }
 
 RDEPENDS_pulseaudio-server = " \
@@ -141,5 +140,9 @@ RDEPENDS_pulseaudio-server = " \
     pulseaudio-module-switch-on-port-available"
 
 RDEPENDS_pulseaudio-module-console-kit =+ "consolekit"
+
+FILES_pulseaudio-module-gconf += "${libexecdir}/pulse/gconf-helper"
+FILES_pulseaudio-module-bluetooth-proximity += "${libexecdir}/pulse/proximity-helper"
+
 RDEPENDS_pulseaudio-server += "\
         ${@base_contains('DISTRO_FEATURES', 'x11', 'pulseaudio-module-console-kit', '', d)}"
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
index d25b424..07410a4 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
@@ -1,6 +1,6 @@
 require pulseaudio.inc
 
-PR = "r8"
+PR = "r9"
 
 DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
 
-- 
1.7.10

[PATCH 3/4] pulseaudio: fix library packaging

[Ross Burton]

libpulsecommon has moved into libdir/pulse.

libpulsedsp is an internal library for padsp so put that into pulseaudio-misc
along with padsp.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc    |    7 +++----
 meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb |    2 +-
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 70b77da..8c19c22 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -64,7 +64,7 @@ USERADD_PARAM_pulseaudio-server = "--system --home /var/run/pulse \
                               --no-create-home --shell /bin/false \
                               --groups audio,pulse --gid pulse pulse"
 
-PACKAGES =+ "libpulsecore libpulsecommon libpulsedsp libpulse libpulse-simple libpulse-browse libpulse-mainloop-glib \
+PACKAGES =+ "libpulsecore libpulsecommon libpulse libpulse-simple libpulse-browse libpulse-mainloop-glib \
              pulseaudio-server pulseaudio-misc"
 
 #upgrade path:
@@ -73,8 +73,7 @@ RREPLACES_pulseaudio-server = "libpulse-bin libpulse-conf"
 PACKAGES_DYNAMIC += "^pulseaudio-lib.* ^pulseaudio-module.* ^libpulse-lib.* ^libpulse-module.* "
 
 FILES_libpulsecore = "${libdir}/libpulsecore*.so"
-FILES_libpulsecommon = "${libdir}/libpulsecommon*.so"
-FILES_libpulsedsp = "${libdir}/libpulsedsp*.so"
+FILES_libpulsecommon = "${libdir}/pulseaudio/libpulsecommon*.so"
 FILES_libpulse = "${libdir}/libpulse.so.*"
 FILES_libpulse-simple = "${libdir}/libpulse-simple.so.*"
 FILES_libpulse-browse = "${libdir}/libpulse-browse.so.*"
@@ -86,7 +85,7 @@ FILES_${PN}-dev += "${libdir}/pulse-${PV}/modules/*.la ${datadir}/vala ${libdir}
 FILES_${PN}-conf = "${sysconfdir}"
 FILES_${PN}-bin += "${sysconfdir}/default/volatiles/volatiles.04_pulse"
 FILES_${PN}-server = "${bindir}/pulseaudio ${bindir}/start-* ${sysconfdir} ${bindir}/pactl ${base_libdir}/udev/rules.d/*.rules"
-FILES_${PN}-misc = "${bindir}/*"
+FILES_${PN}-misc = "${bindir}/* ${libdir}/pulseaudio/libpulsedsp.so"
 
 # Allow the pulseaudio package to be created empty as a placeholder (-dbg and -dev depend on it)
 ALLOW_EMPTY_${PN} = "1"
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
index 07410a4..6d5eb5f 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
@@ -1,6 +1,6 @@
 require pulseaudio.inc
 
-PR = "r9"
+PR = "r10"
 
 DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
 
-- 
1.7.10

[PATCH 4/4] pulseaudio: remove libpulse-browse, removed upstream in 2011

[Ross Burton]

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc    |    3 +--
 meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb |    2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 8c19c22..1708db7 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -64,7 +64,7 @@ USERADD_PARAM_pulseaudio-server = "--system --home /var/run/pulse \
                               --no-create-home --shell /bin/false \
                               --groups audio,pulse --gid pulse pulse"
 
-PACKAGES =+ "libpulsecore libpulsecommon libpulse libpulse-simple libpulse-browse libpulse-mainloop-glib \
+PACKAGES =+ "libpulsecore libpulsecommon libpulse libpulse-simple libpulse-mainloop-glib \
              pulseaudio-server pulseaudio-misc"
 
 #upgrade path:
@@ -76,7 +76,6 @@ FILES_libpulsecore = "${libdir}/libpulsecore*.so"
 FILES_libpulsecommon = "${libdir}/pulseaudio/libpulsecommon*.so"
 FILES_libpulse = "${libdir}/libpulse.so.*"
 FILES_libpulse-simple = "${libdir}/libpulse-simple.so.*"
-FILES_libpulse-browse = "${libdir}/libpulse-browse.so.*"
 FILES_libpulse-mainloop-glib = "${libdir}/libpulse-mainloop-glib.so.*"
 
 FILES_${PN}-dbg += "${libexecdir}/pulse/.debug \
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
index 6d5eb5f..546a80f 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
@@ -1,6 +1,6 @@
 require pulseaudio.inc
 
-PR = "r10"
+PR = "r11"
 
 DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
 
-- 
1.7.10

Re: [PATCH 1/4] pulseaudio: add GConf dependency

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2108 bytes --]

On Wed, Oct 24, 2012 at 05:37:33PM +0100, Ross Burton wrote:
> Add explicit build-dependency on GConf as currently it's an implicit dependency
> and so vunerable to races at build time.

Isn't better to inherit gconf or the issue I had today with foxtrotgps
does not apply here?

> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-multimedia/pulseaudio/pulseaudio.inc    |    2 +-
>  meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> index 463777d..ab70c7e 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = "file://GPL;md5=4325afd396febcb659c36b49533135d4 \
>  DEPENDS = "libatomics-ops liboil avahi libsamplerate0 libsndfile1 libtool \
>             ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxtst libice libsm libxcb gtk+', '', d)}"
>  # optional
> -DEPENDS += "udev alsa-lib glib-2.0 dbus \
> +DEPENDS += "udev alsa-lib glib-2.0 dbus gconf \
>             ${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '', d)}"
>  
>  SRC_URI = "http://0pointer.de/lennart/projects/pulseaudio/pulseaudio-${PV}.tar.gz \
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
> index a10b953..d25b424 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
> @@ -1,6 +1,6 @@
>  require pulseaudio.inc
>  
> -PR = "r7"
> +PR = "r8"
>  
>  DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
>  
> -- 
> 1.7.10
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH 1/4] pulseaudio: add GConf dependency

[Burton, Ross]

On 24 October 2012 19:09, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Wed, Oct 24, 2012 at 05:37:33PM +0100, Ross Burton wrote:
>> Add explicit build-dependency on GConf as currently it's an implicit dependency
>> and so vunerable to races at build time.
>
> Isn't better to inherit gconf or the issue I had today with foxtrotgps
> does not apply here?

This just links to gconf, no schemas.

Ross

Re: [PATCH 1/4] pulseaudio: add GConf dependency

[Saul Wold]

On 10/24/2012 09:37 AM, Ross Burton wrote:
> Add explicit build-dependency on GConf as currently it's an implicit dependency
> and so vunerable to races at build time.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>   meta/recipes-multimedia/pulseaudio/pulseaudio.inc    |    2 +-
>   meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> index 463777d..ab70c7e 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = "file://GPL;md5=4325afd396febcb659c36b49533135d4 \
>   DEPENDS = "libatomics-ops liboil avahi libsamplerate0 libsndfile1 libtool \
>              ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxtst libice libsm libxcb gtk+', '', d)}"
>   # optional
> -DEPENDS += "udev alsa-lib glib-2.0 dbus \
> +DEPENDS += "udev alsa-lib glib-2.0 dbus gconf \
>              ${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '', d)}"
>
>   SRC_URI = "http://0pointer.de/lennart/projects/pulseaudio/pulseaudio-${PV}.tar.gz \
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
> index a10b953..d25b424 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
> @@ -1,6 +1,6 @@
>   require pulseaudio.inc
>
> -PR = "r7"
> +PR = "r8"
>
>   DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
>
>

Merged this full set to OE-Core

Thanks
	Sau!

Re: [PATCH 1/4] pulseaudio: add GConf dependency

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]

This commit made pulseaudio unbuildable for builds with no GPLv3 packages.

Andrei


On Wed, Oct 24, 2012 at 7:37 PM, Ross Burton <ross.burton@intel.com> wrote:

> Add explicit build-dependency on GConf as currently it's an implicit
> dependency
> and so vunerable to races at build time.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-multimedia/pulseaudio/pulseaudio.inc    |    2 +-
>  meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> index 463777d..ab70c7e 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM =
> "file://GPL;md5=4325afd396febcb659c36b49533135d4 \
>  DEPENDS = "libatomics-ops liboil avahi libsamplerate0 libsndfile1 libtool
> \
>             ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11
> libxtst libice libsm libxcb gtk+', '', d)}"
>  # optional
> -DEPENDS += "udev alsa-lib glib-2.0 dbus \
> +DEPENDS += "udev alsa-lib glib-2.0 dbus gconf \
>             ${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '',
> d)}"
>
>  SRC_URI = "
> http://0pointer.de/lennart/projects/pulseaudio/pulseaudio-${PV}.tar.gz \
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bbb/meta/recipes-multimedia/pulseaudio/
> pulseaudio_2.1.bb
> index a10b953..d25b424 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
> @@ -1,6 +1,6 @@
>  require pulseaudio.inc
>
> -PR = "r7"
> +PR = "r8"
>
>  DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
>
> --
> 1.7.10
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3175 bytes --]

Re: [PATCH 1/4] pulseaudio: add GConf dependency

[Burton, Ross]

On 30 October 2012 09:59, Andrei Gherzan <andrei@gherzan.ro> wrote:
> This commit made pulseaudio unbuildable for builds with no GPLv3 packages.

What causes gconf to not build without GPLv3?

Ross

Re: [PATCH 1/4] pulseaudio: add GConf dependency

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

On Tue, Oct 30, 2012 at 12:02 PM, Burton, Ross <ross.burton@intel.com>wrote:

> On 30 October 2012 09:59, Andrei Gherzan <andrei@gherzan.ro> wrote:
> > This commit made pulseaudio unbuildable for builds with no GPLv3
> packages.
>
> What causes gconf to not build without GPLv3?
>

pulseaudio depends on gconf (because of that racing issues). Now, gconf
inherits gnomebase which adds to gconf's DEPENDS gnome-common package which
is GPLv3. So this is the chain.

ag

[-- Attachment #2: Type: text/html, Size: 821 bytes --]

Re: [PATCH 1/4] pulseaudio: add GConf dependency

[Burton, Ross]

On 30 October 2012 10:10, Andrei Gherzan <andrei@gherzan.ro> wrote:
>> What causes gconf to not build without GPLv3?
>
> pulseaudio depends on gconf (because of that racing issues). Now, gconf
> inherits gnomebase which adds to gconf's DEPENDS gnome-common package which
> is GPLv3. So this is the chain.

Oh joy, one of those instances where GPLv3 isn't actually a problem.

gnome-common is some scripts and tools used at configure time, so
there isn't any linkage, so there isn't any GPLv3 in the images, so
there isn't a problem.

The question is how do we express this?

Ross

Re: [PATCH 1/4] pulseaudio: add GConf dependency

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

On Tue, Oct 30, 2012 at 12:19 PM, Burton, Ross <ross.burton@intel.com>wrote:

> On 30 October 2012 10:10, Andrei Gherzan <andrei@gherzan.ro> wrote:
> >> What causes gconf to not build without GPLv3?
> >
> > pulseaudio depends on gconf (because of that racing issues). Now, gconf
> > inherits gnomebase which adds to gconf's DEPENDS gnome-common package
> which
> > is GPLv3. So this is the chain.
>
> Oh joy, one of those instances where GPLv3 isn't actually a problem.
>
> gnome-common is some scripts and tools used at configure time, so
> there isn't any linkage, so there isn't any GPLv3 in the images, so
> there isn't a problem.
>
> The question is how do we express this?
>
>
Should it be whitelisted?
ag

[-- Attachment #2: Type: text/html, Size: 1134 bytes --]

Re: [PATCH 1/4] pulseaudio: add GConf dependency

[Tomas Frydrych]

On 30/10/12 10:31, Andrei Gherzan wrote:
>> gnome-common is some scripts and tools used at configure time, so
>> there isn't any linkage, so there isn't any GPLv3 in the images, so
>> there isn't a problem.
>>
>> The question is how do we express this?
>>
>>
> Should it be whitelisted?

The problem with whitelisting is that if the usage changes from the
assumptions the whitelisting was originally made on, this will not
automatically remove the whitelisting -- if whitlisting is the solution
here, it needs to be left to the Yocto users to do it locally based on
their own review of the situation.

I think to handle this scenario properly, you would need two sets of
license controls, one for 'build tools' and one for 'things that ship'.

Tomas

Re: [PATCH 1/4] pulseaudio: add GConf dependency

[Burton, Ross]

On 30 October 2012 10:31, Andrei Gherzan <andrei@gherzan.ro> wrote:
>> Oh joy, one of those instances where GPLv3 isn't actually a problem.
>>
>> gnome-common is some scripts and tools used at configure time, so
>> there isn't any linkage, so there isn't any GPLv3 in the images, so
>> there isn't a problem.
>>
>> The question is how do we express this?
>
> Should it be whitelisted?

So I did some digging.  The file in git that is explicitly v3 only
appeared in 3.6, so I considered reverting to 3.5.5 before it
appeared.  Then I noticed that we're still shipping gnome-common 2.28
from 2009, which doesn't have any v3 code in (to be honest it barely
has any license at all, but it's definitely not v3.  I've pinged
upstream.

The v3 license in the metadata came from:

commit 8a2b4e2a5e85f4937e72f03e579b1aaa264074a1
Author: Zhai Edwin <edwin.zhai@intel.com>
Date:   Thu Jul 1 15:35:11 2010 +0800

    gnome-common: Fix the metadata

    Signed-off-by: Zhai Edwin <edwin.zhai@intel.com>

diff --git a/meta/packages/gnome/gnome-common_2.20.0.bb
b/meta/packages/gnome/gnome-common_2.20.0.bb
index 075ac14..c2eae72 100644
--- a/meta/packages/gnome/gnome-common_2.20.0.bb
+++ b/meta/packages/gnome/gnome-common_2.20.0.bb
@@ -1,7 +1,11 @@
-LICENSE = "GPL"
+DESCRIPTION = "Common macros for building GNOME applications"
+HOMEPAGE = "http://www.gnome.org/"
+BUGTRACKER = "https://bugzilla.gnome.org/"
+
+LICENSE = "GPLv3"

Looks like a misguided attempt at fixing a warning from not specifying
what version of GPL was in use.  Traditionally the bulk of GNOME is
LGPLv2.1

But following the dependencies, gnomebase adds DEPENDS=gnome-common.
Shouldn't that be gnome-common-native?  It won't make much difference
to the structure of the sysroot as it's allarch already, but it makes
it clear that in this instance it's a build dependency only.

(patch coming)

Ross

Re: [PATCH 1/4] pulseaudio: add GConf dependency

[Koen Kooi]

Op 30 okt. 2012, om 12:00 heeft "Burton, Ross" <ross.burton@intel.com> het volgende geschreven:

> On 30 October 2012 10:31, Andrei Gherzan <andrei@gherzan.ro> wrote:
>>> Oh joy, one of those instances where GPLv3 isn't actually a problem.
>>> 
>>> gnome-common is some scripts and tools used at configure time, so
>>> there isn't any linkage, so there isn't any GPLv3 in the images, so
>>> there isn't a problem.
>>> 
>>> The question is how do we express this?
>> 
>> Should it be whitelisted?
> 
> So I did some digging.  The file in git that is explicitly v3 only
> appeared in 3.6, so I considered reverting to 3.5.5 before it
> appeared.  Then I noticed that we're still shipping gnome-common 2.28
> from 2009, which doesn't have any v3 code in (to be honest it barely
> has any license at all, but it's definitely not v3.  I've pinged
> upstream.
> 
> The v3 license in the metadata came from:
> 
> commit 8a2b4e2a5e85f4937e72f03e579b1aaa264074a1
> Author: Zhai Edwin <edwin.zhai@intel.com>
> Date:   Thu Jul 1 15:35:11 2010 +0800
> 
>    gnome-common: Fix the metadata
> 
>    Signed-off-by: Zhai Edwin <edwin.zhai@intel.com>
> 
> diff --git a/meta/packages/gnome/gnome-common_2.20.0.bb
> b/meta/packages/gnome/gnome-common_2.20.0.bb
> index 075ac14..c2eae72 100644
> --- a/meta/packages/gnome/gnome-common_2.20.0.bb
> +++ b/meta/packages/gnome/gnome-common_2.20.0.bb
> @@ -1,7 +1,11 @@
> -LICENSE = "GPL"
> +DESCRIPTION = "Common macros for building GNOME applications"
> +HOMEPAGE = "http://www.gnome.org/"
> +BUGTRACKER = "https://bugzilla.gnome.org/"
> +
> +LICENSE = "GPLv3"
> 
> Looks like a misguided attempt at fixing a warning from not specifying
> what version of GPL was in use.  Traditionally the bulk of GNOME is
> LGPLv2.1
> 
> But following the dependencies, gnomebase adds DEPENDS=gnome-common.
> Shouldn't that be gnome-common-native?  

No, it checks for the files in the target sysroot. I can't say it that's a bug or not, though.

regards,

Koen