From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ed Cashin <ecashin@coraid.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aoe: avoid using skb member after dev_queue_xmit
Date: Thu, 25 Oct 2012 06:33:22 +0000 [thread overview]
Message-ID: <20121025063322.GH20754@mwanda> (raw)
In-Reply-To: <20121024150807.82ce2677.akpm@linux-foundation.org>
On Wed, Oct 24, 2012 at 03:08:07PM -0700, Andrew Morton wrote:
> On Wed, 24 Oct 2012 14:26:13 -0400
> Ed Cashin <ecashin@coraid.com> wrote:
>
> > After calling dev_queue_xmit it is no longer safe to access the
> > members of the skb.
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> hm, that was clever. How did Dan detect this bug?
It was a Smatch thing, but it wasn't enabled by default. I think I
will enable it. This is the second bug use after dev_queue_xmit()
in two years.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ed Cashin <ecashin@coraid.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aoe: avoid using skb member after dev_queue_xmit
Date: Thu, 25 Oct 2012 09:33:22 +0300 [thread overview]
Message-ID: <20121025063322.GH20754@mwanda> (raw)
In-Reply-To: <20121024150807.82ce2677.akpm@linux-foundation.org>
On Wed, Oct 24, 2012 at 03:08:07PM -0700, Andrew Morton wrote:
> On Wed, 24 Oct 2012 14:26:13 -0400
> Ed Cashin <ecashin@coraid.com> wrote:
>
> > After calling dev_queue_xmit it is no longer safe to access the
> > members of the skb.
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> hm, that was clever. How did Dan detect this bug?
It was a Smatch thing, but it wasn't enabled by default. I think I
will enable it. This is the second bug use after dev_queue_xmit()
in two years.
regards,
dan carpenter
next prev parent reply other threads:[~2012-10-25 6:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 18:26 [PATCH] aoe: avoid using skb member after dev_queue_xmit Ed Cashin
2012-10-24 18:26 ` Ed Cashin, Ed Cashin
2012-10-24 22:08 ` Andrew Morton
2012-10-24 22:08 ` Andrew Morton
2012-10-25 6:33 ` Dan Carpenter [this message]
2012-10-25 6:33 ` Dan Carpenter
2012-10-25 17:35 ` Ed Cashin
2012-10-25 17:35 ` Ed Cashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025063322.GH20754@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=ecashin@coraid.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.