From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net phy: poll for a link
Date: Thu, 25 Oct 2012 08:37:11 +0200 [thread overview]
Message-ID: <20121025063711.GC27665@pengutronix.de> (raw)
In-Reply-To: <20121024183359.GN21588@game.jcrosoft.org>
On Wed, Oct 24, 2012 at 08:33:59PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 20:06 Wed 24 Oct , Sascha Hauer wrote:
> > Since we have phylib we have no instance which polls for a link. This
> > means that network boot often bails out after a powercycle or phy reset.
> > This changes the link status behaviour to:
> >
> > - Always check for a link if the last link test was unsuccesful
> > - If the last check was succesful, check for a link when the last
> > check is longer than 5 seconds ago
> > - Try to get a link for 5 seconds.
> 5 seconds is too long
>
> and check the link is wrong you need to check the autoneg
> the link may be down because no cable
>
> Here we need to check the autoneg is finished
> and the phy is up
>
> so use phy_aneg_done and genphy_config_aneg is for this
phy_aneg_done is not exported and genphy_config_aneg is for phy driver
use only.
Could you prepare a patch for this? You insisted hard on getting this
merged in the first place and seem to know what has to be done.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-25 6:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 18:06 [PATCH] net phy: poll for a link Sascha Hauer
2012-10-24 18:33 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-24 19:56 ` Eric Bénard
2012-10-25 8:49 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-25 9:05 ` Eric Bénard
2012-10-25 9:11 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-25 12:18 ` Eric Bénard
2012-10-25 6:37 ` Sascha Hauer [this message]
2012-10-28 11:21 ` Sascha Hauer
2012-10-28 12:31 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025063711.GC27665@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.