All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net phy: poll for a link
Date: Sun, 28 Oct 2012 13:31:48 +0100	[thread overview]
Message-ID: <20121028123148.GE28904@game.jcrosoft.org> (raw)
In-Reply-To: <20121028112159.GU24458@pengutronix.de>

On 12:21 Sun 28 Oct     , Sascha Hauer wrote:
> Jean-Christophe,
> 
> On Thu, Oct 25, 2012 at 08:37:11AM +0200, Sascha Hauer wrote:
> > On Wed, Oct 24, 2012 at 08:33:59PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > On 20:06 Wed 24 Oct     , Sascha Hauer wrote:
> > > > Since we have phylib we have no instance which polls for a link. This
> > > > means that network boot often bails out after a powercycle or phy reset.
> > > > This changes the link status behaviour to:
> > > > 
> > > > - Always check for a link if the last link test was unsuccesful
> > > > - If the last check was succesful, check for a link when the last
> > > >   check is longer than 5 seconds ago
> > > > - Try to get a link for 5 seconds.
> > > 5 seconds is too long
> > > 
> > > and check the link is wrong you need to check the autoneg
> > > the link may be down because no cable
> > > 
> > > Here we need to check the autoneg is finished
> > > and the phy is up
> > > 
> > > so use phy_aneg_done and genphy_config_aneg is for this
> > 
> > phy_aneg_done is not exported and genphy_config_aneg is for phy driver
> > use only.
> > 
> > Could you prepare a patch for this? You insisted hard on getting this
> > merged in the first place and seem to know what has to be done.
> 
> Will you prepare a patch for this? This is really something I want to
> have solved before the next release and right now I do not understand
> your proposed solution to this.
next week maybe tuesday or wednesday
I need to finish some work on at91 for the Atmel kernel release
to fix some hw issue

The 1-wire support is needed for this

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2012-10-28 12:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24 18:06 [PATCH] net phy: poll for a link Sascha Hauer
2012-10-24 18:33 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-24 19:56   ` Eric Bénard
2012-10-25  8:49     ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-25  9:05       ` Eric Bénard
2012-10-25  9:11         ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-25 12:18           ` Eric Bénard
2012-10-25  6:37   ` Sascha Hauer
2012-10-28 11:21     ` Sascha Hauer
2012-10-28 12:31       ` Jean-Christophe PLAGNIOL-VILLARD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121028123148.GE28904@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.