[Buildroot] [PATCH v2] fluxbox: select xmodmap

[Buildroot] [PATCH v2] fluxbox: select xmodmap

[yegorslists at googlemail.com]

From: Yegor Yefremov <yegorslists@googlemail.com>

Fluxbox uses xmodmap in its startup script.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
v2: add comment to the Config.in (Thomas Petazzoni)

 package/fluxbox/Config.in |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/package/fluxbox/Config.in b/package/fluxbox/Config.in
index e4d6c37..588e83b 100644
--- a/package/fluxbox/Config.in
+++ b/package/fluxbox/Config.in
@@ -3,6 +3,8 @@ config BR2_PACKAGE_FLUXBOX
 	depends on BR2_PACKAGE_XORG7
 	depends on BR2_INSTALL_LIBSTDCPP
 	select BR2_PACKAGE_XLIB_LIBX11
+	# Runtime dependency, needed by startup script
+	select BR2_PACKAGE_XAPP_XMODMAP
 	help
 	  The Fluxbox lightweight window manager for X
 
-- 
1.7.7

[Buildroot] [PATCH v2] fluxbox: select xmodmap

[Thomas Petazzoni]

Dear yegorslists at googlemail.com,

On Thu, 25 Oct 2012 12:40:52 +0200, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Fluxbox uses xmodmap in its startup script.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH v2] fluxbox: select xmodmap

[Arnout Vandecappelle]

On 25/10/12 12:40, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov<yegorslists@googlemail.com>
>
> Fluxbox uses xmodmap in its startup script.

  I'm not so sure...  The user could change the startup script to remove the
xmodmap (e.g. for a keyboardless device), but now you take away the
possibility to build without it.

  OTOH, xmodmap is so small compared to (tiny)X that it shouldn't matter much.

  Regards,
  Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F