* [PATCH 2/2] mfd: arizona: Correctly report when AIF2/AIF1 is underclocked
@ 2012-10-25 14:14 Charles Keepax
2012-10-25 16:02 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2012-10-25 14:14 UTC (permalink / raw)
To: broonie, sameo; +Cc: patches, linux-kernel
In the interrupt handler for an underclocked event, whilst checking for
the source of the interrupt, AIF3 was checked twice and AIF1 was not
checked. This change correctly checks the AIF1 underclocked bit and
reports the correct error messages for all cases.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/mfd/arizona-core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 166254b..202bf55 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -98,9 +98,9 @@ static irqreturn_t arizona_underclocked(int irq, void *data)
if (val & ARIZONA_AIF3_UNDERCLOCKED_STS)
dev_err(arizona->dev, "AIF3 underclocked\n");
- if (val & ARIZONA_AIF3_UNDERCLOCKED_STS)
- dev_err(arizona->dev, "AIF3 underclocked\n");
if (val & ARIZONA_AIF2_UNDERCLOCKED_STS)
+ dev_err(arizona->dev, "AIF2 underclocked\n");
+ if (val & ARIZONA_AIF1_UNDERCLOCKED_STS)
dev_err(arizona->dev, "AIF1 underclocked\n");
if (val & ARIZONA_ISRC2_UNDERCLOCKED_STS)
dev_err(arizona->dev, "ISRC2 underclocked\n");
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] mfd: arizona: Correctly report when AIF2/AIF1 is underclocked
2012-10-25 14:14 [PATCH 2/2] mfd: arizona: Correctly report when AIF2/AIF1 is underclocked Charles Keepax
@ 2012-10-25 16:02 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-10-25 16:02 UTC (permalink / raw)
To: Charles Keepax; +Cc: sameo, patches, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
On Thu, Oct 25, 2012 at 03:14:13PM +0100, Charles Keepax wrote:
> In the interrupt handler for an underclocked event, whilst checking for
> the source of the interrupt, AIF3 was checked twice and AIF1 was not
> checked. This change correctly checks the AIF1 underclocked bit and
> reports the correct error messages for all cases.
Reviwed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-25 16:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-25 14:14 [PATCH 2/2] mfd: arizona: Correctly report when AIF2/AIF1 is underclocked Charles Keepax
2012-10-25 16:02 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.