All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: tegra: move Tegra EHCI implementation to correct place
Date: Fri, 26 Oct 2012 09:09:49 +0200	[thread overview]
Message-ID: <201210260909.49659.marex@denx.de> (raw)
In-Reply-To: <1351206943-29358-1-git-send-email-dev@lynxeye.de>

Dear Lucas Stach,

> Move the Tegra EHCI implementation to the correct directory in the tree.
> This code is specific to the Tegra EHCI controller, not to the Tegra SoC
> in general.
> 
> This is not just a move of the code, but also some small changes squashed

Unsquash them please, it's really hard to review. Also, use git format-patch -M 
-C to generate the patchset and to detect renames.

> in. Most notable:
> - removed some unneeded parameters from function calls, to make functions
>   more self contained
> - decrease max controller count to 3, both Tegra 2 and 3 have at most 3
>   EHCI controllers, we can aleays increase this later if the need arises
> - controllers only get activated at ehci_hcd_init time, not at
> board_usb_init, which is the more obvious init point and saves time if you
> are not going to use usb in your boot process at all
[...]
Best regards,
Marek Vasut

  reply	other threads:[~2012-10-26  7:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-25 23:15 [U-Boot] [PATCH] usb: tegra: move Tegra EHCI implementation to correct place Lucas Stach
2012-10-26  7:09 ` Marek Vasut [this message]
2012-10-26  7:29   ` Lucas Stach
2012-10-26 10:13     ` Marek Vasut
2012-10-26 16:11       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210260909.49659.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.