From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: tegra: move Tegra EHCI implementation to correct place
Date: Fri, 26 Oct 2012 12:13:06 +0200 [thread overview]
Message-ID: <201210261213.07147.marex@denx.de> (raw)
In-Reply-To: <1351236570.20572.20.camel@tellur>
Dear Lucas Stach,
> Hi Marek,
>
> Am Freitag, den 26.10.2012, 09:09 +0200 schrieb Marek Vasut:
> > Dear Lucas Stach,
> >
> > > Move the Tegra EHCI implementation to the correct directory in the
> > > tree. This code is specific to the Tegra EHCI controller, not to the
> > > Tegra SoC in general.
> > >
> > > This is not just a move of the code, but also some small changes
> > > squashed
> >
> > Unsquash them please, it's really hard to review. Also, use git
> > format-patch -M -C to generate the patchset and to detect renames.
>
> I've generated the patch with format-patch -B -M -C, so what you see is
> basically the diff of the original file with the new implementation. So
> the diff shows all the small changes I blather about.
>
> The changes are squashed in because I did them while moving the
> implementation over, and I would like to avoid doing them in single
> patches as it's notably more work and IMHO with the current diff you can
> clearly see what changed. So please let me know if you are really that
> keen to have them as separate patches, but it may take me some while to
> respin this as I'm occupied with other things right now.
[...]
Let's do it properly please.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-10-26 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 23:15 [U-Boot] [PATCH] usb: tegra: move Tegra EHCI implementation to correct place Lucas Stach
2012-10-26 7:09 ` Marek Vasut
2012-10-26 7:29 ` Lucas Stach
2012-10-26 10:13 ` Marek Vasut [this message]
2012-10-26 16:11 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210261213.07147.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.