From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon (w83627hf) Don't touch nonexistent I2C address registers
Date: Fri, 26 Oct 2012 13:53:50 +0000 [thread overview]
Message-ID: <20121026135350.GA29852@roeck-us.net> (raw)
In-Reply-To: <20121026095859.1725b2a8@endymion.delvare>
On Fri, Oct 26, 2012 at 09:58:59AM +0200, Jean Delvare wrote:
> Only the W83627HF could be accessed through I2C. All other supported
> chips are LPC-only, so they do not have I2C address registers. Don't
> write to nonexistent or reserved registers on these chips.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/hwmon/w83627hf.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> --- linux-3.7-rc2.orig/drivers/hwmon/w83627hf.c 2012-10-26 09:38:18.000000000 +0200
> +++ linux-3.7-rc2/drivers/hwmon/w83627hf.c 2012-10-26 09:50:44.935025004 +0200
> @@ -1732,8 +1732,10 @@ static void __devinit w83627hf_init_devi
> /* Minimize conflicts with other winbond i2c-only clients... */
> /* disable i2c subclients... how to disable main i2c client?? */
> /* force i2c address to relatively uncommon address */
> - w83627hf_write_value(data, W83781D_REG_I2C_SUBADDR, 0x89);
> - w83627hf_write_value(data, W83781D_REG_I2C_ADDR, force_i2c);
> + if (type = w83627hf) {
> + w83627hf_write_value(data, W83781D_REG_I2C_SUBADDR, 0x89);
> + w83627hf_write_value(data, W83781D_REG_I2C_ADDR, force_i2c);
> + }
>
> /* Read VID only once */
> if (type = w83627hf || type = w83637hf) {
>
>
> --
> Jean Delvare
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2012-10-26 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 7:58 [lm-sensors] [PATCH] hwmon (w83627hf) Don't touch nonexistent I2C address registers Jean Delvare
2012-10-26 13:53 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121026135350.GA29852@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.