[lm-sensors] [PATCH] hwmon (w83627hf) Don't touch nonexistent I2C address registers

[lm-sensors] [PATCH] hwmon (w83627hf) Don't touch nonexistent I2C address registers

[Jean Delvare]

Only the W83627HF could be accessed through I2C. All other supported
chips are LPC-only, so they do not have I2C address registers. Don't
write to nonexistent or reserved registers on these chips.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
 drivers/hwmon/w83627hf.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

--- linux-3.7-rc2.orig/drivers/hwmon/w83627hf.c	2012-10-26 09:38:18.000000000 +0200
+++ linux-3.7-rc2/drivers/hwmon/w83627hf.c	2012-10-26 09:50:44.935025004 +0200
@@ -1732,8 +1732,10 @@ static void __devinit w83627hf_init_devi
 	/* Minimize conflicts with other winbond i2c-only clients...  */
 	/* disable i2c subclients... how to disable main i2c client?? */
 	/* force i2c address to relatively uncommon address */
-	w83627hf_write_value(data, W83781D_REG_I2C_SUBADDR, 0x89);
-	w83627hf_write_value(data, W83781D_REG_I2C_ADDR, force_i2c);
+	if (type = w83627hf) {
+		w83627hf_write_value(data, W83781D_REG_I2C_SUBADDR, 0x89);
+		w83627hf_write_value(data, W83781D_REG_I2C_ADDR, force_i2c);
+	}
 
 	/* Read VID only once */
 	if (type = w83627hf || type = w83637hf) {


-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon (w83627hf) Don't touch nonexistent I2C address registers

[Guenter Roeck]

On Fri, Oct 26, 2012 at 09:58:59AM +0200, Jean Delvare wrote:
> Only the W83627HF could be accessed through I2C. All other supported
> chips are LPC-only, so they do not have I2C address registers. Don't
> write to nonexistent or reserved registers on these chips.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>

Acked-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/hwmon/w83627hf.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> --- linux-3.7-rc2.orig/drivers/hwmon/w83627hf.c	2012-10-26 09:38:18.000000000 +0200
> +++ linux-3.7-rc2/drivers/hwmon/w83627hf.c	2012-10-26 09:50:44.935025004 +0200
> @@ -1732,8 +1732,10 @@ static void __devinit w83627hf_init_devi
>  	/* Minimize conflicts with other winbond i2c-only clients...  */
>  	/* disable i2c subclients... how to disable main i2c client?? */
>  	/* force i2c address to relatively uncommon address */
> -	w83627hf_write_value(data, W83781D_REG_I2C_SUBADDR, 0x89);
> -	w83627hf_write_value(data, W83781D_REG_I2C_ADDR, force_i2c);
> +	if (type = w83627hf) {
> +		w83627hf_write_value(data, W83781D_REG_I2C_SUBADDR, 0x89);
> +		w83627hf_write_value(data, W83781D_REG_I2C_ADDR, force_i2c);
> +	}
>  
>  	/* Read VID only once */
>  	if (type = w83627hf || type = w83637hf) {
> 
> 
> -- 
> Jean Delvare
> 
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
> 

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors