[ath9k-devel] [PATCH 1/2] ath9k_htc: Add support for NL80211_IFTYPE_MESH_POINT interfaces

[Antonio Quartulli <ordex@autistici.org>]

Hello,

On Thu, Oct 25, 2012 at 11:44:19AM -0700, Javier Cardona wrote:
> >> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_init.c b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> >> index d98255e..9c5c63c 100644
> >> --- a/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> >> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_init.c
> >> @@ -707,6 +707,8 @@ static void ath9k_set_hw_capab(struct ath9k_htc_priv *priv,
> >>                 IEEE80211_HW_SUPPORTS_PS |
> >>                 IEEE80211_HW_PS_NULLFUNC_STACK |
> >>                 IEEE80211_HW_REPORTS_TX_ACK_STATUS |
> >> +               IEEE80211_HW_SUPPORTS_PER_STA_GTK |
> >> +               IEEE80211_HW_MFP_CAPABLE |
> >>                 IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING;
> >>
> >>         hw->wiphy->interface_modes =
> >> @@ -714,9 +716,11 @@ static void ath9k_set_hw_capab(struct ath9k_htc_priv *priv,
> >>                 BIT(NL80211_IFTYPE_ADHOC) |
> >>                 BIT(NL80211_IFTYPE_AP) |
> >>                 BIT(NL80211_IFTYPE_P2P_GO) |
> >> -               BIT(NL80211_IFTYPE_P2P_CLIENT);
> >> +               BIT(NL80211_IFTYPE_P2P_CLIENT) |
> >> +               BIT(NL80211_IFTYPE_MESH_POINT);
> >>
> >>         hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
> >> +       hw->wiphy->flags |= WIPHY_FLAG_IBSS_RSN;
> >>
> >>         hw->wiphy->flags |= WIPHY_FLAG_IBSS_RSN |
> >
> > Ahem. Antonio added this in:
> > http://comments.gmane.org/gmane.linux.kernel.wireless.general/84066,
> > but that patch also seems to suggest per-STA GTKs are not supported by
> > the HW, so we shouldn't claim support above?
> 
> (Just to let the list know what we just discussed in person...)
> 
> I removed the redundant WIPHY_FLAG_IBSS_RSN and the setting of
> IEEE80211_HW_SUPPORTS_PER_STA_GTK.  We'll retest the series and
> resubmit.
> If anyone interested, the reworked series lives here:
> https://github.com/cozybit/open80211s/tree/ft-ath9k-htc-support
> 

IIRC, per-STA GTK is missing the driver support, so it should not be a HW
constraint. However it is not a problem because group frames are encrypted in
SW.

Cheers,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20121026/83b62808/attachment.pgp