Re: [PATCH v2 5/7] crypto: omap-sham: Convert to use pm_runtime API

All of lore.kernel.org
 help / color / mirror / Atom feed

From: "Mark A. Greer" <mgreer@animalcreek.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
	davem@davemloft.net, dmitry.kasatkin@intel.com,
	rmk+kernel@arm.linux.org.uk, paul@pwsan.com
Subject: Re: [PATCH v2 5/7] crypto: omap-sham: Convert to use pm_runtime API
Date: Fri, 26 Oct 2012 10:10:09 -0700	[thread overview]
Message-ID: <20121026171009.GA23528@animalcreek.com> (raw)
In-Reply-To: <87lieunkat.fsf@deeprootsystems.com>

On Thu, Oct 25, 2012 at 05:34:02PM -0700, Kevin Hilman wrote:
> Hi Mark,

Hi Kevin.

> "Mark A. Greer" <mgreer@animalcreek.com> writes:
> 
> > From: "Mark A. Greer" <mgreer@animalcreek.com>
> >
> > Convert the omap-sham crypto driver to use the
> > pm_runtime API instead of the clk API.
> >
> > CC: Kevin Hilman <khilman@deeprootsystems.com>
> > CC: Paul Walmsley <paul@pwsan.com>
> > CC: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
> > Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
> 
> I can't pretend to fully understand this driver, It looks like the
> current code is doing a bit more fine-grained clock gating, and leaving
> the IP clocked only when needed.
> 
> The proposed version does a 'get' in probe and a 'put' in remove, which
> means the IP will always be enabled (and thus preventing low-power
> states), even when it's not in use.

You're right, and what I did is wrong.  I'll fix this in the next revision.

Thanks,

Mark
--

WARNING: multiple messages have this Message-ID (diff)

From: mgreer@animalcreek.com (Mark A. Greer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/7] crypto: omap-sham: Convert to use pm_runtime API
Date: Fri, 26 Oct 2012 10:10:09 -0700	[thread overview]
Message-ID: <20121026171009.GA23528@animalcreek.com> (raw)
In-Reply-To: <87lieunkat.fsf@deeprootsystems.com>

On Thu, Oct 25, 2012 at 05:34:02PM -0700, Kevin Hilman wrote:
> Hi Mark,

Hi Kevin.

> "Mark A. Greer" <mgreer@animalcreek.com> writes:
> 
> > From: "Mark A. Greer" <mgreer@animalcreek.com>
> >
> > Convert the omap-sham crypto driver to use the
> > pm_runtime API instead of the clk API.
> >
> > CC: Kevin Hilman <khilman@deeprootsystems.com>
> > CC: Paul Walmsley <paul@pwsan.com>
> > CC: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
> > Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
> 
> I can't pretend to fully understand this driver, It looks like the
> current code is doing a bit more fine-grained clock gating, and leaving
> the IP clocked only when needed.
> 
> The proposed version does a 'get' in probe and a 'put' in remove, which
> means the IP will always be enabled (and thus preventing low-power
> states), even when it's not in use.

You're right, and what I did is wrong.  I'll fix this in the next revision.

Thanks,

Mark
--

next prev parent reply	other threads:[~2012-10-26 17:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24  2:36 [PATCH v2 0/7] crypto: omap-sham updates Mark A. Greer
2012-10-24  2:36 ` Mark A. Greer
2012-10-24  2:36 ` [PATCH v2 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod Mark A. Greer
2012-10-24  2:36   ` Mark A. Greer
2012-10-24  2:36 ` [PATCH v2 2/7] ARM: OMAP2xxx: hwmod: Add DMA support for SHAM module Mark A. Greer
2012-10-24  2:36   ` Mark A. Greer
2012-10-24  2:36 ` [PATCH v2 3/7] ARM: OMAP3xxx: hwmod: Convert SHAM crypto device data to hwmod Mark A. Greer
2012-10-24  2:36   ` Mark A. Greer
2012-10-24  2:36 ` [PATCH v2 4/7] ARM: OMAP2+: Remove unnecessary message when no SHA IP is present Mark A. Greer
2012-10-24  2:36   ` Mark A. Greer
2012-10-24  2:36 ` [PATCH v2 5/7] crypto: omap-sham: Convert to use pm_runtime API Mark A. Greer
2012-10-24  2:36   ` Mark A. Greer
2012-10-26  0:34   ` Kevin Hilman
2012-10-26  0:34     ` Kevin Hilman
2012-10-26 17:10     ` Mark A. Greer [this message]
2012-10-26 17:10       ` Mark A. Greer
2012-10-24  2:36 ` [PATCH v2 6/7] crypto: omap-sham: Add code to use dmaengine API Mark A. Greer
2012-10-24  2:36   ` Mark A. Greer
2012-10-24  2:36 ` [PATCH v2 7/7] crypto: omap_sham: Remove usage of private DMA API Mark A. Greer
2012-10-24  2:36   ` Mark A. Greer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121026171009.GA23528@animalcreek.com \
    --to=mgreer@animalcreek.com \
    --cc=davem@davemloft.net \
    --cc=dmitry.kasatkin@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.