From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [pci:pci/misc 1/2] drivers/staging/telephony/ixj.c:7732:38: error: expected ';' before 'pci_resource_start'
Date: Fri, 26 Oct 2012 12:54:15 -0700 [thread overview]
Message-ID: <20121026195415.GA1517@kroah.com> (raw)
In-Reply-To: <1351199661.2581.4.camel@joe-AO722>
On Thu, Oct 25, 2012 at 02:14:21PM -0700, Joe Perches wrote:
> On Fri, 2012-10-26 at 02:30 +0800, Fengguang Wu wrote:
> > Hi Joe,
> >
> > FYI, kernel build failed on
> >
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/misc
> > head: 334a57560cf08a04f530aa5546b4c9379c622544
> > commit: f23a277e64d8173e8cddd9e1903c3f9a564aaae5 [1/2] PCI: Convert pci_resource_<foo> macros to static inlines
> > config: x86_64-allmodconfig # make ARCH=x86_64 allmodconfig
> >
> > All error/warnings:
> >
> > drivers/staging/telephony/ixj.c: In function 'ixj_probe_pci':
> > drivers/staging/telephony/ixj.c:7732:13: warning: assignment makes integer from pointer without a cast [enabled by default]
> > drivers/staging/telephony/ixj.c:7732:38: error: expected ';' before 'pci_resource_start'
> > --
> > drivers/scsi/gdth.c: In function 'gdth_init_pci':
> > drivers/scsi/gdth.c:1111:34: error: lvalue required as left operand of assignment
> >
> > vim +7732 drivers/staging/telephony/ixj.c
> >
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7726 if (pci_enable_device(pci))
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7727 break;
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7728 j = new_ixj(pci_resource_start(pci, 0));
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7729 if (!j)
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7730 break;
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7731
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 @7732 j->serial = (PCIEE_GetSerialNumber)pci_resource_start(pci, 2);
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7733 j->XILINXbase = j->DSPbase + 0x10;
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7734 j->cardtype = QTI_PHONEJACK_PCI;
> > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7735 j->board = *cnt;
> >
>
> Hi Fengguang.
>
> telephony is scheduled for removal one day soon.
> Likely no one has a working card.
Ah, I forgot about that one, I'll just go delete it, it's past when we
said it would go away, so we've waited long enough now.
thanks,
greg k-h
prev parent reply other threads:[~2012-10-26 19:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50898531.SQlMpMyNVfj8BHXY%fengguang.wu@intel.com>
2012-10-25 21:14 ` [pci:pci/misc 1/2] drivers/staging/telephony/ixj.c:7732:38: error: expected ';' before 'pci_resource_start' Joe Perches
2012-10-26 19:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121026195415.GA1517@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=fengguang.wu@intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.