* Re: [pci:pci/misc 1/2] drivers/staging/telephony/ixj.c:7732:38: error: expected ';' before 'pci_resource_start' [not found] <50898531.SQlMpMyNVfj8BHXY%fengguang.wu@intel.com> @ 2012-10-25 21:14 ` Joe Perches 2012-10-26 19:54 ` Greg KH 0 siblings, 1 reply; 2+ messages in thread From: Joe Perches @ 2012-10-25 21:14 UTC (permalink / raw) To: Fengguang Wu; +Cc: Bjorn Helgaas, Greg KH, LKML On Fri, 2012-10-26 at 02:30 +0800, Fengguang Wu wrote: > Hi Joe, > > FYI, kernel build failed on > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/misc > head: 334a57560cf08a04f530aa5546b4c9379c622544 > commit: f23a277e64d8173e8cddd9e1903c3f9a564aaae5 [1/2] PCI: Convert pci_resource_<foo> macros to static inlines > config: x86_64-allmodconfig # make ARCH=x86_64 allmodconfig > > All error/warnings: > > drivers/staging/telephony/ixj.c: In function 'ixj_probe_pci': > drivers/staging/telephony/ixj.c:7732:13: warning: assignment makes integer from pointer without a cast [enabled by default] > drivers/staging/telephony/ixj.c:7732:38: error: expected ';' before 'pci_resource_start' > -- > drivers/scsi/gdth.c: In function 'gdth_init_pci': > drivers/scsi/gdth.c:1111:34: error: lvalue required as left operand of assignment > > vim +7732 drivers/staging/telephony/ixj.c > > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7726 if (pci_enable_device(pci)) > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7727 break; > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7728 j = new_ixj(pci_resource_start(pci, 0)); > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7729 if (!j) > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7730 break; > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7731 > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 @7732 j->serial = (PCIEE_GetSerialNumber)pci_resource_start(pci, 2); > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7733 j->XILINXbase = j->DSPbase + 0x10; > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7734 j->cardtype = QTI_PHONEJACK_PCI; > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7735 j->board = *cnt; > Hi Fengguang. telephony is scheduled for removal one day soon. Likely no one has a working card. I presume that's an existing bug in the code that this change exposed only for x86-64 as there's no failure for this code x86-32. Likely too this code never worked for x86-64. I presume that line should have been something like this as otherwise PCIEE_GetSerialNumber is not called. drivers/staging/telephony/ixj.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/telephony/ixj.c b/drivers/staging/telephony/ixj.c index 1cfa0b0..df45ad0 100644 --- a/drivers/staging/telephony/ixj.c +++ b/drivers/staging/telephony/ixj.c @@ -7729,7 +7729,7 @@ static int __init ixj_probe_pci(int *cnt) if (!j) break; - j->serial = (PCIEE_GetSerialNumber)pci_resource_start(pci, 2); + j->serial = PCIEE_GetSerialNumber(pci_resource_start(pci, 2)); j->XILINXbase = j->DSPbase + 0x10; j->cardtype = QTI_PHONEJACK_PCI; j->board = *cnt; ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [pci:pci/misc 1/2] drivers/staging/telephony/ixj.c:7732:38: error: expected ';' before 'pci_resource_start' 2012-10-25 21:14 ` [pci:pci/misc 1/2] drivers/staging/telephony/ixj.c:7732:38: error: expected ';' before 'pci_resource_start' Joe Perches @ 2012-10-26 19:54 ` Greg KH 0 siblings, 0 replies; 2+ messages in thread From: Greg KH @ 2012-10-26 19:54 UTC (permalink / raw) To: Joe Perches; +Cc: Fengguang Wu, Bjorn Helgaas, LKML On Thu, Oct 25, 2012 at 02:14:21PM -0700, Joe Perches wrote: > On Fri, 2012-10-26 at 02:30 +0800, Fengguang Wu wrote: > > Hi Joe, > > > > FYI, kernel build failed on > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/misc > > head: 334a57560cf08a04f530aa5546b4c9379c622544 > > commit: f23a277e64d8173e8cddd9e1903c3f9a564aaae5 [1/2] PCI: Convert pci_resource_<foo> macros to static inlines > > config: x86_64-allmodconfig # make ARCH=x86_64 allmodconfig > > > > All error/warnings: > > > > drivers/staging/telephony/ixj.c: In function 'ixj_probe_pci': > > drivers/staging/telephony/ixj.c:7732:13: warning: assignment makes integer from pointer without a cast [enabled by default] > > drivers/staging/telephony/ixj.c:7732:38: error: expected ';' before 'pci_resource_start' > > -- > > drivers/scsi/gdth.c: In function 'gdth_init_pci': > > drivers/scsi/gdth.c:1111:34: error: lvalue required as left operand of assignment > > > > vim +7732 drivers/staging/telephony/ixj.c > > > > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7726 if (pci_enable_device(pci)) > > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7727 break; > > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7728 j = new_ixj(pci_resource_start(pci, 0)); > > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7729 if (!j) > > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7730 break; > > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7731 > > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 @7732 j->serial = (PCIEE_GetSerialNumber)pci_resource_start(pci, 2); > > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7733 j->XILINXbase = j->DSPbase + 0x10; > > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7734 j->cardtype = QTI_PHONEJACK_PCI; > > ^1da177e drivers/telephony/ixj.c Linus Torvalds 2005-04-16 7735 j->board = *cnt; > > > > Hi Fengguang. > > telephony is scheduled for removal one day soon. > Likely no one has a working card. Ah, I forgot about that one, I'll just go delete it, it's past when we said it would go away, so we've waited long enough now. thanks, greg k-h ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-26 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <50898531.SQlMpMyNVfj8BHXY%fengguang.wu@intel.com>
2012-10-25 21:14 ` [pci:pci/misc 1/2] drivers/staging/telephony/ixj.c:7732:38: error: expected ';' before 'pci_resource_start' Joe Perches
2012-10-26 19:54 ` Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.